Skip to content

Changes

Summary

  1. releng: Bump maven-antrun-plugin from 1.8 to 3.1.0 (details)
  2. releng: Bump build-helper-maven-plugin to v3.4.0 (details)
  3. releng: Bump maven-javadoc-plugin from v3.1 to 3.5 (details)
  4. releng: Bump mvn build plugin versions in pom.xml (details)
  5. linux: Move SWSLatency analysis to Trace Compass core (details)
  6. linux: Move SWSLatency outputs to Trace Compass core (details)
Commit cb17493428c898d5d9a5c200d18b6d931db07d24 by Marco Miller
releng: Bump maven-antrun-plugin from 1.8 to 3.1.0

Change-Id: I77bdb66ceec2f7aa804d164b0ff44ccf56067138
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203614
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified pom.xml (diff)
The file was modified releng/org.eclipse.tracecompass.releng-site/pom.xml (diff)
Commit d7839b0d6109e7730f3edbe88ecc29f3bd6ccfa6 by Marco Miller
releng: Bump build-helper-maven-plugin to v3.4.0

Bump the build-helper-maven-plugin version from 3.0.0 to 3.4.0.

Change-Id: Ic2b47d2d080c99a05880911c63d80e067b899dd8
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203615
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified releng/org.eclipse.tracecompass.target/pom.xml (diff)
Commit 06bb1a20aaa4d747e66a49ffeb4356cd3f238b8f by Marco Miller
releng: Bump maven-javadoc-plugin from v3.1 to 3.5

Change-Id: Ic3f8a0105e96e3010716bda1499a3e006bb2725f
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203616
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified pom.xml (diff)
Commit 121f90ee65157ce00aa45c616ea15fe55b11940e by Marco Miller
releng: Bump mvn build plugin versions in pom.xml

Bump the single maven build plugin versions in ./pom.xml that are left
to upgrade, except the ones mentioned below.

Do not bump the maven-install-plugin version now, as doing so fails the
build currently. -Same for the tycho version which requires another
focused task, being even less trivial to address.

Change-Id: I331055391f84eeebcebd74fd4b12f9e7af4860c8
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203617
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified pom.xml (diff)
Commit 37f9cf25d068b999eee67782bfbbbfe853bf0faa by Marco Miller
linux: Move SWSLatency analysis to Trace Compass core

The SWSLatency computes the latency between the sched_wakeup event and
the sched_switch event for each thread. It is a subclass of
AbstractSegmentStoreAnalysisEventBasedModule.

This commit moves the SWSLatency analysis from the incubator to Trace
Compass core by copying the necessary files from
org.eclipse.tracecompass.incubator.internal.kernel.core.swslatency to
org.eclipse.tracecompass.analysis.os.linux.core.swslatency and making
necessary changes to existing configuration files. It also moves unit
tests for the analysis to Trace Compass core.

To test the analysis:

[1] Run the unit tests in
org.eclipse.tracecompass.analysis.os.linux.core.tests.swslatency
as J-unit plug-in tests. Confirm that they all pass. The goal is to test
that the analysis runs and provides expected output.
[2] Run the unit tests in
org.eclipse.tracecompass.integration.core.tests.dataproviders
as J-unit plug-in tests. Confirm that they all pass. Adding the new
analysis generates new DataProviderDescriptor(s). This is to make sure
that the existing test in this package is updated.
[3] Open Trace Compass. Open a kernel trace. Make sure that the
Scheduler Wakeup to Scheduler Switch Latency analysis is visible and not
crossed out under Views in the Project Explorer. It is normal to have no
output under the analysis because they are not yet included in this
commit. This is required to make sure that the analysis is exposed to
users in the UI of the Trace Compass application.

To be done in subsequent patches:

[1] Migrate outputs of the SWSLatency analysis
[2] Renaming the SWSLatency analysis to
SchedulerWakeupToSchedulerSwitchLatency to make the name of the analysis
easier to understand
[3] Add documentation
[4] Deprecate the SWSLatency analysis in the incubator

[Added] SWSLatency (SchedulerWakeupToSchedulerSwitchLatency) analysis

Change-Id: I7e105c4bae2042fd230d43eee9e97972113b8529
Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203530
Tested-by: Marco Miller <marco.miller@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Marco Miller <marco.miller@ericsson.com>
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/testfiles/sws_analysis.xml
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/swslatency/messages.properties
The file was modified analysis/org.eclipse.tracecompass.analysis.os.linux.core/plugin.properties (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/src/org/eclipse/tracecompass/analysis/os/linux/core/tests/swslatency/SWSLatencyTest.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core/icons/swslatency.png
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/swslatency/SchedWS.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/swslatency/SWSLatencyAnalysis.java
The file was modified analysis/org.eclipse.tracecompass.analysis.os.linux.core/META-INF/MANIFEST.MF (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/swslatency/Messages.java
The file was modified analysis/org.eclipse.tracecompass.analysis.os.linux.core/plugin.xml (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/swslatency/package-info.java
The file was modified releng/org.eclipse.tracecompass.integration.core.tests/src/org/eclipse/tracecompass/integration/core/tests/dataproviders/DataProviderManagerTest.java (diff)
Commit baeef85b1d5f1f1665329dbf8dc190d9b7bcbdc4 by Matthew Khouzam
linux: Move SWSLatency outputs to Trace Compass core

This commit moves the following outputs of the SWSLatency analysis from
the incubator to Trace Compass core:

[1] Sched Wakeup/Switch Latencies output: A re-use of the
SegmentStoreTableView provided by Trace Compass. Each segment is the
time difference between a sched_wakeup event and a sched_switch event of
the same process, identified by the same TID.

[2] Sched Wakeup/Switch Latency vs Time view: which uses the existing
AbstractSegmentStoreScatterChartTreeViewer2 for its left side and the
new SWSLatencyScatterGraphViewer for its right side. This view is a
scatter chart, with each point showing the sched_wakeup/sched_switch
latency vs the time when the latency happens.

[3] Sched Wakeup/Switch Statistics view: A re-use of the
SegmentStoreStatisticsView provided by Trace Compass. This view displays
different statistics relating to the SWSLatency analysis, with each
level corresponding to a process.

[4] Sched Wakeup/Switch Density view: which uses the existing
SegmentStoreTableViewer for its left side and the new
SWSLatencyDensityViewer for its right side. This density view shows the
number of latencies that corresponds to a specific duration.

Manual testing is required to make sure the outputs provided by the
analysis are consistent and to ensure that they are exposed to the users
in the UI of Trace Compass. There are no unit tests for the SWSLatency
outputs. To test the outputs:

[1] Open a kernel trace that contains sched_wakeup and sched_switch
events. Make sure that all of the 4 outputs are visible under Sched
Wakeup Switch analysis.

[2] Sched Wakeup/Switch Latencies: Make sure there is a duration column.
When clicked on an entry, a group of consecutive rows should be
highlighted in the trace tab. The first event (in the group) should be a
sched_wakeup event and the last one should be a sched_switch event. The
tid of the sched_wakeup event should be the same as the next_tid of the
sched_switch event. The difference of the time stamp of the first and
last event should be the same as the value as the duration column.

[3] For the rest of the views, cross check to make sure that the data
displayed make sense. For example, pick an event type, such as ls, and
make sure that the event count in the Sched Wakeup/Switch Statistics
view is the same as the number of dots displayed in the Sched
Wakeup/Switch Latency vs Time view.

Change-Id: Ibdd3ed5f2260f7638e1c581e6bf1ad3d22083aa6
Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203535
Reviewed-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/icons/obj16/latency.png
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/swslatency/messages.properties
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/icons/obj16/density.png
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/swslatency/SWSLatencyDensityView.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/swslatency/SWSLatencyScatterView.java
The file was modified analysis/org.eclipse.tracecompass.analysis.os.linux.ui/plugin.xml (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/swslatency/SWSLatencyScatterGraphViewer.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/swslatency/package-info.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/swslatency/Messages.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/icons/obj16/scatter.png
The file was modified analysis/org.eclipse.tracecompass.analysis.os.linux.ui/plugin.properties (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/swslatency/SWSDensityViewer.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.ui/icons/obj16/statistics_view.gif