Changes

tmf: Fix missing final sonarlint in TimeGraphEntry

Fix the SonarLint issue [1] below in TimeGraphEntry. Doing so happens to
fix a few more reported issues being consequences of [1].

Bump the necessary versioning, based on the Eclipse API build.

[1] Make this "public static WITHIN_COMPARATOR" field final.

Change-Id: I88528fc8a5bcfc00f82b708d07f87c500dfbaa1d
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201541
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated IElementResolver

Replace it with ICoreElementResolver use, as prescribed by the
deprecation notice.

Deprecated in commit 2d3d2f02cd, since v7.1.0.

Bump the necessary versioning, based on the Eclipse API build.

Fix the default Eclipse formatting where lightly applicable while there.

Reorganize the imports while doing these replacements, accordingly.

[Removed] o.e.t.tmf.core.model.timegraph.IElementResolver

Change-Id: Ic0fd3f2461b210939abe721152c2a7ba39a45726
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201542
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated IFilterProperty

Replace it with CoreFilterProperty use, as prescribed by the deprecation
notice.

Deprecated in commit 2d3d2f02cd, since v7.1.0.

Fix the default Eclipse formatting where lightly applicable while there.

Reorganize the imports while doing these replacements, accordingly.

[Removed] o.e.t.tmf.core.model.timegraph.IFilterProperty

Change-Id: I7e4e1560ada84be47b4f4e28e4776af034180ad9
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201567
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix warning in o.e.t.i.tmf.core.model.filters

Fix the Eclipse warning(s) [1] below, in every file from that package,
by removing these redundant annotations.

Fix the default Eclipse formatting where lightly applicable while there.

[1] "The nullness annotation is redundant with a default that applies to
this location".

Change-Id: Id33e49c4850035a8709cf45c94ef29878c87959c
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201568
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix default Eclipse formatting for these two

Fix the default Eclipse formatting for these files, while preserving
(slightly amending) some one-liner comments. Reformat namely
TmfCommonXAxisChartViewer and AbstractStateSystemTimeGraphView.

Change-Id: I56157cabf25206cc1cb97a78bb3a3c08f044e969
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201569
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix some SonarLint issues in TimeGraphControl

Fix the few SonarLint issues [1,2,3] below in TimeGraphControl.

[1] Declare "endTime" on a separate line.
[2] Either remove or fill this block of code.
[3] Immediately return this expression instead of assigning it to the
temporary variable "x".

Change-Id: I8fc05b5cd92363ccb9fc5d9cf07e27522ac0d887
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201570
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove deprecated IPropertyCollection

Replace it with ICorePropertyCollection use, as prescribed by the
deprecation notice.

Deprecated in commit 2d3d2f02cd, since v7.1.0.

[Removed] o.e.t.tmf.core.model.timegraph.IPropertyCollection

Change-Id: Ib20beb2c2301088d886e596737f131a70adab342
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201573
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated IMetadataStrings

Replace it with CoreMetadataStrings use, as prescribed by the
deprecation notice.

Deprecated in commit 2d3d2f02cd, since v7.1.0.

[Removed] o.e.t.tmf.core.model.timegraph.IMetadataStrings

Change-Id: I6db8a71a890bc92279930a21d41ee3ecb5e193b2
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201574
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated (unused) CallStackPresentationProvider

Deprecated in commit 2efecf84bb, since v7.1.0.

Bump the necessary versioning, based on the Eclipse API build.

[Removed] o.e.t.analysis.profiling.ui.views.flamechart.CallStackPresentationProvider

Change-Id: I97b7f29d925575089cb8ac322f672cb0be427c38
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201576
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated (unused) ICommonXAxisModel

Deprecated in commit 4988694f35, since v8.0.0.

[Removed] o.e.t.tmf.core.viewmodel.ICommonXAxisModel

Change-Id: Ic4562114466cf4efd20d166010beb3d9425c1125
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201578
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove deprecated, unused IYAppearance

Deprecated in commit 750e6d3da7, since v8.0.0.

[Removed] o.e.t.tmf.core.presentation.IYAppearance

Change-Id: Id0e4d37032f74e5cabda9cff4b59db338081e252
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201579
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Fix unsafe expanding of archive file

Fix issue for zipFile expanding archive file HotSpots. Related to
[1]'s HotSpots issue.

Unit tests were added to add code coverage to the new method in the
class StandardImportAndReadSmokeTest.

[1] https://sonarcloud.io/organizations/eclipse/rules?open=java%3AS5042&rule_key=java%3AS5042

Change-Id: I87d2275842f2c7f928748f14c3e40de1fe0d1179
Signed-off-by: Estelle Foisy <estelle.foisy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201026
Reviewed-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Bug 581856: Remove the deprecated hasCommonXAxis()

Deprecated in commit 843c8f4f6c, since v8.0.0.

Fix the surrounding Eclipse warning(s) [1] while amending these files.

[1] "The nullness annotation is redundant with a default that applies to
this location".

[Removed] o.e.t.tmf.core.model.TmfCommonXAxisModel.hasCommonXAxis()
[Removed] o.e.t.tmf.core.model.TmfXyModel.hasCommonXAxis()
[Removed] o.e.t.tmf.core.model.xy.ITmfXyModel.hasCommonXAxis()

Change-Id: I0b5b04b4beb66ecccd34385f29f345072733207a
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201589
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated getXValues()

Deprecated in commit 843c8f4f6c, since v8.0.0.

[Removed] o.e.t.tmf.core.model.TmfCommonXAxisModel.getXValues()
[Removed] o.e.t.tmf.core.model.xy.ITmfCommonXAxisModel.getXValues()

Change-Id: Iadd52a8c02e615d8b04c7a5de655d3eb78b8bc45
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201590
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Undeprecate {I}TmfCommonXAxisModel.getYSeriesData

Undeprecate this method in these two related types [1,2], as it is still
(genuinely) used within [3], below.

Originally deprecated in commit 843c8f4f6c, since v8.0.0.

[1] o.e.t.tmf.core.model.xy.ITmfCommonXAxisModel.getYSeriesData()
[2] o.e.t.tmf.core.model.TmfCommonXAxisModel.getYSeriesData()
[3] o.e.t.tmf.core.model.xy.TmfTreeXYCompositeDataProvider.fetchXY

Change-Id: Ibbe6a48c9e0646838ac7a36aaf0755cb13f615f1
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201591
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated {I}YSeries

Deprecated in commit a4cb21bc6b, since v8.0.0.

[Removed] o.e.t.tmf.core.viewmodel.IYSeries
[Removed] o.e.t.tmf.core.viewmodel.YSeries

Change-Id: Ie723121f41baa5924f8cefd64247a9369ced744c
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201592
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated DisplayType.AREA

Deprecated in commit b21c267e2c, since v8.0.0.

[Removed] o.e.t.tmf.core.model.xy.ISeriesModel.DisplayType.AREA

Change-Id: Iecf711e75f8348b6cf087f2845e2c8d143db3aa9
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201593
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove deprecated DataProviderManager.getDataProvider

Replace it with sibling getOrCreateDataProvider use, as prescribed by
the deprecation notice.

Deprecated in commit cee48a6d30, since v8.0.0.

[Removed] o.e.t.tmf.core.dataprovider.DataProviderManager.getDataProvider

Change-Id: I682e5e49692c1196d66ebd4cbc2bdf65dfb12267
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201595
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix DataProviderManager formatting in Eclipse

While slightly amending a one-liner comment to keep it fit on that line.

Change-Id: I5f0537a38d0cd412feb0b71a1e6a9fec92ded15e
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201596
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated ITimeEventStyleStrings

Replace it with StyleProperties use, as prescribed by the deprecation
notice.

Deprecated in commit fdf0396d9c, since v8.0.0.

Fix the Eclipse formatting in ITimeGraphPresentationProvider while here.

[Removed] o.e.t.tmf.ui.widgets.timegraph.model.ITimeEventStyleStrings

Change-Id: I9d3352cb6c40ddfffef0dcd3292c4e7253de91f0
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201601
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Add multi stage Dockerfile to build Trace Compass

1. The stage "packager" installs the minimum package needed to
compile tracecompass.
2. Then it will copy the project inside the container then run
the command to build tracecompass.
3. After the build, it will go to the next stage and this stage will
just have the bare minimum configuration to run tracecompass.
4. It will copy tracecompass already installed into the new stage.

[Added] Multi stage Dockerfile to build Trace Compass

This change can be exercised through the companion Incubator change [1].

[1]https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/199977

Change-Id: I371d50331fcd5989a3f672044a05b9f1914974f7
Signed-off-by: Ahmad Faour <ahmad.faour@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/199945
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marco Miller <marco.miller@ericsson.com>