Changes

Bug 581856: Remove deprecated YAppearance class

Remove the YAppearance class, deprecated since v8.0.0.

Deprecated in commit 1748d6f11e.

[Removed] o.e.t.internal.tmf.core.presentation.YAppearance

Change-Id: I52cf6015107dca1786b632cc7e11cf6f13f80cc0
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201514
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis,tmf: Fix some redundant null annotations

Fix the Eclipse warnings [1] below by removing these few (redundant)
nullness annotations. Do so namely in SystemCall,
AbstractSegmentStoreTableViewer and (tmf) AbstractTimeGraphView.

[1] "The nullness annotation is redundant with a default that applies to
this location".

Change-Id: I257b9f4d988f91b2d37c2f4ddcfbcad6911e0a55
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201537
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix default Eclipse formatting in these (few)

Fix the default Eclipse formatting across these few revisited files;
namely TmfTraceType, TraceTypeHelper, AbstractSelectTreeViewer2,
AbstractTimeGraphView and TimeGraphEntry.

Skip such reformatting for some lines, for legacy preservation purposes.

Slightly amend the text for reformatted yet trivial one-liner comments.

Change-Id: I7f6e048584e887be3dd83c84033620caaec81b02
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201538
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix a few SonarLint issues in TmfExperiment

Fix a few SonarLint issues ([1,2] below) in TmfExperiment.

[1] Immediately return this expression instead of assigning it to the
temporary variable "context".

[2] Remove the "timeRange" field and declare it as a local variable in
the relevant methods.

Change-Id: Ifbabec0fb8a0b61c422e532f4ea53e88069b22c8
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201539
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix non-externalized string warning in AbstractSelectTreeViewer2

Fix the Eclipse warning [1] below in AbstractSelectTreeViewer2.

[1] "Non-externalized string literal; it should be followed by
//$NON-NLS-<n>$".

Change-Id: Ifc940a7b6f44de8cbe00049c6f740a36d9444557
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201540
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>