Skip to content

Changes

Summary

  1. git: Remove redundant ** in these .gitignore files (details)
  2. Ignore temporary build artifacts during maven builds (details)
  3. ftrace: fix trace entry size computation when header len is 0 (details)
Commit 063c3557c773bc58dc6e1ce6b1b69de73dd488e2 by Marco Miller
git: Remove redundant ** in these .gitignore files

As such use of **/ versus no prefix lends the same effect per [1] below.

Fix sorting while editing these, based on the documented LC_COLLATE=C.

[1] https://git-scm.com/docs/gitignore#_pattern_format

Change-Id: I25a6cf5614da318ecdd3ba0e0ca50ed239964985
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/197753
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified .gitignore (diff)
The file was modified skeleton/skeleton.rcp/.gitignore (diff)
Commit 57af22c49f20b9df05c56d3c1adf088f3d361151 by Bernd Hufmann
Ignore temporary build artifacts during maven builds

Add .polyglot.build.properties and .tycho-consumer-pom.xml to .gitignore
because they are temporary build artifacts and are not meant to be under
source control.

Change-Id: Ieb61777d5018b8e9ea6dd99ed274e9996c40c43f
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/197831
Tested-by: Marco Miller <marco.miller@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Marco Miller <marco.miller@ericsson.com>
The file was modified .gitignore (diff)
Commit 5f6ec6acf629f8d2ead867f06d7049b47c50cff8 by Bernd Hufmann
ftrace: fix trace entry size computation when header len is 0

In a trace.dat files, trace entries have a 32 bit header that contains
the payload len (in 32 bit words) in the lower 5 bits.

A len of 0 is a special case: the actual entry length is in the next
32 bit word, and that length includes the length field itself, so:

- the event data starts after the length fields
- the event data is len_in_next_word - 4

For documentation see:
https://elixir.bootlin.com/linux/latest/source/include/linux/ring_buffer.h#L51

Change-Id: I91a459deb11c63f606406b6a1dac9b2b4fcf9130
Signed-off-by: Fabrizio Iannetti <fabrizio.iannetti@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/197834
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hoang Thuan Pham <hoangpham.eclipse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ftrace.core/src/org/eclipse/tracecompass/incubator/internal/ftrace/core/binary/iterator/BinaryFTraceCPUPageIterator.java (diff)