Skip to content
Success

Changes

Summary

  1. ftrace: Replace Java 11-only isBlank method with 8 (details)
  2. server: Bug 579456: trace-server: use time range in TSP queries (details)
  3. server: Consolidate query parameters validation and conversion (details)
Commit 40e26bc7eb9aa3295637b7e731f8fe89b165b581 by Matthew Khouzam
ftrace: Replace Java 11-only isBlank method with 8

As MANIFEST files still have Bundle-RequiredExecutionEnvironment set to
JavaSE-1.8, which Eclipse assumes upon trying to build the code. There
was a build error [1] before this change.

[1] The method isBlank() is undefined for the type String

Change-Id: Icdf3ff944eea92b095a2a10ddb6e88b735184683
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/192477
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ftrace.core/src/org/eclipse/tracecompass/incubator/internal/ftrace/core/event/GenericFtraceField.java (diff)
Commit 9a1071a9911867a3a4bf8a177b71726192641a6b by Patrick Tasse
server: Bug 579456: trace-server: use time range in TSP queries

In queries that require sampling of timestamps, replace the large
requested_times array with a requested_timerange object.

The timestamp array is then computed in the trace server.

For the tree endpoint, replace requested_times array of [start, end]
with a requested_timerange object with no nbTimes.

For backward compatibility, the computed array is then put in the query
parameters as the requested_times, overwriting it if present.

Change-Id: I4549118df6d0b298bdc8f72dbbee8a7aa3a5f8d7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/191752
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/ArrowsQueryParameters.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/RequestedQueryParameters.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/webapp/QueryParametersDeserializer.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/DataProviderService.java (diff)
The file was addedtrace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/TimeRange.java
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/services/DataProviderServiceTest.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/AnnotationsQueryParameters.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/EndpointConstants.java (diff)
Commit e4e6768fcc1a199ccfaea9089f739e0283a1ba55 by Patrick Tasse
server: Consolidate query parameters validation and conversion

Add QueryParameterUtil class with method to validate each endpoint's
query parameters map.

The method will verify the presence of required parameters and translate
parameters when necessary to conform with the data provider interfaces.

When a specific parameter is missing or invalid, identify it in the
error message response.

Remove the QueryParametersDeserializer which is no longer needed.

Make the parameters field non-null in QueryParameters and assign empty
map in constructor when not received.

Fix TraceQueryParameters "uri" Json property name.

Bug: 579456

Change-Id: I1cf727d5d1087e7f511fa2a7a62490b5a41d4807
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/192291
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was addedtrace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/services/QueryParametersUtilTest.java
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/views/QueryParameters.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/TraceQueryParameters.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/services/DataProviderServiceTest.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/services/XmlManagerServiceTest.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/ExperimentManagerService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/DataProviderService.java (diff)
The file was addedtrace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/QueryParametersUtil.java
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/TraceManagerService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/webapp/JacksonObjectMapperProvider.java (diff)
The file was removedtrace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/webapp/QueryParametersDeserializer.java