Skip to content

Changes

Summary

  1. linux.core: Add interface for segments that have a priority property (details)
  2. tmf: Add configuration source extension point and classes (details)
  3. timing.core: Refactor statistics analysis to add generic segment type (details)
  4. xml: Implement configuration extension for xml analysis (details)
Commit 0f259838d108e691aa6a8e1bb45b9b7047a6612f by Matthew Khouzam
linux.core: Add interface for segments that have a priority property

This commit adds the IPrioritySegment interface. The interface is to be
implemented by segments that have a priority to provide.

[Added] Interface for segments that have priority.

Change-Id: I27bf6482667a90d0209448f26fecea26ae3c1491
Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204378
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was addedanalysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/internal/analysis/os/linux/core/segmentstore/IPrioritySegment.java
Commit 5eefaf285125eae4df3b06340449b9ed8a45bf03 by Bernd Hufmann
tmf: Add configuration source extension point and classes

Introduction of "org.eclipse.tracecompass.tmf.core.config" extension
point. Extensions need to implement the interface
"ITmfConfigurationSource". The "TmfConfigurationSourceManager" will
read all extensions and interested parties can get all configuration
source types implementing"ITmfConfigurationSourceType" and their
"ITmfConfigurationSource". Using the "ITmfConfigurationSource"
instances of "ITmfConfiguration" can be instantiated and managed, e.g.
updated or removed.

This commit also contains relevant JUnit tests of the new classes.

[Added] org.eclipse.tracecompass.tmf.core.config extension point

Change-Id: Iff1935178515cafab015bbcad3ddc7a519e63f8c
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204455
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/ITmfConfigurationSourceType.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/exceptions/TmfConfigurationException.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/model/config/TmfConfigurationSourceManagerTest.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/TmfConfigurationSourceType.java
The file was modified tmf/org.eclipse.tracecompass.tmf.core.tests/META-INF/MANIFEST.MF (diff)
The file was addedtmf/org.eclipse.tracecompass.tmf.core/schema/org.eclipse.tracecompass.tmf.core.config.exsd
The file was modified tmf/org.eclipse.tracecompass.tmf.core/plugin.xml (diff)
The file was modified tmf/org.eclipse.tracecompass.tmf.core/META-INF/MANIFEST.MF (diff)
The file was addedtmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/model/config/TmfConfigurationSourceTypeTest.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/model/config/TmfConfigurationTest.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/TmfConfiguration.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/ITmfConfigParamDescriptor.java
The file was modified tmf/org.eclipse.tracecompass.tmf.core.tests/plugin.xml (diff)
The file was modified tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/Activator.java (diff)
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/package-info.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/model/config/TmfConfigParamDescriptorTest.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core.tests/stubs/org/eclipse/tracecompass/tmf/tests/stubs/model/config/TestConfigurationSource.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/TmfConfigParamDescriptor.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/ITmfConfiguration.java
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/ITmfConfigurationSource.java
The file was modified tmf/org.eclipse.tracecompass.tmf.core/plugin.properties (diff)
The file was addedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/config/TmfConfigurationSourceManager.java
Commit ac69ae270aed21cd8525902c4d59eb260e095652 by Matthew Khouzam
timing.core: Refactor statistics analysis to add generic segment type

This commit refactors the existing GenericSegmentStatisticsAnalysis and
SegmentStoreStatisticsDataProviderFactory so that they can be extended
to make new statistics analysis with different grouping logic:

[1] The GenericSegmentStatisticsAnalysis is now a public class, and
provides a default implementation for the getSegmentType method. By
default, this method groups the data of a statistics analysis by segment
name. The class can be extended to overwrite the default aggregating
logic.

[2] The SegmentStoreStatisticsDataProviderFactory is split into 2
classes: The AbstractSegmentStoreStatisticsDataProviderFactory and
SegmentNameSegmentStoreStatisticsDataProviderFactory. The
AbstractSegmentStoreStatisticsDataProviderFactory provides the common
logic to generate a data provider for segment store statistics analysis.
The SegmentNameSegmentStoreStatisticsDataProviderFactory extends the
prior class, and binds the data provider to the
GenericSegmentStatisticsAnalysis, which groups the data using the
segment name. New data provider factories can extends the abstract class
to use different grouping logic for statistics analysis by binding
itself to different implementations of GenericSegmentStatisticsAnalysis.

Change-Id: I895efe32384026ebfd8668bdb250e02900281c78
Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204373
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified analysis/org.eclipse.tracecompass.analysis.timing.core/plugin.xml (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/segmentstore/AbstractSegmentStoreStatisticsDataProviderFactory.java
The file was addedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/segmentstore/SegmentNameSegmentStoreStatisticsDataProviderFactory.java
The file was modified analysis/org.eclipse.tracecompass.analysis.timing.core/META-INF/MANIFEST.MF (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/analysis/timing/core/segmentstore/GenericSegmentStatisticsAnalysis.java
The file was removedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/segmentstore/SegmentStoreStatisticsDataProviderFactory.java
Commit bc785ee83d728311eb3c2c77649837996ad46ee8 by Bernd Hufmann
xml: Implement configuration extension for xml analysis

This patch uses the recently added extension point for configuration
source `org.eclipse.tracecompass.tmf.core.config.xmlsourcetype` for
XML analysis. The purpose of the extension point is to standardize
how configurations are managed in Trace Compass.

This commit includes JUnit tests for the XmlConfigurationSource class.

[Added] Implementation of a configuration extension for xml analysis

Change-Id: I9b035f25eaef9dd98250801040f4fa6bf1d60f4b
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204456
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
The file was addedtmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/config/XmlConfigurationSource.java
The file was modified tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/module/XmlUtils.java (diff)
The file was addedtmf/org.eclipse.tracecompass.tmf.analysis.xml.core.tests/src/org/eclipse/tracecompass/tmf/analysis/xml/core/tests/config/XmlConfigurationSourceTest.java
The file was modified tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/plugin.xml (diff)
The file was addedtmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/config/Messages.java
The file was addedtmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/config/package-info.java
The file was addedtmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/config/messages.properties
The file was modified tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/META-INF/MANIFEST.MF (diff)