Skip to content

Changes

Summary

  1. ctf: Support overlapping enum values (details)
  2. callstack.core: Add kernel thread statuses to tests (details)
Commit 47f44bd4d6c8ef8dd7d3cd65300058e51a9c69d7 by Patrick Tasse
ctf: Support overlapping enum values

Support overlapping of both single values and values ranges in the enum
declaration. The internal structure is changed from a TreeSet to a
Multimap. Overlapping can occur for the same key in the multimap
(overlapping single values) or for different keys in the multimap
(overlapping value ranges).

The query result label is the same when no overlap occurs, but when
there is overlap, the matching labels are returned as [l1, l2, ...].
This format can also be returned in the lookup table.

Add unit tests for overlapping and adding without specifying range.

[Added] ctf: Support overlapping enum values

Change-Id: I19fe159727b41fea324041ce0b20edcfd2cae36e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204295
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/EnumDeclarationTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/EnumDeclaration.java (diff)
Commit 5ea491c72293cd5b253f59214f6537c6b787fcfc by Matthew Khouzam
callstack.core: Add kernel thread statuses to tests

[Added] KernelAnalysisStub to add kernel thread statuses to tests
[Added] getStatusIntervalsForThreads to KernelThreadInformationProvider

To add these tests, a stub of the kernel analysis has been added and the
FlameChartDP has been modified to depend on the HostModel and not query
directly from the ThreadStatusDP.

To make the changes to the FlameChartDP, the CompositeHostModel has been
modified to query the thread statuses from multiple threads in one
query.

Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
Change-Id: I1ae1b729b0c29c267915e4cb2110d838547cae9f
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/202595
Reviewed-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was addedanalysis/org.eclipse.tracecompass.analysis.callstack.core.tests/stubs/org/eclipse/tracecompass/analysis/callstack/core/tests/stubs/KernelAnalysisModuleStub.java
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core/src/org/eclipse/tracecompass/internal/analysis/callstack/core/callgraph/CallGraphAnalysis.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowOneAll (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgTreeProcess (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowProcessAll (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgTreeOne (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.os.linux.core/META-INF/MANIFEST.MF (diff)
The file was addedanalysis/org.eclipse.tracecompass.analysis.callstack.core.tests/stubs/org/eclipse/tracecompass/analysis/callstack/core/tests/stubs/KernelStateProviderStub.java
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowSelectionZoom (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/src/org/eclipse/tracecompass/analysis/callstack/core/tests/CallStackTestBase.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowSelection2Times (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowFullZoom (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowProcessZoom (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core/src/org/eclipse/tracecompass/internal/analysis/callstack/core/model/ProcessStatusInterval.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core/src/org/eclipse/tracecompass/internal/analysis/callstack/core/model/IHostModel.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/plugin.xml (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowSelectionAll (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowProcess2Times (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowFull2Times (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgTreeSelection (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowOne2Times (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core/src/org/eclipse/tracecompass/internal/analysis/callstack/core/instrumented/FlameChartDataProvider.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core/src/org/eclipse/tracecompass/internal/analysis/callstack/core/model/CompositeHostModel.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowFullAll (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgTreeFull (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/src/org/eclipse/tracecompass/analysis/callstack/core/tests/FlameChartDataProviderTest.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/src/org/eclipse/tracecompass/analysis/callstack/core/tests/callgraph/FlameGraphDataProviderTest.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core.tests/testfiles/dp/expectedFgRowOneZoom (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core/src/org/eclipse/tracecompass/internal/analysis/callstack/core/flamegraph/FlameGraphDataProvider.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.core/src/org/eclipse/tracecompass/internal/analysis/callstack/core/base/FlameWithKernelPalette.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/kernel/KernelThreadInformationProvider.java (diff)