Skip to content

Changes

Summary

  1. ctf.core: Update integer and blob declarations to have a role field (details)
  2. ctf.core: Add support for CTF2 enumerations (details)
  3. ctf.core: Add CTF2 support for variants (details)
  4. ctf.core: Add support for fixed signed integer field class (details)
  5. Fix TraceCompass.setup problems (details)
  6. tmf: Bug 582385: Fix StackOverflowException in EventDensity view (details)
  7. analysis: Handle TmfSymbolProviderUpdatedSignal in Flame Chart views (details)
Commit 9b758df2254f94e900903571fe854059805e47f0 by Bernd Hufmann
ctf.core: Update integer and blob declarations to have a role field

The CTF2 role field was added in the declaration class and new
constructors were made for the type declarations that can have roles:
integers and blobs. Tests for blobs and methods using roles were
updated. A new method was also added to determine whether a trace is
CTF2. Since the IntegerDeclaration constructor was deprecated, all of
the tests & files that use it were also updated.

[added] roles for CTF events

Change-Id: I54bce6150539bbb2ff380cb12c4b39c7045e661e
Signed-off-by: Sehr Moosabhoy <sehr.moosabhoy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203774
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/event/CTFEventDefinitionTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/struct/StructDeclarationParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/EnumDeclarationTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/utils/JsonMetadataStrings.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/IntegerDeclarationTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/trace/CTFPacketReader.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/ArrayDeclaration2Test.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/BlobDeclaration.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StructDefinition.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/integer/IntegerDeclarationParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/IntegerDefinitionTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/IDeclaration.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/BlobDefinitionTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/SequenceDefinition2Test.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/types/composite/EventHeaderCompactDeclaration.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/EnumDefinitionTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/event/CTFEventFieldTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/IntegerDeclaration.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/trace/CTFTrace.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/BlobDeclarationTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/SequenceDeclaration2Test.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/ArrayDefinition2Test.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/Declaration.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/EventDeclaration.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/EventHeaderDeclarationTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/types/composite/EventHeaderLargeDeclaration.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/trace/TraceDeclarationParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/trace/CTFStreamInput.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/trace/StreamInputPacketIndexEntry.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/BlobDeclarationParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/IntegerEndiannessTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/trace/CTFStreamInputPacketIndexEntryTest.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/VariantDefinitionTest.java (diff)
Commit 06cecc51a78fa517c76d3bdeea1747a9f0e85fee by Bernd Hufmann
ctf.core: Add support for CTF2 enumerations

Add CTF2 parsing of fixed length signed enumerations. This patch does
not yet completely cover variable length enumerations. Testing of this
patch is delayed for now until the following variant patch is approved.
JUnit tests for this patch should be added with CTF2 updated tests in
the variantDefinition, variantDeclaration, and EventHeaderDeclaration
files.

Change-Id: I422c2669931c67f5b293abafb16f10a3635d158d
Signed-off-by: Sehr Moosabhoy <sehr.moosabhoy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203783
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/enumeration/EnumeratorParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/enumeration/EnumBodyParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/enumeration/EnumParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/utils/JsonMetadataStrings.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/TypeAliasParser.java (diff)
Commit e626ea4c0849bef27f7cf3b16d2feddb62e00142 by Bernd Hufmann
ctf.core: Add CTF2 support for variants

Added support for CTF2 variant field classes. This also slightly changed
the structure field metadata nodes. A change was also made to the user
attributes field in CTFJsonMetadataNode. This patch can be tested using
a CTF2-7.0 compliant version of [1] and these traces will also be added
to the test-traces repo soon.

[1]https://review.lttng.org/plugins/gitiles/babeltrace/+/refs/heads/ctf2/tests/data/ctf-traces/2/succeed/trace-with-index/

Change-Id: I603abc533f0281e071b4bb9ff0ca5538d4da1283
Signed-off-by: Sehr Moosabhoy <sehr.moosabhoy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203784
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/variant/VariantDeclarationParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/JsonStructureFieldMemberMetadataNode.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/utils/JsonMetadataStrings.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/TypeAliasParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/CTFJsonMetadataNode.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/variant/VariantParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/variant/VariantBodyParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/JsonStructureFieldMetadataNode.java (diff)
Commit 4aee67781a619ed14c17c5bf192a9636aaaebc82 by Bernd Hufmann
ctf.core: Add support for fixed signed integer field class

Added the fixed signed integer field class. Null checks have also been
added for clock offsets and preamble UUIDs in this patch.

Change-Id: Ie2a44323bff42edc9619e18d696884e573f8b9f1
Signed-off-by: Sehr Moosabhoy <sehr.moosabhoy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/203785
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/ClockParser.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/JsonPreambleMetadataNode.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/utils/JsonMetadataStrings.java (diff)
The file was modified ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/TypeAliasParser.java (diff)
Commit 00e9cb5a349d4610b86bf1e101cca0fc78823375 by Bernd Hufmann
Fix TraceCompass.setup problems

Do not install org.eclipse.pde.api.tools.ee.feature.feature.group
because it is no longer available in the Platform and it makes the p2
director task fail.

Redirect the setup location using https because that's what's used in
Oomph's project catalog so if that's not specified, one can't edit the
local version in the clone and test it locally.

Change-Id: I4829e82e8cc58437338e2c46757a2c763a99a973
Signed-off-by: Ed Merks <ed.merks@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204053
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified TraceCompass.setup (diff)
Commit bd999daf9fbab7ad55708bf6644f2bcbfed0d86a by Bernd Hufmann
tmf: Bug 582385: Fix StackOverflowException in EventDensity view

The this patch fixes a StackOverflowException in the
HistogramDataProviderFactory when a TmfTrace extension filters out the
framework, default TmfStatisticsModule. The factory now returns null
instead of falsely calling the TmfTreeXYCompositeDataProvider which
ends-up in an endless recursion.

Even though it's a default analysis module, extensions can choose to
remove it and the framework view should not cause such an exception.

[Fixed] Bug 582385: Fix StackOverflowException in EventDensity view

Change-Id: Id904867f7559bcd6cc93588fffabe47c7a5a1c77
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204200
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/histogram/HistogramDataProviderFactory.java (diff)
Commit e46ce3cf9fdceb77806530d75cad8fe5ce4bef33 by Bernd Hufmann
analysis: Handle TmfSymbolProviderUpdatedSignal in Flame Chart views

This will update both the FlameChartView in profiling and the new
incubating callstack package when the signal
TmfSymbolProviderUpdatedSignal is broadcasted which is done when the
dialog box SymbolProviderConfigDialog is closed upon being pressed OK.

[Fixed] Handle TmfSymbolProviderUpdatedSignal in Flame Chart views

Change-Id: I3615412dc831026166d72697b0eb97fdc62718df
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/204058
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
The file was modified analysis/org.eclipse.tracecompass.analysis.callstack.ui/src/org/eclipse/tracecompass/internal/analysis/callstack/ui/FlameChartView.java (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.profiling.ui/META-INF/MANIFEST.MF (diff)
The file was modified analysis/org.eclipse.tracecompass.analysis.profiling.ui/src/org/eclipse/tracecompass/analysis/profiling/ui/views/flamechart/FlameChartView.java (diff)