Skip to content

Changes

Summary

  1. releng: Add o.e.tc.slf4j.binding.simple.properties to testing feature (details)
  2. tmf.ui: safely expand zip files (details)
  3. tmf.ui calculate entry size for zip leveled structures (details)
  4. lttng2.ust.core: reduce backtracking and clean up regex (details)
Commit bb6fe402fafcd08108dbbd31ce655d66ee9a1b8d by Patrick Tasse
releng: Add o.e.tc.slf4j.binding.simple.properties to testing feature

Change-Id: I49d53861cd369618aa942cb916b12bffe45b6a0a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/202339
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified releng/org.eclipse.tracecompass.slf4j.binding.simple.properties/build.properties (diff)
The file was modified releng/org.eclipse.tracecompass.testing/feature.xml (diff)
Commit b58d7929e93a08740292b766d891ef8a3ddd021e by Matthew Khouzam
tmf.ui: safely expand zip files

Dealing with security hotspot for zipbombs,
Make sure that expanding this archive file
is safe here.

Edited to deal with files that aren't zip or tar files (e.g .gz)

Change-Id: I256e8fdb47b6b6bccbcf8793bd0e29fc8fd4cd5a
Signed-off-by: Sehr Moosabhoy <sehr.moosabhoy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201943
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ArchiveUtil.java (diff)
The file was modified tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java (diff)
Commit 42796340790a250de0893da5bb638a91f4cb5bfe by Matthew Khouzam
tmf.ui calculate entry size for zip leveled structures

Dealing with security hotspot for zipbombs,
Make sure that expanding this archive file
is safe here.

Change-Id: Id6da65747e223b7cbdea31ace310c577a550a887
Signed-off-by: Sehr Moosabhoy <sehr.moosabhoy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/202135
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ZipLeveledStructureProvider.java (diff)
The file was modified tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ArchiveUtil.java (diff)
Commit 1e09a7c6875f12e41510b3462302b4fc7f59cb20 by Matthew Khouzam
lttng2.ust.core: reduce backtracking and clean up regex

Make sure the regex used here, which is vulnerable to polynomial runtime
due to backtracking, cannot lead to denial of service.

Change-Id: I1f89b65baba8f8bb6b66dc6d0dbdb062017ee995
Signed-off-by: Sehr Moosabhoy <sehr.moosabhoy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/202168
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/UstDebugInfoStateProvider.java (diff)