Skip to content

Changes

Summary

  1. tmf: Accept Integer key values as string in Regex Multimap parameters (details)
  2. pcap.core: No longer throw exceptions in constructors (details)
Commit 0ff790dd856918150c7752b1963670c48433cee8 by Matthew Khouzam
tmf: Accept Integer key values as string in Regex Multimap parameters

In extractRegexFilter check if provided key values are string
instead of integer.

For example in REGEX_MAP_FILTERS user could specify a key value pair
as {"1": ["string",...]} instead of {1: ["string",...]}.

[Changed] Accept Integer keys as string in Regex Multimap parameters

Signed-off-by: Hriday Panchasara <hriday.panchasara@ericsson.com>
Change-Id: I9d409860a4027344705fd2bbd58c0b73878a3fb6
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/197273
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/dataprovider/DataProviderParameterUtils.java (diff)
Commit bca0acc0ec49ba786db23a5f4e450697608b31c8 by Matthew Khouzam
pcap.core: No longer throw exceptions in constructors

Don't throw exceptions in try-with-resources. This leads to suppressed
exceptions - IllegalArgumentExceptions wrapping the checked exception.

This in turn leads to trace auto-detection on certain trace types,
namely GDB not working since they are after the unhandled exception.

Bug 812934

[Security] Have safe exits to avoid throwing exception in PCAP constructors
[Changed] Fix spurious trace autodetect for single files

Change-Id: I5ae902cfa500c7f94273a80d65ccf4746dcddfa3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201859
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
The file was modified pcap/org.eclipse.tracecompass.pcap.core.tests/src/org/eclipse/tracecompass/pcap/core/tests/file/PcapFileOpenFailTest.java (diff)
The file was modified pcap/org.eclipse.tracecompass.pcap.core/src/org/eclipse/tracecompass/internal/pcap/core/util/PcapHelper.java (diff)
The file was modified pcap/org.eclipse.tracecompass.pcap.core/src/org/eclipse/tracecompass/internal/pcap/core/stream/PacketStreamBuilder.java (diff)
The file was modified pcap/org.eclipse.tracecompass.pcap.core/src/org/eclipse/tracecompass/internal/pcap/core/trace/PcapOldFile.java (diff)
The file was modified pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/trace/PcapTrace.java (diff)
The file was modified pcap/org.eclipse.tracecompass.pcap.core/src/org/eclipse/tracecompass/internal/pcap/core/trace/PcapFile.java (diff)
The file was modified pcap/org.eclipse.tracecompass.pcap.core.tests/src/org/eclipse/tracecompass/pcap/core/tests/packet/BadPacketTest.java (diff)