Skip to content

Changes

Summary

  1. ros2: clean up serialization methods (details)
  2. ros2: extract HostProcessValue from HostProcessPointer (details)
  3. ros2: make HostInfo/HostProcess/HostProcessValue comparable (details)
  4. ros2: allow using different tracepoint provider name (details)
  5. ros2: add task-clock perf counter context field to event layout (details)
Commit caf0f1eb22e2cb61f5ac6ebadb48815febf5ee18 by Christophe Bedard
ros2: clean up serialization methods

Consistently define and use #serializeValue() instead of #serialize()
when serializing objects, since #serialize() also serializes the type
of the object, which we don't need when serializing attributes.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Change-Id: I7ac2515760dafbb71807c70e10274288bcac25bf
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/202310
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/messages/Ros2TakeInstance.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/messages/Ros2Instance.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/messages/Ros2PubInstance.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/objects/Ros2Object.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostProcessPointer.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/messages/Ros2MessageTransportInstance.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/objects/Ros2CallbackObject.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostProcess.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/objects/Ros2SubscriptionObject.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostThread.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/messages/Ros2CallbackPublicationInstance.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostInfo.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/objects/Ros2PubSubObject.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/META-INF/MANIFEST.MF (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/objects/Ros2TimerObject.java (diff)
Commit ed82369623458aeb1b5209f7163f1d32b5ef9a2b by Christophe Bedard
ros2: extract HostProcessValue from HostProcessPointer

Move the generic parts to a new HostProcessValue class. Add
pointer-specific methods to HostProcessPointer, such as #isNullptr().

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Change-Id: I18e5c092da9863c4d276f8295b423774f73ac619
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/202311
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostProcessPointer.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/objects/Ros2Object.java (diff)
The file was addedtracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostProcessValue.java
Commit 8a17e8b2ce709f6b0d30091e50e7f88e6a5bad48 by Christophe Bedard
ros2: make HostInfo/HostProcess/HostProcessValue comparable

And add tests.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Change-Id: I753d1b09cab64988a133a189604286e6810c4a78
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/202312
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostProcess.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostProcessValue.java (diff)
The file was addedtracetypes/org.eclipse.tracecompass.incubator.ros2.core.tests/src/org/eclipse/tracecompass/incubator/ros2/core/tests/model/HostProcessTest.java
The file was addedtracetypes/org.eclipse.tracecompass.incubator.ros2.core.tests/src/org/eclipse/tracecompass/incubator/ros2/core/tests/model/HostInfoTest.java
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/model/HostInfo.java (diff)
The file was addedtracetypes/org.eclipse.tracecompass.incubator.ros2.core.tests/src/org/eclipse/tracecompass/incubator/ros2/core/tests/model/HostProcessValueTest.java
Commit 301824e65b38a5d51ef620f789aabafc9d79d757 by Christophe Bedard
ros2: allow using different tracepoint provider name

This allows extending the event layout class for a set of tracepoints
that uses a different provider name.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Change-Id: Ia2fb381ec74774ad6e86ddc95db57b08fcae54be
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/202318
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/trace/layout/IRos2EventLayout.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/trace/layout/Ros2RollingEventLayout.java (diff)
Commit 0f2948c9e739e0e2ae907bc9d7378ac1927a3039 by Christophe Bedard
ros2: add task-clock perf counter context field to event layout

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Change-Id: I0d3676de5b814d51e267dcaeb89171d209ca54cc
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/202319
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/trace/layout/IRos2EventLayout.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.ros2.core/src/org/eclipse/tracecompass/incubator/internal/ros2/core/trace/layout/Ros2RollingEventLayout.java (diff)