Skip to content

Changes

Summary

  1. otf2: Add location group attribute support (details)
  2. scripting: Fix linter warning in TmfScriptAnalysis (details)
  3. scripting, Bug 580576: Fix TmfScriptAnalysis reads (details)
Commit 69bbe6f58f40a8252322086455a01a8b7febaade by Matthew Khouzam
otf2: Add location group attribute support

To support accelerator memory location, additional attributes need
to be parsed and added to the flows analysis.

Additionally the flows data provider has been simplified and now
supports different depths.

Change-Id: Ic32a9d77e78b9fe010eab2a42c441a9b230eeb86
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/197091
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/AbstractOtf2Analysis.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/trace/Location.java (diff)
The file was addedtracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/Otf2Type.java
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/flows/FlowsLocation.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/IOtf2GlobalDefinitions.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/IOtf2Constants.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/flows/Otf2FlowsStateProvider.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/trace/LocationGroup.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/AbstractOtf2StateProvider.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/flows/Otf2FlowsDataProvider.java (diff)
The file was addedtracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/trace/AttributeDefinition.java
The file was modified tracetypes/org.eclipse.tracecompass.incubator.otf2.core/src/org/eclipse/tracecompass/incubator/internal/otf2/core/analysis/IOtf2Fields.java (diff)
Commit e3f7755fbd4a4283c69a2a9c05d0acda591d55d0 by Marco Miller
scripting: Fix linter warning in TmfScriptAnalysis

Rather than introducing a potentially non-API compliant external
annotation, suppress this previous SonarLint warning this way, for the
executeAnalysis method.

Change-Id: I28a795e540cc99fbb0ae8df864e4ac2c9790bab2
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/197317
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core/src/org/eclipse/tracecompass/incubator/internal/scripting/core/analysis/TmfScriptAnalysis.java (diff)
Commit d15fd82d1e9202fcde93188113ac87f73d9b929d by Marco Miller
scripting, Bug 580576: Fix TmfScriptAnalysis reads

Extract the reading of analysis state systems from executeAnalysis, to
read them also when getting all state systems for viewing purposes. Fix
the initialisation of the State System Explorer view this way, upon
opening it while already having state systems to readily get from disk.

Before this change, an EASE scripted analysis had to be run by the user,
so that State System Explorer could show this resulting data. With this
change, upon already having such data on disk, then that view now shows
it properly, right after opening up.

This assumes the possibility of state system data on disk maybe changing
outside of current user's flows. Hence this change always (re)reads that
data upon getting all state systems again the first time.

Again, this change covers the case of properly initializing the SSE view
upon its first opening, solely. There is still no re-read if the data is
deemed as cached enough, in which case reopening the trace is required
to force reading again.

Change-Id: I8484a8825fbff47e16228c8938c911bdd292c01f
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/197318
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core/src/org/eclipse/tracecompass/incubator/internal/scripting/core/analysis/TmfScriptAnalysis.java (diff)