Skip to content

Changes

Summary

  1. server: Add swagger doc for serviced 400 responses (details)
  2. server: Add missing swagger doc for 404 responses (details)
  3. server: Add consistent swagger doc for service 405 (details)
  4. server: Add swagger doc for serviced 409 responses (details)
  5. server: Add swagger doc for serviced 500 responses (details)
Commit 066480a5c684f780bc5c76fb77fc2f53cc40d60b by Matthew Khouzam
server: Add swagger doc for serviced 400 responses

Use the most common 400 response description where more than just one
400 case may happen in a method. Fix the previously inadequate
description in DataProviderService's getLines method, as well as the
former 401 which is a 400 case really.

Replace the related, inlined static uses with reusable static imports,
consistently for similar constants.

Change-Id: I256cca451afe4d345c58d8e2bff50b1882160c19
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/191376
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/DataProviderService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/TraceManagerService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/ExperimentManagerService.java (diff)
Commit bb19943dea8d1b9d87d65eb199142595b145ef35 by Matthew Khouzam
server: Add missing swagger doc for 404 responses

As some of those were already provisioned. Add the missing 404 swagger
response descriptions, completing them all. The other services classes
have theirs consistently already.

Align previously inconsistent use of NO_SUCH_TRACE by replacing these
with PROVIDER_NOT_FOUND, consistently with every other similar 404
case in DataProviderService. Do so for the related swagger descriptions,
while adding entity(NO_SUCH_TRACE) wherever missing, consistently with
every similar case in DataProviderService.

Change-Id: I175eb95c20ed598e8c86ed24e90b73986219ce06
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/191417
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/DataProviderService.java (diff)
Commit 18f12d03a9f4094bf2caa573339c8797c018374b by Matthew Khouzam
server: Add consistent swagger doc for service 405

Add 405 swagger response descriptions to every service (here only
DataProviderService) method. Stick to the already provisioned
NO_PROVIDER short description for this current matter at hand.

Replace the sole use of the slightly differing ANALYSIS_NOT_POSSIBLE
short description with NO_PROVIDER's. Do so consistently with every
other 405 occurrence.

Change-Id: I9ce3d1a92e32662ba49f46129b3d13bcb1552572
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/191418
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/DataProviderService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/EndpointConstants.java (diff)
Commit 58f9e853607aa302c7ecae8f4f4b581a842de633 by Matthew Khouzam
server: Add swagger doc for serviced 409 responses

Add new descriptions for these, as none previously existed, since these
cases were not described that way before.

Change-Id: Ia003a153a28a1a705c4943093731a1bffe9d720b
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/191419
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/ExperimentManagerService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/TraceManagerService.java (diff)
Commit 8e00c1c04d786c80fbded5c8072791e09edf5577 by Matthew Khouzam
server: Add swagger doc for serviced 500 responses

Either create or reuse the most (known as) accurate descriptions for
these internal (trace) server errors.

Change-Id: Ie64a0773641577080f6b8e3ca362d424ad65aeb8
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/191420
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/TraceManagerService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/ExperimentManagerService.java (diff)
The file was modified trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/services/EndpointConstants.java (diff)