Skip to content
Success

Changes

Summary

  1. [343] Refactor - Extract trace debug in a specific class (details)
  2. [343] Add a property system to allow to choose the export folder (details)
  3. [343] Add a new action to export diagram as ELK Text format (details)
  4. [343] Extend ELK graph traces options (details)
  5. [343] Clean code for ELK export. (details)
  6. [343] Refresh workspace after export actions (details)
  7. [343] Add automatic tests corresponding to these enhancements (details)
  8. [343] Add corresponding documentation (details)
  9. [doc] Update URLs still pointing to the old website address (details)
  10. [411] Enable pin tabbar action on edges (details)
Commit 858fc913cd77e2cc42516cd015a34386278a794d by Laurent Redor
[343] Refactor - Extract trace debug in a specific class

This commit also makes some minor changes:
- Usage of ELK Options constant ID, instead of hard-coded values
- Display of the message dialog is now the responsibility of the caller

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was addedplugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/ElkDiagramLayoutTracer.java
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/src/org/eclipse/sirius/diagram/elk/debug/ExportToElkGraphHandler.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/Messages.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/META-INF/MANIFEST.MF (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/plugin.properties (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/DiagramElkPlugin.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/ElkDiagramLayoutConnector.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/plugin.properties (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/ELKLayoutNodeProvider.java (diff)
Commit cc1607143996fc7566600b051628495cc215a42b by Laurent Redor
[343] Add a property system to allow to choose the export folder

It is now possible to launch the Eclipse with the option
"-Dorg.eclipse.sirius.diagram.elk.targetFolderPath=myPath" to select the
folder where the diagrams are exported (through explicit action or
through the trace debug options).

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was modified plugins/org.eclipse.sirius.diagram.elk/plugin.properties (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/ElkDiagramLayoutTracer.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/Messages.java (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.html (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/META-INF/MANIFEST.MF (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.textile (diff)
Commit a28db561d75fef450e10683b878376e66a7d071f by Laurent Redor
[343] Add a new action to export diagram as ELK Text format

This commit provides a new action named "Export diagram as ELK Text", as
for "Export diagram as ELK Graph", but that exports the current diagram
in a file using the ELK Text format (format used, for example, in ELK
Demonstrators [1]).

[1] https://rtsys.informatik.uni-kiel.de/elklive/elkgraph.html

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/src/org/eclipse/sirius/diagram/elk/debug/ExportToElkGraphHandler.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/plugin.properties (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/plugin.xml (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/ElkDiagramLayoutTracer.java (diff)
Commit 42b9aa28c8ff92338542faae38c68a5a5e638cbd by Laurent Redor
[343] Extend ELK graph traces options

- Add the textual mode as an option for the debug traces. It is enabled
by default.
- Add the xmi mode as an option for the debug traces. It was the only
choice before (enabled by default as soon as debug is enabled).

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was modified plugins/org.eclipse.sirius.diagram.elk/.options (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/ElkDiagramLayoutTracer.java (diff)
Commit 9f4185889a3836b590a541ebd5f437e960dfd440 by Laurent Redor
[343] Clean code for ELK export.

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/src/org/eclipse/sirius/diagram/elk/debug/ExportToElkGraphHandler.java (diff)
Commit 9819f491ec2d79b7d62dc8f809e1f6e394fee57b by Laurent Redor
[343] Refresh workspace after export actions

If the exported file is in the workspace, this last is refreshed (with
the action launched in a WorkspaceModifyOperation to avoid collision
problem).
The workspace's refresh is not launched during the creation of the files
during the arrange all, to avoid potential side effects. In this case,
the refresh will still have to be done manually.

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/META-INF/MANIFEST.MF (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk/src/org/eclipse/sirius/diagram/elk/ElkDiagramLayoutTracer.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram.elk.debug/src/org/eclipse/sirius/diagram/elk/debug/ExportToElkGraphHandler.java (diff)
Commit 0de60303ecf7d73f1e5d4d09844305a2d2e30c3c by Laurent Redor
[343] Add automatic tests corresponding to these enhancements

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was modified plugins/org.eclipse.sirius.tests.swtbot/META-INF/MANIFEST.MF (diff)
The file was modified plugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/suite/AllTestSuite.java (diff)
The file was addedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/layout/ELKDebugFeaturesTest.java
Commit 838b947a7c45e7b5bce59dea3c46cc99aae90180 by Laurent Redor
[343] Add corresponding documentation

This documentation does not concern only the enhancements. Indeed, the
existing capabilities were not documented before.

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/343
The file was modified plugins/org.eclipse.sirius.doc/doc/specifier/diagrams/Diagrams.textile (diff)
The file was addedplugins/org.eclipse.sirius.doc/doc/specifier/diagrams/images/elkFilesGeneratedDuringArrangeWithELK.png
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.textile (diff)
The file was addedplugins/org.eclipse.sirius.doc/doc/specifier/diagrams/images/elkTracing.png
The file was modified plugins/org.eclipse.sirius.doc/doc/specifier/diagrams/Diagrams.html (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/toc.xml (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.html (diff)
The file was addedplugins/org.eclipse.sirius.doc/doc/specifier/diagrams/images/elkExportActionsContextualMenu.png
Commit 647d61d1385fff2cc4e84606c764d413f07554f3 by Pierre-Charles David
[doc] Update URLs still pointing to the old website address

Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modified CONTRIBUTING (diff)
The file was modified README.md (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.html (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/index.html (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes_Previous.html (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes_Previous.textile (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.textile (diff)
Commit 33b42e3fe183b833af4bd05fe6514d18f6711454 by Laurent Redor
[411] Enable pin tabbar action on edges

This commit:
- enables the "Pin status" button on edges,
- automatically marks "moved" edge as pinned (if corresponding
preference is true),
- updates the documentation,
- adds additional tests in existing tests classes concerning pinned
edges.

Bug: https://github.com/eclipse-sirius/sirius-desktop/issues/411
The file was modified plugins/org.eclipse.sirius.tests.junit/data/unit/layout/pinning/description/pinUnpinNote.odesign (diff)
The file was modified plugins/org.eclipse.sirius.tests.junit/src/org/eclipse/sirius/tests/unit/diagram/layout/pinning/PinnedElementsTest.java (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/user/diagrams/Diagrams.html (diff)
The file was modified plugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/PinnedElementsTest.java (diff)
The file was modified plugins/org.eclipse.sirius.diagram/src/org/eclipse/sirius/diagram/tools/api/layout/PinHelper.java (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.textile (diff)
The file was modified plugins/org.eclipse.sirius.tests.junit/data/unit/layout/pinning/description/tc1825.odesign (diff)
The file was modified plugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/PinnedNotesTest.java (diff)
The file was modified plugins/org.eclipse.sirius.tests.junit/data/unit/layout/pinning/model/tc1924.aird (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/Release_Notes.html (diff)
The file was modified plugins/org.eclipse.sirius.tests.junit/data/unit/layout/pinning/model/pinUnpinNote.aird (diff)
The file was modified plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/edit/internal/part/CommonEditPartOperation.java (diff)
The file was modified plugins/org.eclipse.sirius.tests.junit/data/unit/layout/pinning/model/pinUnpinNote.ecore (diff)
The file was modified plugins/org.eclipse.sirius.tests.junit/data/unit/layout/pinning/model/tc1825.ecore (diff)
The file was modified plugins/org.eclipse.sirius.tests.junit/data/unit/layout/pinning/model/tc1825.aird (diff)
The file was modified plugins/org.eclipse.sirius.doc/doc/user/diagrams/Diagrams.textile (diff)
The file was modified plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/internal/actions/pinning/PinElementsAction.java (diff)