Changes

Prepare release jakarta.servlet:jakarta.servlet-api:5.0.0

Prepare next development cycle for 5.0.1-SNAPSHOT

Fixes #368 Updates javadoc for getRemoteAddr

Fixes #368 with javadoc updates for:
 + reference to RFC 7239  for obtaining local/remote IP and ports
 + removed historic references to CGI variables
 + relaxed the dependence on the host header, which may not be present in HTTP/2

fixed format

Signed-off-by: gregw <gregw@webtide.com>

Begin work on Servlet 5.1

Signed-off-by: Stuart Douglas <sdouglas@redhat.com>

Some more spec document cleanup

Fixes #363

Signed-off-by: Stuart Douglas <sdouglas@redhat.com>

Remove the X-Powered-By header

Fixes #272

Signed-off-by: Stuart Douglas <sdouglas@redhat.com>

Avoid NPE when passing null to Cookie#setDomain

Signed-off-by: Thiago Henrique Hüpner <thihup@gmail.com>

misspelling
Signed-off-by: Jerry Zhang <582315171@qq.com>

Fix typo

Signed-off-by: Thiago Henrique Hüpner <thihup@gmail.com>

Fix #105 - clarify requirements for path in getRealPath(String path)

Signed-off-by: Mark Thomas <markt@apache.org>

Fix #377 - clarify setCharacterEncoding(null) and related

Signed-off-by: Mark Thomas <markt@apache.org>

Fix #365 - correct fragment order in example 2

Signed-off-by: Mark Thomas <markt@apache.org>

Update maven-bundle-plugin to latest to fix CI failure with newer JREs

The previous version of the plug-in triggers a
ConcurrentModificationException on newer JREs. The likely root cause is
https://hg.openjdk.java.net/jdk/jdk/rev/65b345254ca3
The newer maven-bundle-plugin has been updated to avoid the issue.

Signed-off-by: Mark Thomas <markt@apache.org>

Check system prop in doPrivileged block

Fixes #389

Signed-off-by: Stuart Douglas <sdouglas@redhat.com>

Fix copy/paste error

Signed-off-by: Mark Thomas <markt@apache.org>

Fix Javadoc for getMajorVersion and getMinorVersion

The version info in the Javadoc wasn't updated for 5.0
Remove the version specific references from the Javadoc

Signed-off-by: Mark Thomas <markt@apache.org>

Servlet api issue 175 add cookie set attribute v3 (#401)

* Add Cookie#setAttribute
https://github.com/eclipse-ee4j/servlet-api/issues/175
https://github.com/eclipse-ee4j/servlet-api/pull/271

* Skip null value from check for reserved token

* Alternative approach to cookie attribute handling
github.com/eclipse-ee4j/servlet-api/pull/399#discussion_r624276777

* Make sure path is referenced via constant

* In hindsight, token check doesn't need to be performed on value

* Match casing with spec; mapping is case insensitive anyway

* Optimized Cookie to lazily create attribute map

* Added junit test

* Updates from review

* Fixed quote

* surefire plugin

* Updates from review

* Updates from review

Co-authored-by: Bauke Scholtz <balusc@gmail.com>

Fix Javadoc warnings

Fix comment typo

Next version is now planned to be 6.0 rather than 5.1

Fix #407 add identifiers for debug logging (#417)

* Fix #407 add identifiers for debug logging

* Implement review comments from gregw

Remove deprecated code (#419)

Fix invalid javadoc

Add support for an additional property: getErrorOnELNotFound()

This is in support of:
https://github.com/eclipse-ee4j/jsp-api/issues/40

Clarifly the JSR-133 sematics of the init methods

Fixes #81

Signed-off-by: Stuart Douglas <sdouglas@redhat.com>

Issue 225 do head content length (#405)

Issue #225 doHead contentLength

 + converting the contentLength field to a long
 + checking against bufferSize before setting a content length to simulate a buffer overflow
 + support flush and close
 + pass through async IO listener

* Issue #225 doHead contentLength

 + check content-length against buffer size on every write

* Improved clarity of the writer flush mechanism

* Added unit test

* Alternate approach
 + fixed some definite bugs in Nobody response
 + made the use of Nobody response optional.

* + use SC init parameter to enable legacy doHead handling

* Deprecated legacy mode and added text in spec

* format

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* format

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* merged and updated for deprecated and new methods.

Fix #411 No Object Wrapper Identity requirement for dispatch (#413)

Fix #411 No Object Wrapper Identity requirement for dispatch

Add generic attribute support to SessionCookieConfig

Also adds an entry to the change log.
The schema also requires an update. A separate PR will be provided
shortly to the schema project for that change.

Fix #111 - clarify Javadoc

Issue #18 URI path processing (#424)

Issue #18 URI path processing

Co-authored-by: Mark Thomas <markt@apache.org>

Update to jdk11

update CI to jdk11

Signed-off-by: Greg Wilkins <gregw@webtide.com>

Update to jdk11

Make pom better suitable for JDK11+ build

* Update versions
* Prevent normal progress to be printed as warning in javadoc


Signed-off-by: arjantijms <arjan.tijms@gmail.com>

fixed bad chars in asciidoc (#429)

Update copyright checks to include new files that are (c) contributors

Update copyroght dates for files modified in 2021

Add/correct copyright for new files added in 2021

Fixes generation of javadoc using JDK 11 (#437)

* Fixes generation of javadoc using JDK 11
* Change javadoc source level to 11 

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

Remove unnecessary cast and silence an IDE warning

Fix unused field warning

Fix IDE warnings re missing serialVersionUID

Fix non-ASCII character corruption in c04d563

Update maven spec dependencies, specifically of asciidoc

Some required config changes due to breaking changes in v2.

See https://docs.asciidoctor.org/maven-tools/latest/plugin/v2-migration-guide/

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

Remove restriction on ServletContext getters (#441)

Remove the restriction on programatically added listeners calling getter
methods on the ServletContext.

Fixes #416

Signed-off-by: Stuart Douglas <sdouglas@redhat.com>

Add additional entries to changelog

Add a module-info.java (#442)

* Add a module-info.java

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

* Processing feedback:

* Make CookieTest public, remove existing opens statements
* Add open statement for the resources package
* Add entry in spec changelog

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

Ignore directory created by Eclipse IDE

Add missing @since annotation

Replace references to RFC 2616 with 7230-7235 as appropriate

Javadoc clean-up. Mainly missing @since tags

Update copyright

Add forRemoval and since information to deprecation annotations

Ensure all @since Javadoc tags include 'Servlet'

Align Javadoc for isStarted() with specification document

Fix #37 - update Cookie class for RFC 6265

In summary:
- setVersion() is NO-OP, getVersion() is hard-coded to 0
- Restrictions on cookie name relaxed to 'must be non-null, non-empty
token'

Also deprecate comment as it too is an RFC 2109 defined attribute

Deprecate comment in SessionCookieConfig

Update spec language to align with RFC 6265 (cookies)

Also add a change log entry

Spec needs 2 digit version

Be consistent. Link to the issue rather than the PR.

Align isReady in ServletOutputStream with ServletInputStream

The current wording is causing confusion:
https://bz.apache.org/bugzilla/show_bug.cgi?id=65780

Update javadoc for isReady

Make clear the scheduling implications of a false return from isReady()

Fix copyright date

Update schemas to latest (hopefully final) Jakarta EE 10 versions

Most recent Javadoc update was in 2022 so update copyright date

List issues in numerical order

Add missing entry to changelog

Clarify that sizes are all in bytes

Fix typos

Fix #164. Clarify method behaviour is a NO-OP if called after commit.

Keep change log in sync

Formatting

Fix #325 - Clarify get[Int|Date]Header() behaviour for multiple headers

This explicitly aligns the behaviour of these headers with the behaviour
of getHeader().

Fix Javadoc issue highlighted by #473

Align Javadoc with current behaviour.

The default current behaviour is consistent with an implementation that
does not implement trailer fields. isTrailerFieldsReady() returns true
and a subsequent call to getTrailerFields() returns an empty Map.

Fix #59 - Add 'query_string' attribute to error dispatches

Update version to 6.1

Update change log

Fix #95 - clarify the HTTPS support is required

Fix #275 - containers can use relative URLS for redirects

Fix issue-484 Add read/write via ByteBuffer

Clarify the behaviour of isReady().
Clarify the behaviour of read/write methods.
Clarify the behaviour of close().

Replicate warning for all methods that require a path

Add canonicalization clarification to methods that accept paths

Update Servlet specification references to use the agreed style

Correct version references

Remove legacy CVS placeholder

Fix #415 - add overloaded setCharacterEncoding() supporting Charset

Fix #443 Remove references to the SecurityManager and associated APIs

Fix #316 - clarify behaviour of getMatchValue()

Add more examples, remove unnecessary text and be explicit about removal
of leading '/'.

Fix primary issue in #300 context path is always the context path

The context path does not change to "" just because the current request
matches a context root mapping.

Fix secondary issue in #300 - context root mapping with or without /

Fix #273 - clarify behaviour around non-blocking writes

Further clarifications

Make API build reproducible

Signed-off-by: Hervé Boutemy <hboutemy@apache.org>

Fix #159 - Clarify behaviour of header methods with null or ""

Fix for #468 - update HTTP RFC references

No other changes required to the specification

Fix #336 - expand list of supported HTTP status codes

Adds 308, 421, 422, 426

Clarify expected behaviour for CONNECT

Fix copyright year. Missed in #500.

Trivial change to fix copyright check error.

The copyright check looks at last authored date. The merge of #499
retained the original author date of 2020 for the change to this file.
The date of 2023 in the file is inconsistent with that so the copyright
check fails. The sole purpose of this commit is to changed the authored
date of the most recent change to a date in 2023.

Fix Javadoc errors

Fix asciidoctor build warnings

This are not intended to be hyperlinks

Update the build

There is NO code or any other source change then
Maven POMs.

Changes:
* update plugins
* centralize plugin versions in parent (for spec)
* make build work with Maven 3.9.0

Update to formatter plugin resulted in changes

Mostly removal of trailing space characters.
A fix fixes to indentation in a couple of HTML filea.

Copyright updates for formatting changes

[Issue 133] Add HTTP PATCH

https://github.com/jakartaee/servlet/issues/113

Follow-up to #507

Fix formatting for updated format plugin.
Add change log entry.

Update copyright date after PATCH support changes (#507)

Fix #460 - rephrase description of uncovered methods

Fix #74 - provide more control over redirects

Add missing @since tags

Fix #469 - Remove sensitive header on TRACE method

Fix #517 - Mention what are the expected values of the jakarta.servlet.*.mapping attributes at the text of session 9 (Dispatching Requests)

Signed-off-by: Flavia Rainone <frainone@redhat.com>

Add support for headers that occur more than once

Minor improvements. Add @since. Improve wording.

Correct typo - see #522

Consistent formatting

Ensure clean layout with one listener per line in the table

Fix IDE (Eclipse) warnings in tests

Fix Javadoc warnings

Update reserved attribute names

Remove reference to Managed Bean Specification

Update references to the Jakarta Platform specification

Fix #536 - correct minimum Java and Maven versions

Fix #431 - getParameter() may throw runtime exception

Applies to all of the parameter methods
Containers may provide options for alternative error handling

Fix #538 - Make HTTP/2 push support optional

servlet tck code from git hash 365d07321c922fcfb634803232a5c5b28fb9686a

Signed-off-by: Olivier Lamy <olamy@apache.org>