Skip to content

Changes

Summary

  1. Bug 581961 - [Robotics] Selection dialogs: empty history, possibility of an NPE (details)
  2. Bug 581963 - [Robotics] Data type use in templates (details)
  3. Bug 582095 - [Robotics] Several small issues (details)
  4. Bug 582127 - [Robotics] NPE during "Ok" in coordination service selection dialog (details)
Commit e674143abb9e0ca8438c84edbc1484322c307a1e by Ansgar Radermacher
Bug 581961 - [Robotics] Selection dialogs: empty history, possibility of an NPE

- Revert change in RoboticsContentProvider introduced in bug 581690. It added an empty
  implementation of the commit method which caused the non-addition to the history.
- Avoid NPE via additional check of dialog return result

Change-Id: I6c7be9ee42a5f05ac8df2ce9e67be1c9f3d4a84b
Signed-off-by: aradermache <ansgar.radermacher@cea.fr>
The file was modified plugins/customization/org.eclipse.papyrus.robotics.core/src/org/eclipse/papyrus/robotics/core/provider/RoboticsContentProvider.java
The file was modified plugins/customization/org.eclipse.papyrus.robotics.core/src/org/eclipse/papyrus/robotics/core/menu/EnhancedPopupMenu.java
Commit 48f2f2c84da944d4cb17fa7106ed2e2e87ed7d5e by Ansgar Radermacher
Bug 581963 - [Robotics] Data type use in templates

- Replace ROS2 primitive types with AnsiC types in the component-definition model template
  This is a workaround for a better solution in the future that
  might add language specific imports

Change-Id: I57988f4457d22e3862bc66d761b5756a550c97a6
Signed-off-by: aradermache <ansgar.radermacher@cea.fr>
The file was modified plugins/customization/org.eclipse.papyrus.robotics.wizards/templates/robotics.compdef.uml
The file was modified plugins/customization/org.eclipse.papyrus.robotics.wizards/templates/robotics.compdef.notation
Commit 59ae5362f517069dad3a6ac865fc60dedf97e9e1 by Ansgar Radermacher
Bug 582095 - [Robotics] Several small issues

1. Python: if no chrono literal postfix is found, pass unmodified value
   (modified python ComponentTransformations)

2. Port handlers: use varName function to escape some potentially problematic names in new function that is created when connecting an activity port
  (modified CreateFunctionsCommand)

3. Take all communication objects into account (modified InteractionUtils)

4. In an action, loop over feedback attributes instead of twice over response (modified CreateMessage)

5. Add escapeUnderscore function to RosHelpers and use it for filename calculations
   For consistency: Move CamlCase function into RosHelpers, since rather specific for ROS)

Change-Id: I3eeaf7c8507f4b971662bcd46eb586ec2cad82fb
Signed-off-by: aradermache <ansgar.radermacher@cea.fr>
The file was modified plugins/ros2/org.eclipse.papyrus.robotics.ros2.codegen.common/src/org/eclipse/papyrus/robotics/ros2/codegen/common/utils/SkillUtils.xtend
The file was modified plugins/ros2/org.eclipse.papyrus.robotics.ros2.codegen.python/src/org/eclipse/papyrus/robotics/ros2/codegen/python/component/ComponentTransformations.xtend
The file was modified plugins/customization/org.eclipse.papyrus.robotics.core/src/org/eclipse/papyrus/robotics/core/utils/InteractionUtils.java
The file was modified plugins/codegen/org.eclipse.papyrus.robotics.codegen.common/src/org/eclipse/papyrus/robotics/codegen/common/utils/Helpers.java
The file was modified plugins/ros2/org.eclipse.papyrus.robotics.ros2.codegen.common/src/org/eclipse/papyrus/robotics/ros2/codegen/common/utils/MessageUtils.xtend
The file was modified plugins/ros2/org.eclipse.papyrus.robotics.ros2.codegen.common/src/org/eclipse/papyrus/robotics/ros2/codegen/common/utils/RosHelpers.java
The file was modified plugins/customization/org.eclipse.papyrus.robotics.core/src/org/eclipse/papyrus/robotics/core/commands/CreateFunctionsCommand.java
The file was modified plugins/ros2/org.eclipse.papyrus.robotics.ros2.codegen.common/src/org/eclipse/papyrus/robotics/ros2/codegen/common/message/CreateMessage.xtend
The file was modified plugins/ros2/org.eclipse.papyrus.robotics.ros2.codegen.common/src/org/eclipse/papyrus/robotics/ros2/codegen/common/message/CreateMsgPackage.xtend
Commit 6bc7b45f044f38665e6f4eda97ed92e3f2d15106 by Ansgar Radermacher
Bug 582127 - [Robotics] NPE during "Ok" in coordination service selection dialog

- Replace creation of new content provider with existing one.
  Please check, if sufficiently specific
- [white space changes in class FilterStereotypes]

Change-Id: I055dd45dee2b6b9702d9cbd4987d4e89f9f68f44
Signed-off-by: aradermache <ansgar.radermacher@cea.fr>
The file was modified plugins/customization/org.eclipse.papyrus.robotics.properties/src/org/eclipse/papyrus/robotics/properties/widgets/CoordinationServiceReferenceEditor.java
The file was modified plugins/customization/org.eclipse.papyrus.robotics.core/src/org/eclipse/papyrus/robotics/core/provider/FilterStereotypes.java