Skip to content
Success

Changes

Summary

  1. Remove hardcoded string constant representing "UTF-8" where possible (details)
  2. Review/cleanup Facelets/Request/Response encoding implementation (details)
  3. Further clarified comments after self-review. (details)
  4. UIInput#getSubmittedValue() must also consider isLocalValueSet() when (details)
  5. Further cleanup of comments (details)
  6. Fixed wrong base url to validate contracts resource; it should be (details)
  7. Add session mutex (details)
  8. Fallback in case there's no mutex attribute for whatever reason (details)
  9. Consider ClosedChannelException as well when checking for connection (details)
  10. Mmkay instanceof var was only available since Java 14 (details)
  11. PartialViewContextImpl should use same VisitContext to reset values as (details)
  12. Add clarifying comment wrt copy of resetValues() (details)
  13. resetValues should not carry EXECUTE_LIFECYCLE visit hint (details)
  14. Revert "UIInput#getSubmittedValue() must also consider isLocalValueSet() when INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL=true https://github.com/eclipse-ee4j/mojarra/issues/5386" (details)
  15. Found and fixed two more occurrences on synchronized(session) (details)
  16. Improved impl for https://github.com/eclipse-ee4j/mojarra/issues/5375 (details)
  17. First step, migrate junit4 to junit5 (details)
  18. Analyzed and fixed failing UIComponentBaseBehaviorTestCase; it was (details)
  19. migrated EasyMock/PoweMock to Mockito (details)
  20. Micro optimization to clarify intent of code (details)
  21. Reduce logging level of exception which is already rethrown during (details)
Commit aedf85725413c0e58c893b3ae187092898f11910 by Bauke Scholtz
Remove hardcoded string constant representing "UTF-8" where possible
The file was modified impl/src/main/java/com/sun/faces/lifecycle/RestoreViewPhase.java (diff)
The file was modified impl/src/main/java/com/sun/faces/renderkit/html_basic/OutputLinkRenderer.java (diff)
The file was modified impl/src/main/java/com/sun/faces/facelets/util/Classpath.java (diff)
The file was modified impl/src/main/java/com/sun/faces/context/PartialViewContextImpl.java (diff)
The file was modified impl/src/main/java/jakarta/faces/context/PartialResponseWriter.java (diff)
The file was modified impl/src/main/java/com/sun/faces/RIConstants.java (diff)
The file was modified impl/src/main/java/com/sun/faces/application/ConverterPropertyEditorFactory.java (diff)
The file was modified impl/src/main/java/com/sun/faces/context/flash/ELFlash.java (diff)
The file was modified impl/src/main/java/com/sun/faces/context/ExternalContextImpl.java (diff)
The file was modified impl/src/main/java/com/sun/faces/renderkit/StateHelper.java (diff)
Commit 84f890583e94b9b6780417313fb134b7ada13854 by Bauke Scholtz
Review/cleanup Facelets/Request/Response encoding implementation
https://github.com/eclipse-ee4j/mojarra/issues/5383
The file was modified impl/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java (diff)
The file was modified impl/src/main/java/com/sun/faces/application/view/MultiViewHandler.java (diff)
The file was modified impl/src/main/java/com/sun/faces/util/Util.java (diff)
The file was modified impl/src/main/java/com/sun/faces/context/UrlBuilder.java (diff)
The file was modified impl/src/main/java/jakarta/faces/application/ViewHandler.java (diff)
Commit e0758c01e08eb6eeea2ad3ec460e48f04b9a5120 by Bauke Scholtz
Further clarified comments after self-review.
The file was modified impl/src/main/java/com/sun/faces/application/view/FaceletViewHandlingStrategy.java (diff)
The file was modified impl/src/main/java/com/sun/faces/util/Util.java (diff)
Commit 081e6ea797eacb6793bfe4e813e7e7dbda96d565 by Bauke Scholtz
UIInput#getSubmittedValue() must also consider isLocalValueSet() when
INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL=true
https://github.com/eclipse-ee4j/mojarra/issues/5386
The file was modified impl/src/main/java/jakarta/faces/component/UIInput.java (diff)
Commit 263095b2d23e39de4709772af441a1bfde35855d by Bauke Scholtz
Further cleanup of comments
The file was modified impl/src/main/java/com/sun/faces/util/Util.java (diff)
Commit 73ee61a6937ed5d4d59942054ce5877ec55eafb5 by Bauke Scholtz
Fixed wrong base url to validate contracts resource; it should be
validated against the path of the facelet itself not against the
resolved url of the facelet
https://github.com/eclipse-ee4j/mojarra/issues/5389
The file was modified impl/src/main/java/com/sun/faces/facelets/impl/DefaultFacelet.java (diff)
Commit 5a23e8a47de102ccd4a11a69ce0b46e1bd1a25f3 by Bauke Scholtz
Add session mutex
https://github.com/eclipse-ee4j/mojarra/issues/5380
The file was modified impl/src/main/java/com/sun/faces/cdi/clientwindow/ClientWindowScopeContextManager.java (diff)
The file was modified impl/src/main/java/com/sun/faces/context/SessionMap.java (diff)
The file was modified impl/src/main/java/com/sun/faces/application/view/ViewScopeContextManager.java (diff)
The file was modified impl/src/main/java/com/sun/faces/config/ConfigureListener.java (diff)
The file was modified impl/src/main/java/com/sun/faces/renderkit/ServerSideStateHelper.java (diff)
Commit c5747dd198ff80a8c17167b20657850530f7eb9f by Bauke Scholtz
Fallback in case there's no mutex attribute for whatever reason
The file was modified impl/src/main/java/com/sun/faces/context/SessionMap.java (diff)
Commit 3f23782b589eadc69cead458d0e60675353c7629 by Bauke Scholtz
Consider ClosedChannelException as well when checking for connection
abort
https://github.com/eclipse-ee4j/mojarra/issues/5391
The file was modified impl/src/main/java/com/sun/faces/application/resource/ResourceHandlerImpl.java (diff)
Commit 86d086483c152f804e2de762858fcc29d342ae40 by Bauke Scholtz
Mmkay instanceof var was only available since Java 14
The file was modified impl/src/main/java/com/sun/faces/context/SessionMap.java (diff)
Commit 190cce997b361f787ec277081080d7022a5fa262 by Bauke Scholtz
PartialViewContextImpl should use same VisitContext to reset values as
the one used to process the execute and render
https://github.com/eclipse-ee4j/mojarra/issues/5396
The file was modified impl/src/main/java/com/sun/faces/context/PartialViewContextImpl.java (diff)
Commit 2b30a2ca7f12f583f139618abefacf86c77d163d by Bauke Scholtz
Add clarifying comment wrt copy of resetValues()
The file was modified impl/src/main/java/com/sun/faces/context/PartialViewContextImpl.java (diff)
Commit 82f8a9c9a6598ad4d2a07eca7c5ebc63ef5bff62 by Bauke Scholtz
resetValues should not carry EXECUTE_LIFECYCLE visit hint
https://github.com/eclipse-ee4j/mojarra/issues/5396
The file was modified impl/src/main/java/com/sun/faces/context/PartialViewContextImpl.java (diff)
Commit 99c4944068ac05995be97f4071c8cc4371e4380f by Bauke Scholtz
Revert "UIInput#getSubmittedValue() must also consider isLocalValueSet() when INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL=true https://github.com/eclipse-ee4j/mojarra/issues/5386"

This reverts commit 081e6ea797eacb6793bfe4e813e7e7dbda96d565.
The file was modified impl/src/main/java/jakarta/faces/component/UIInput.java (diff)
Commit 039c661cd0b6dc250d881064eeb134bf516f9677 by Bauke Scholtz
Found and fixed two more occurrences on synchronized(session)
https://github.com/eclipse-ee4j/mojarra/issues/5380
The file was modified impl/src/main/java/com/sun/faces/lifecycle/ClientWindowImpl.java (diff)
The file was modified impl/src/main/java/com/sun/faces/renderkit/ServerSideStateHelper.java (diff)
Commit 7fe0ddf7f788280c88f72f8f7e2dcef55c151c57 by Bauke Scholtz
Improved impl for https://github.com/eclipse-ee4j/mojarra/issues/5375
The file was modified impl/src/main/java/com/sun/faces/lifecycle/ClientWindowImpl.java (diff)
Commit 76f1cebe8db9d505156698b7973a1555f5835739 by Bauke Scholtz
First step, migrate junit4 to junit5
The file was modified impl/src/test/java/com/sun/faces/renderkit/html_basic/HeadRendererTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/FacesConfigOrderingTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/model/ScalarDataModelTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/mock/MockLifecycleFactory.java (diff)
The file was modified impl/src/test/java/jakarta/faces/model/DataModelTestCaseBase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/FactoryFinderTestCase2.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/DoubleConverterTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/mock/MockFacesContextFactory.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIOutputAttachedObjectStateTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/FacesWrapperTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/DoubleRangeValidatorTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/ValidatorTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/junit/JUnitFacesTestCaseBase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/mock/MockExternalContextFactory.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/StateHolderSaverTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/CastingValidatorTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/SearchExpressionHandlerTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIViewRootTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/RequiredValidatorTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/mock/MockLifecycle.java (diff)
The file was modified impl/src/test/java/com/sun/faces/mock/MockServletConfig.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/FloatConverterTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UICommandTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIOutputTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIInputTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/LengthValidatorTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/webapp/FacesServletTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/util/MostlySingletonTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/webapp/ConfigFileTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/el/ELUtilsTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIViewRootTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/xml/XHTMLResolvingHandler.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/RegexValidatorTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/application/resource/ResourceCacheTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/model/CollectionDataModelTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/model/ArrayDataModelTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/model/ListDataModelTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/model/ResultSetDataModelTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/facelets/util/ClasspathTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/xml/ParseXMLTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/NamingContainerTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/el/CompositeComponentAttributesELResolverTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/BigIntegerConverterTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIParameterTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/ShortConverterTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIComponentBaseBehaviorTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIDataTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UISelectItemTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/util/ByteArrayGuardAESCTRTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UISelectItemsTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/mock/MockServlet.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/IntegerConverterTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/config/DigesterFactory.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIComponentBaseTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/util/TestUtil_local.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/ValueHolderTestCaseBase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/webapp/ComponentTestImpl.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIComponentTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIInputTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/context/ExternalContextImplTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/util/TestHtmlUtils.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UISelectOneTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/event/PhaseIdTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/application/FacesMessageTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/facelets/component/UIRepeatTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/FactoryFinderTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIColumnTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIComponentBaseAttachedStateTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIGraphicTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UISelectBooleanTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/BeanValidatorTestCase.java (diff)
The file was modified impl/src/test/java/com/sun/faces/spi/ConfigurationResourceProviderFactoryTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIParameterTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UISelectItemSub.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIPanelTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/LongConverterTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/renderkit/html_basic/BodyRendererTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/config/processor/FacesConfigNamespaceContextTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/util/FacesLoggerTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/util/TestLRUMap_local.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UISelectManyTestCase.java (diff)
The file was modified impl/src/test/java/jakarta/faces/validator/LongRangeValidatorTestCase.java (diff)
The file was modified impl/pom.xml (diff)
The file was modified impl/src/test/java/com/sun/faces/renderkit/html_basic/HtmlResponseWriterTest.java (diff)
Commit 79f91ce42f957a7715d90975bad9ef54453dfa2d by Bauke Scholtz
Analyzed and fixed failing UIComponentBaseBehaviorTestCase; it was
previously never invoked, so is actually activated for the first time;
it however initially failed on 2 tests:
1) testAddBehavior(): the original assumption was that adding handler on
unsupported behavior event would throw ISE but the impl never did this,
and the javadoc also didn't say any word about this, so I adjusted the
test itself
2) testGetBehaviors(): the original assumption was that
getClientBehaviors() returns a mutable collection but this was not the
case when no initial behaviors were added, and the javadoc also didn't
say any word about this, so I adjusted the test itself
The file was modified impl/src/test/java/jakarta/faces/component/UIComponentBaseBehaviorTestCase.java (diff)
Commit 64f1ceee07ea74997c7306106eedd1679b367f89 by Bauke Scholtz
migrated EasyMock/PoweMock to Mockito
The file was modified impl/src/test/java/com/sun/faces/util/FacesLoggerTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/context/ExternalContextImplTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/FloatConverterTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/IntegerConverterTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/facelets/component/UIRepeatTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIViewRootTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/ShortConverterTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/renderkit/html_basic/HeadRendererTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIDataTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIParameterTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/component/UIInputTest.java (diff)
The file was modified impl/src/test/java/com/sun/faces/el/CompositeComponentAttributesELResolverTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/LongConverterTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/BigIntegerConverterTest.java (diff)
The file was modified impl/pom.xml (diff)
The file was modified impl/src/test/java/com/sun/faces/renderkit/html_basic/BodyRendererTest.java (diff)
The file was modified impl/src/test/java/jakarta/faces/convert/DoubleConverterTest.java (diff)
Commit 2ec61a15d2675b12c7e18fcd275f6063a34de4d9 by Bauke Scholtz
Micro optimization to clarify intent of code
https://github.com/eclipse-ee4j/mojarra/issues/5408
The file was modified impl/src/main/java/com/sun/faces/context/FacesContextImpl.java (diff)
Commit 5ed5652531f37dffa5670fd006ffc8de23c28b27 by Bauke Scholtz
Reduce logging level of exception which is already rethrown during
processing a lifecycle phase -- this only causes duplicate logs
https://github.com/eclipse-ee4j/mojarra/issues/5404
The file was modified impl/src/main/java/com/sun/faces/lifecycle/ApplyRequestValuesPhase.java (diff)
The file was modified impl/src/main/java/com/sun/faces/lifecycle/UpdateModelValuesPhase.java (diff)
The file was modified impl/src/main/java/com/sun/faces/lifecycle/InvokeApplicationPhase.java (diff)
The file was modified impl/src/main/java/com/sun/faces/lifecycle/ProcessValidationsPhase.java (diff)