Skip to content

Changes

Summary

  1. Make Fail Overflow Test less flaky (details)
  2. Add sleep to Drop Emitter test bean (details)
  3. Reorder waits and assertions to provide better result assurance (details)
  4. As emitOne is synchronous, no need to wait for exception. (details)
  5. Remove isNotEmpty assertion and unneeded force of one messsage (details)
Commit 3e5afe35c68724ccebe771ceb7d9a387db6c0721 by alex-butcher
Make Fail Overflow Test less flaky

Fail overflow test can fail to pass if exception is thrown after more then 256 messages have been processed

#162
The file was modified tck/src/main/java/org/eclipse/microprofile/reactive/messaging/tck/channel/overflow/FailOverflowStrategyOverflowTest.java (diff)
Commit 29dfac9262e3f2f98c95221998069336c7d8eaa2 by alex-butcher
Add sleep to Drop Emitter test bean
The file was modified tck/src/main/java/org/eclipse/microprofile/reactive/messaging/tck/channel/overflow/BeanWithFailOverflowStrategy.java (diff)
Commit f0ebe5786ce37ddf6ebdcc5ec6de9bd7a81009b0 by alex-butcher
Reorder waits and assertions to provide better result assurance

Wait for the failure on the stream to occur instead of the exception on the emitter - this ensures that at least the first message will be sucessfully processed and that a failure did occur before assertions are checked.

In the case where the failure may occur sufficiently late in the test execution such that there is a failure, but not yet an exception. In this case emit one more message and wait for the exception before checking

emitThree was unused and would close close the stream via `.complete()` - repurpose for being able to send one message and not close the stream if successful.
The file was modified tck/src/main/java/org/eclipse/microprofile/reactive/messaging/tck/channel/overflow/FailOverflowStrategyOverflowTest.java (diff)
The file was modified tck/src/main/java/org/eclipse/microprofile/reactive/messaging/tck/channel/overflow/BeanWithFailOverflowStrategy.java (diff)
Commit cc1b8f11358eab6ba8681933df4bf6a08a673563 by alex-butcher
As emitOne is synchronous, no need to wait for exception.
The file was modified tck/src/main/java/org/eclipse/microprofile/reactive/messaging/tck/channel/overflow/FailOverflowStrategyOverflowTest.java (diff)
Commit 3a5eeb56758f0f8a1943f31c54db6ecf3463580c by alex-butcher
Remove isNotEmpty assertion and unneeded force of one messsage
The file was modified tck/src/main/java/org/eclipse/microprofile/reactive/messaging/tck/channel/overflow/FailOverflowStrategyOverflowTest.java (diff)