Changes

Remove unused local variable.

Enable prototype support for Generic Test view - JUnit

Majority of the tabs are already providing labels support for the
prototype tab.

Do not skip API analysis for org.eclipse.jdt.ui.unittest.junit

Remove redundant tycho-version in Unittest view JUnit support feature

Already defined in parent pom.

Add api filter for internal usage in o.e.jdt.ui.unittest.junit

Improve Generic Test view label capitalization

"(generic Test view)" looks very bad in the UI.

Fixes #1293 - avoid IllegalAccessError in AddModuleRequiresCorrectionProposal (#1334)

Signed-off-by: Rob Stryker <stryker@redhat.com>
Co-authored-by: Rob Stryker <stryker@redhat.com>

Fix extract temp refactoring freezes (#1342)

* Fix ChangedValueChecker to use search instead of type hierarchy

- fix for #1317
- fix ChangedValueChecker.findFunctionDefinition() method so that
  instead of creating a type hierarchy for the project, first check
  if the declaration of the method is in a class with source in
  which case find the definition and if the declaration is in an
  interface, use SearchEngine to find implementers of the interface
  and process all finds for a class with source

Improve "silent" fails in MarkOccurrenceTest

Test is unstable (e.g. failed in tonight's I-build
https://download.eclipse.org/eclipse/downloads/drops4/I20240421-1800/testresults/html/org.eclipse.jdt.text.tests_ep432I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html
).
This change replaces silent fails with proper exception reporting.

Javadoc sections misaligned

Regression from cbc03c25f6059c774d8766bd7b02489c9df53acf

The code moved from JavadocContentAccess2 to CoreJavadocAccessImpl
changed dt/dd tags to ul/li tag pairs, and that broke javadoc alignment.

This commit restores original tag pairs used for javadoc formatting.

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1346

Javadoc error fixes

Seen in jenkins builds for
https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/1351

Fix string concat to MessageFormat to use text block when possible (#1348)

- expose some text block logic from StringConcatToTextBlockFixCore
- change ConvertToMessageFormatFixCore to use a text block for
  JVM 15 and above
- add new tests to AssistQuickFixTest15
- fixes #1311

Fix string concat to String.format to use text block when possible (#1365)

- change ConvertToStringFormatFixCore to use a text block for
  JVM 15 and above
- add new tests to AssistQuickFixTest15
- fixes #1311

Escape specifiers when converting to MessageFormat or String.format (#1368)

- for MessageFormat, put parentheses in single quotes and look for
  open/closed parentheses one after another
- for String.format, escape % as %%
- modify tests in AssistQuickFixTest15
- fixes #1366

Remove unused API filter for RecordPattern

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1352

Refactor OverriddenAssignmentCleanUp to jdt.core.manipulation (#1371)

- create new OverriddenAssignmentCleanUpCore and
  OverriddenAssignmentFixCore classes in jdt.core.manipulation
- modify OverriddenAssignmentCleanUp to use core class
- remove old OverriddenAssignmentCleanUp
- fixes #1370

Refactor ElseIfCleanUp to jdt.core.manipulation (#1374)

- create new ElseIfCleanUpCore and ElseIfFixCore classes
- modify CodeStyleTabPage, CleanUpPerfTest, and plugin.xml to
  refer to new core clean-up
- fixes #1373

Update license-maven plugin to 2.4.0

Fix inline method to handle a synchronized input method (#1378)

- modify CallInliner to add logic to add a synchronized block
  if the method to inline is synchronized
- issue warning if synchronized block cannot be substituted for
  expression call
- add new tests to InlineMethodTests and InlineMethodTests16
- fixes #1360

Add support to filter chain by passing the in the token (#1282)

Don't use text block for MessageFormat/String.format if one line concat (#1385)

- for a single line concat, don't use a text block when converting a
  string concat to MessageFormat or String.format in
  ConvertToMessageFormatFixCore and ConvertToStringFormatFixCore
- add new tests to AssistQuickFixTest15
- fixes #1384

Make CoreJavadocAccessImpl more extendable for jdt.ls

Signed-off-by: Rob Stryker <stryker@redhat.com>

Add 'Open Call Hierarchy' hyperlink for type elements as well

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1231

Refactor MultiCatchCleanUp to jdt.core.manipulation (#1383)

- fixes #1382

Fix inline method to check access modifiers of inlined code (#1381)

* Fix inline method to check access modifiers of inlined code

- add new checkAccessCompatible() method to SourceProvider that
  checks if code from declaration can be moved to target without
  causing an access violation
- add new AccessVisitor to SourceAnalyzer to log non-public
  accesses (private, package-private, and protected)
- add call to checkAccessCompatible() in CallInliner
- add new tests to InlineMethodTests
- fixes #1358

Fix ExtractMethodAnalzyer to prevent extract of single return statement (#1388)

* Fix ExtractMethodAnalzyer to prevent extract of single return statement

- fix ExtractMethodAnalyzer.analyzeSelection() to recognize a
  single return statement and fail
- add new tests to ExtractMethodTests
- fixes #1355

Don't allow extracting a final field assignment to a new method (#1389)

- fix ExtractMethodAnalyzer to add a new check if selected statements
  to extract contain a final field assignment and fail if this is true
- add new tests to ExtractMethodTests
- fixes #1356

Update client code that references removed jdt.dom APIs (#1387)

https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/1387

Remove unused API filters

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1392

Add lock object to fDocument in DocumentAdapter.initialize()

This change adds a lock object to `Document` use in `DocumentAdapter`, in order to prevent concurrent text buffer access. See: https://github.com/eclipse-platform/eclipse.platform.ui/issues/1059

Do not allow move of final method into an interface (#1391)

* Warn when moving final method into an interface

- fix MoveInstanceMethodProcessor to check for this situation and issue warning
  plus remove final modifier when making the change
- fixes #1353

Fix IOOB exception in Javadoc hover (#1395)

- modify the logic for <pre>{@code that handles the case where
  the code has } in it so that it only looks for }</pre> when
  the pre counter matches and also add a check to ensure that the
  IOOB exception cannot happen
- add new test to JavadocHoverTests with an invalid <pre> which
  forces a }</pre> to occur without a <pre>{@code
- fixes #1394

Refactor UnnecessaryArrayCreation cleanup and quick-assist for jdt.ls (#1397)

- move and rename UnnecessaryArrayCreationCleanUp and
  UnnecessaryArrayCreationFix to jdt.core.manipulation and
  Core to end of names
- fixes #1397