Changes

Refactor deprecated SubProgressMonitor usage into Progress.subMonitor

To centralize many deprecation warnings, since there is no replacement
for SUPPRESS_SUBTASK_LABEL/PREPEND_MAIN_LABEL_TO_SUBTASK

Examples: fix warnings

Failed TestTemplate with only one test doesn't show fail trace

This change adjusts TestSuiteElement to show the trace of a failed
child, if that child is the only test case it ran and its dynamic. It
also adjusts navigation to the failed line in this case - so that
navigation goes to the failed line and not to the test method with the
@TestTemplate annotation.

Fixes: #1021
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>

Update HierarchicalASTVisitor

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1028

Unrelated errors reported during Jenkins build

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1026

Make order of elements in saved JAR description file deterministic #1024

When exporting JAR description files from the JarPackageWizard, the
elements to be exported into the JAR file are currently stored in a
non-deterministic order. This makes it particularly difficult to merge
the description files in case they are put under version control.

This change makes a JAR description file exported from the
JarPackageWizard always list the exported elements in the same order by
sorting them according to their names. It also adds an according
regression test.

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1024

Read java file as stream in JUnit5TestFinderJupiterTest #999

Read the contents of the java file (test class) as a stream to avoid
FileNotFoundException in nightly builds.

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/999

Bug 196547 - [formatter] Option to join or rewrap wrapped line comments (#1037)

Refactor string concat fixes to be used in headless mode. (#1032)

Feature Proposal Make Static Refactoring (#689)

* Feature Proposal Make Static Refactoring

Fixes #590

Introducing a new Refactoring called "Make Static", a tool that transforms instance methods into static ones in the context of Eclipse's Java Development Tools. This involves adjusting method invocations appropriately to maintain logical correctness. The refactoring supports both instance and static contexts, passing 'this' for invocations within instance methods and the relevant instance variable for invocations in other classes or static methods.

Co-authored-by: Michael5601 <michael.bangas@vector.com>
Co-authored-by: Jeff Johnston <jjohnstn@redhat.com>

Remove not thrown but declared exception in JUnitLaunchShourcut

FilteredTypesSelectionDialog: fix save after open #1051

partially revert of fc6a25a6a1d46627eae34f4aeab98cafb71a5f70

https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1051

Fix ExtractConstantRefactoring to recognize no type is available (#1046)

- fixes #1023
- add new test to ExtractConstantTests1d7.java

[formatter] Align arrows on column in switch statements/expressions (#1049)

Junit, Refactoring: some SubMonitor usage

To get rid of SubProgressMonitor deprecation warnings

Add support for code completion inside text block templates #1038 (#1055)

Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>

refactor method-ref fixes to be used in headless mode. (#1048)

* refactor method-ref fixes to be used in headless mode.

Fix ExtractConstantRefactorings to handle NLS tags (#1060)

- fixes #1040
- don't perform convert to MessageFormat.format() or String.format()
  unless all string literals have NLS tags or none do
- add new tests to AssistQuickFixTest

New preferences for annotation based resource leak analysis (#1064)

fixes #1059

Fix Bug 148012 - add quick fix to assign statement to local variable (#1004)

* Fix Bug 148012 - add quick fix to assign statement to local variable

- see https://bugs.eclipse.org/bugs/show_bug.cgi?id=148012
- use similar logic from QuickAssistProcessor in QuickFixProcessor
  when problem is IProblem.ParsingErrorInsertToComplete
- add new test to QuickFixTest1d8
- don't add light-bulb for ParsingErrorInsertToComplete
- fix QuickFixTest to have a version of collect completions that
  doesn't verify the light bulb marker

Update Jenkinsfile: reject ECJ warnings (#1069)

Ensure "Make Static" refactoring only adds parameter if necessary #1044 (#1072)

The "Make Static" refactoring currently adds a "this" parameter to the
method in cases in which it is actually not necessary. This is
particularly the case the body of the method to be refactored contains
invocations of methods on a newly instantiated object. The according
logic erroneously considers such a method invocation as a reason to add
a parameter.

With this fix, the identification of whether a parameter needs to be
added to the method depends on whether the logic calculating an actual
change to the method body is actually applied. An according
regression test for the behavior is added.

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1044

A small pushdown of some classes jdt.ls would like to make use of (#1053)

* A small pushdown of some classes jdt.ls would like to make use of

Signed-off-by: Rob Stryker <stryker@redhat.com>

Avoid "overlapping text edits" in "Make Static" refactoring #1045 (#1070)

* Avoid "overlapping text edits" in "Make Static" refactoring #1045

The "Make Static" refactoring currently produces overlapping text edits
in case there are changes in the source code file containing the
refactored method before and after that method. The reason is that the
calls to the refactored method are wrapped into a single MultiTextEdit
whose scope is then overlapping with the TextEdit for the refactored
method itself.

With this fix, the changes to callers of the refactored method are
treated as individual TextEdits rather than one MultiTextEdit, so that
none of the generated text edits have pairwise overlaps. An according
regression test for the behavior is added.

Fixes #1045

Sub processor pushdown1 (#1078)

* Abstract out JavadocTagsSubProcessor for extension
* Abstract out SerialVersionSubProcessor
* Separate core from ui for UnInitializedFinalFieldSubProcessor
* Allow all subprocessors to use IInvocationContextCore

Signed-off-by: Rob Stryker <stryker@redhat.com>
Co-authored-by: Rob Stryker <stryker@redhat.com>

Use the ECJ generated compiler logs to parse compiler problems

fix "Potential null pointer access" markers (#1086)

* disabled warning in test and example code
* raised level to warning in production code
* refactored code to get rid of all warnings

Co-authored-by: Jörg Kubitz <jkubitz-eclipse@gmx.de>

add missing @Override

Pushdown cleanup api (#1079)

* Push cleanup classes down to jdt.core.manipulations

Signed-off-by: Rob Stryker <stryker@redhat.com>

OwningAnnotationsConfigurationDialog_title missing (#1100)

fixes #1094

Improve Javadoc generated by "Make Static" refactoring #1043 (#1084)

This change improves the Javadoc generation behavior of the "Make
Static" refactoring and aligns it with other refactorings such as
"Change Method Signature". It ensures that generated parameter tags are
inserted at proper positions within an existing Javadoc comment. The tag
for the parameter itself is added as the first parameter tag, following
any author or version tags. The tags for potential type parameters are
added as the last parameter tags, preceding any other tags than author
or version.

The reused functionality from
ChangeMethodSignatureRefactoringContribution is factored out to the
JavadocUtil class.

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1043

Fix ClassCastException in convert field name quick assist (#1106)

- fixes #1096

Correct "Make Static" refactoring behavior for anonymous classes #1083 (#1085)

The "Make Static" refactoring erroneously interprets a method call
within an anonymous class inside the refactored method as a call on
`this` and thus changes the method invocation to be performed on the
added input parameter of the method. This is (1) semantically incorrect
and (2) leads to compile errors if the type of the added parameter does
not provide the method.

With this fix, the identification of whether a method invocation is
performed on the `this` object of the method to be refactored and not
some instance of an anonymous inner class inside that method is
corrected. For three different scenarios (anonymous class extending
outer class, anonymous class extending other class, and nested anonymous
classes), regression tests are added.

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1083

fix CallHierarchyTestHelper generics

get rid of deprecated newInstance()

Fix NPE when type declaration is not found. Fix #1097

Refresh CallHierarchy on FiltersDialog validation

TestRunner: fix warnings

ReferenceTracker: avoid deprecated Field.isAccessible

add missing @Deprecated

CallHierarchy: fix error when clicking a method that is gone #1098

https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1098

remove Exceptions not actually thrown

eliminates problem markers and dead code

remove unused parameters

to get rid of "is not used" problem markers

Fix String concat to text block to properly handle spaces (#1112)

* Fix String concat to text block to properly handle spaces

- fixes #1111
- add new tests to AssistQuickFixTest15
- Fix CleanUpTest15 expected results

TestCaseClassLoader: use try-with-resource

Separate core and ui for GetterSetterCorrectionSubProcessor and VarargsWarningsSubProcessor (#1116)

Signed-off-by: Rob Stryker <stryker@redhat.com>
Co-authored-by: Rob Stryker <stryker@redhat.com>

Fix `jar-in-jar-loader` multi-release support (#1058)

In order to open a JAR file in multi-release mode the URL of the file
must be suffixed with `#runtime`.

Currently the `rsrc:` URL handler strips this fragment, which breaks
multi-release JARs retrieved through the `rsrc:` protocol.

Don't set preference key of other bundle on shutdown

The other bundle might not be shutdown yet and would still want that
key.

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1093

Update jar-in-jar-loader.zip after changes to rsrc code (#1127)

Fix SourceViewerInformationControl not updating String input (#1125)

fix "hiding" warnings

fix javadoc "cannot be resolved to a type"

Touch bundle affected by compiler implementation change

See https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/1750

SemanticHighlighting: fix BadLocationException #1131

https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1131

OpenCallHierarchyAction.getEnclosingMethod silence NPE #1132

https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1132

Move additional methods in SuppressWarningsSubprocessorCore to jdt.core.manipulation

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>

[formatter] Setting for opening brace position after arrow in switch (#1473)

Add quick fix for duplicate constructor that doesn't do rename (#1128)

- fixes #1123
- modify LocalCorrectionsSubProcessor.addInvalidVariableNameProposals()
  to recognize a duplicate constructor and instead of a rename suggest
  removal of duplicate constructor
- add new test to LocalCorrectionsQuickFixTest.java

Fix exception in use comparator cleanup (#1137)

- fixes #915
- add wildcard support to ComparingOnCriteriaOperation.buildMethod()
  similar to what was added to buildField()
- add to existing test case in CleanUpTest1d8 for comparator cleanup

Sub processor push down part2 (#1120)

* Split core/ui for ReorgCorrectionsSubProcessor
* Separate core/ui in TypeMismatchSubProcessor
* Split core/ui for ReturnTypeSubProcessor
* Heavy work on UnresolvedElementsSubProcessor and linked classes
* Update api filters

Signed-off-by: Rob Stryker <stryker@redhat.com>

CompletionProposal: log error and keep going with other providers

for example
https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/230

InlineMethodFixCore: fix "The value of the local variable is not used"

NPE in StubUtility when generating javadoc for method declaration with no return type (#1142)

Signed-off-by: Rob Stryker <stryker@redhat.com>
Co-authored-by: Rob Stryker <stryker@redhat.com>

Cleanup in all -BaseSubProcessor classes and extenders (#1141)

Signed-off-by: Rob Stryker <stryker@redhat.com>
Co-authored-by: Rob Stryker <stryker@redhat.com>

fix ImporterTest.testImportRawJavaProject()

to use public API instead of type cast.
Failing since I20240130-1800

Java nature and java project are now implemented as separate instances
https://github.com/eclipse-jdt/eclipse.jdt.core/pull/1916

Jenkinsfile: fix wrong referenceBuild

fix "illegally instantiates AssertionFailedException"