Skip to content

Changes

Summary

  1. Bug 572574 - [AutoRefactor #71/151] Do/while rather than while (details)
Commit 6efa26af3d78c839a6b195278ad75b37400012d1 by Jeff Johnston
Bug 572574 - [AutoRefactor #71/151] Do/while rather than while

Replace while by do/while:
- The first evaluation must be always true,
- The first evaluation must be passive.

Given:
        boolean isInitedToTrue= true;
        while (isInitedToTrue) {
            if (i > 100) {
                isInitedToTrue= false;
            }
            i *= 2;
        }

When:
Select while loop and perform CTRL+1 to do quick fix...

Then:
        boolean isInitedToTrue= true;
        do {
            if (i > 100) {
                isInitedToTrue= false;
            }
            i *= 2;
        } while (isInitedToTrue);

Change-Id: I7c778d6777a5e363e4fc1f2df6c57a57f0d4ff32
Signed-off-by: Fabrice Tiercelin <fabrice.tiercelin@yahoo.fr>
Signed-off-by: Jeff Johnston <jjohnstn@redhat.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/178824
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modified org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/cleanup/CleanUpMessages.java
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/fix/DoWhileRatherThanWhileCleanUpCore.java
The file was modified org.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/fix/MultiFixMessages.properties
The file was addedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/DoWhileRatherThanWhileFix.java
The file was addedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/DoWhileRatherThanWhileCleanUp.java
The file was modified org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/AssistQuickFixTest.java
The file was modified org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java
The file was modified org.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/fix/MultiFixMessages.java
The file was modified org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/FixMessages.properties
The file was modified org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CleanUpConstantsOptions.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/DoWhileRatherThanWhileFixCore.java
The file was modified org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/CleanUpConstants.java
The file was modified org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
The file was modified org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/cleanup/CleanUpMessages.properties
The file was modified org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/IProposalRelevance.java
The file was modified org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/FixMessages.java