Skip to content
Success

Changes

Summary

  1. Bug 574588 - fix NPE in "Convert StringBuffer to StringBuilder" cleanup (details)
Commit 17aeed0e60c29ffa0199fcb7cfcf462ebcdaa31b by Jeff Johnston
Bug 574588 - fix NPE in "Convert StringBuffer to StringBuilder" cleanup

- fix MethodDeclaration visitor in StringBufferToStringBuilderFixCore
  to handle when return type comes back null as in the case of a
  constructor
- add testing of private constructors to CleanUpTest1d5 and ensure
  an all change will modify StringBuffer parameters
- add testing of private constructors to CleanUpTest16

Change-Id: Id4b7b877ec862356733fb807eaee40e5d3aa1cd1
Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de>
Signed-off-by: Jeff Johnston <jjohnstn@redhat.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/182758
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modified org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/StringBufferToStringBuilderFixCore.java
The file was modified org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest16.java
The file was modified org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest1d5.java