Skip to content
Success

Changes

Summary

  1. Minor code formatting (details)
  2. GJULE integration with GlassFish (details)
  3. Fixed printing OSGI issues in EmbeddedOSGiGlassFishRuntime (details)
  4. Level of "service (un)registered" message changed from INFO to CONFIG (details)
  5. The systemRootLoggerLevel changed to systemRootLogger.level (details)
Commit 06728adff70e76b594023579c2f382881fcd1b65 by David Matějček
Minor code formatting
The file was modified appserver/persistence/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container/EntityBeanHomeImpl.java
The file was modified appserver/persistence/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container/ReadOnlyEJBHomeImpl.java
The file was modified appserver/tests/tck/cdi/src/test/java/org/jboss/weld/tck/glassfish/GlassFishELImpl.java
The file was modified appserver/persistence/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container/EntityContainer.java
The file was modified appserver/orb/orb-iiop/src/main/java/org/glassfish/enterprise/iiop/impl/GlassFishORBManager.java
The file was modified appserver/persistence/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container/EntityBeanLocalHomeImpl.java
The file was modified appserver/persistence/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container/spi/ReadOnlyEJBHome.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/OSGiFrameworkLauncher.java
Commit 1d6cdb2bbc94b63b85800b7b8fb60dbf39a7772e by David Matějček
GJULE integration with GlassFish

- own folder and CL for bootstrap dependencies - no need for JVM options
- sorted logging.properties
- HK2 services ARE NOT the logging system, but USE the logging system
- AdminMain sets the log manager, but doesn't set the configuration yet - this
  step is on the server (it has to load logging.properties first). All log
  records are buffered automatically -> no need for earlyLogMessages any more,
  they also contained around 20 selected messages, but all other logs were lost.

- url classloaders have toString
- DirectoryClassLoader doesn't throw IOE but ISE -> if anything would go wrong,
  we have ISE with stacktrace instead of NPE following swallowed IOE.

- Fixed some log messages
- Fixed SecurityManager complaints in QuickLook tests
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/DirectoryClassLoader.java
The file was modified appserver/concurrent/concurrent-impl/src/main/java/org/glassfish/concurrent/runtime/ContextSetupProviderImpl.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/OSGiGlassFishRuntimeBuilder.java
The file was modified appserver/distributions/glassfish/src/main/assembly/glassfish.xml
The file was modified appserver/resources/resources-connector/src/test/resources/DomainTest.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/GFFileHandler.java
The file was modified appserver/admin/template/src/main/resources/config/domain.xml
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContext.java
The file was modified appserver/web/web-glue/osgi.bundle
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/EmbeddedOSGiGlassFishRuntimeBuilder.java
The file was modified appserver/pom.xml
The file was modified appserver/distributions/web/src/main/assembly/web.xml
The file was modified nucleus/core/extra-jre-packages/pom.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/GFLogRecord.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/DeleteLogLevel.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/InstanceGetLogFileCommand.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/ParsedLogRecord.java
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/remote/RemoteCommand.java
The file was modified nucleus/deployment/common/src/test/java/com/sun/enterprise/deploy/shared/FileArchiveTest.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogRotationTimerTask.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEventBroadcaster.java
The file was modified nucleus/distributions/nucleus/src/main/assembly/nucleus-new.xml
The file was modified nucleus/core/logging/pom.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEvent.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParserException.java
The file was modified nucleus/core/kernel/src/test/resources/DomainTest.xml
The file was removednucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/LogEventListenerTest.java
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/CommandRunnerImpl.java
The file was addednucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassfishUrlClassLoader.java
The file was removednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/logviewer/backend/logentry.bin
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/UniformLogParser.java
The file was modified appserver/appclient/client/acc/src/main/java/org/glassfish/appclient/client/acc/ACCLogger.java
The file was modified nucleus/glassfish-jul-extension/src/main/java/org/glassfish/main/jul/GlassFishLogger.java
The file was modified nucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/parser/LogParserTest.java
The file was removedappserver/web/web-glue/src/main/java/commons-logging.properties
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/remote/RemoteCLICommand.java
The file was modified nucleus/core/bootstrap/pom.xml
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/GlassFishMainActivator.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/BundleProvisioner.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/EmbeddedOSGiGlassFishRuntime.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ExcludeFieldsSupport.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParserFactory.java
The file was modified nucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/parser/uniform-server.log
The file was modified appserver/appclient/client/acc-standalone/pom.xml
The file was modified appserver/web/web-glue/pom.xml
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParserListener.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/RawLogParser.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogRotationTimer.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/SetLogAttributes.java
The file was modified nucleus/admin/config-api/src/test/java/com/sun/enterprise/configapi/tests/EnabledTest.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/MainHelper.java
The file was modified nucleus/common/common-util/pom.xml
The file was modified nucleus/core/logging/osgi.bundle
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/v3/logging/AgentFormatterDelegate.java
The file was addednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/OneLineLogParser.java
The file was modified nucleus/parent/pom.xml
The file was modified appserver/tests/appserv-tests/devtests/admin/cli/resources/configs/v3_0_1domain.xml
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/core/proxy/AMXProxyHandler.java
The file was modified appserver/appclient/client/acc/pom.xml
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/AdminRESTConfigUpgrade.java
The file was modified nucleus/test-utils/pom.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/SyslogHandler.java
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/logging/Logging.java
The file was removednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/test/.gitkeep_empty_dir
The file was modified nucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/LoggingAnnotationsTest.java
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/AdminMain.java
The file was modified appserver/admin/cli/pom.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/Syslog.java
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/core/AMXProxy.java
The file was modified nucleus/admin/config-api/src/main/java/org/glassfish/config/support/DomainXml.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParser.java
The file was modified nucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/parser/odl-server.log
The file was addednucleus/common/common-util/src/main/java/com/sun/logging/LogDomainsLogger.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEventImpl.java
The file was modified nucleus/admin/config-api/src/main/java/com/sun/enterprise/config/util/ConfigApiLoggerInfo.java
The file was modified nucleus/distributions/atomic/src/main/assembly/atomic.xml
The file was modified nucleus/distributions/nucleus-common/src/main/resources/bin/nadmin
The file was modified nucleus/test-utils/src/main/java/org/glassfish/tests/utils/junit/HK2JUnit5Extension.java
The file was modified nucleus/admin/rest/rest-service/src/main/java/org/glassfish/admin/rest/resources/custom/LogNamesResource.java
The file was modified nucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingXMLNames.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/UniformLogFormatter.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/logviewer/backend/LogFile.java
The file was modified nucleus/admin/launcher/pom.xml
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/ClassPathBuilder.java
The file was modified nucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingConfig.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/ODLLogParser.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/SetLogFileFormat.java
The file was modified nucleus/deployment/common/pom.xml
The file was modified nucleus/admin/cli/pom.xml
The file was removednucleus/core/bootstrap/src/main/java/org/glassfish/.gitkeep_empty_dir
The file was removednucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/client/.gitkeep_empty_dir
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/ASMain.java
The file was modified nucleus/common/internal-api/src/main/java/org/glassfish/internal/api/LogManager.java
The file was modified nucleus/admin/template/src/main/resources/config/logging.properties
The file was modified nucleus/glassfish-jul-extension/src/main/java/org/glassfish/main/jul/GlassFishLogManager.java
The file was modified nucleus/common/common-util/osgi.bundle
The file was modified appserver/logging/logging.properties
The file was modified nucleus/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/ConfigBeansUtilities.java
The file was modified nucleus/common/amx-core/pom.xml
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishMain.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/RotateLog.java
The file was modified nucleus/core/bootstrap/osgi.bundle
The file was addednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/parser/oneline-server.log
The file was modified nucleus/common/common-util/src/main/java/com/sun/logging/LogDomains.java
The file was modified nucleus/admin/rest/rest-service/src/main/java/org/glassfish/admin/rest/RestLogging.java
The file was modified nucleus/common/simple-glassfish-api/src/main/java/org/glassfish/embeddable/GlassFishRuntime.java
The file was removednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/logviewer/backend/README.txt
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/commands/ListJobsCommand.java
The file was modified nucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/logviewer/backend/LogFileTest.java
The file was modified nucleus/glassfish-jul-extension/src/test/java/org/glassfish/main/jul/GlassFishLoggerTest.java
The file was modified nucleus/cluster/gms-adapter/src/main/java/org/glassfish/gms/GMSConfigUpgrade.java
The file was addednucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassfishBootstrapClassLoader.java
The file was modified nucleus/core/kernel/osgi.bundle
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/LogFacade.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/logviewer/backend/LogFilter.java
The file was modified nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncherLogger.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogManagerService.java
The file was modified appserver/deployment/jakartaee-full/src/main/java/org/glassfish/javaee/full/deployment/EarLibClassLoader.java
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/Environment.java
The file was modified nucleus/admin/template/src/main/resources/config/domain.xml
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean/LoggingImpl.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/FormatterDelegate.java
The file was modified nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncherMain.java
The file was modified nucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingConfigImpl.java
The file was modified nucleus/core/kernel/pom.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ODLLogFormatter.java
The file was addednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ServerLogFileService.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/logviewer/backend/LogFilterForInstance.java
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/JobManagerService.java
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/AdminConsoleConfigUpgrade.java
The file was modified nucleus/featuresets/atomic/pom.xml
The file was modified nucleus/admin/rest/rest-service/src/main/java/org/glassfish/admin/rest/resources/custom/StructuredLogViewerResource.java
The file was removednucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingOutputStream.java
The file was addednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ServerLogFileManager.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEventListener.java
Commit 7e7c6c89134e20ee8e9496f2e04c8a7993943672 by David Matějček
Fixed printing OSGI issues in EmbeddedOSGiGlassFishRuntime

- originally I even removed the FelixPrettyPrinter usage as I did not see
  any difference, then I noticed that MultiExceptions are sometimes incorrectly
  layered by HK2 and it was possible just to enhance the algorithm for
  finding the BundleException.
- moved and extended the test from main to JUnit.
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/EmbeddedOSGiGlassFishRuntime.java
The file was modified nucleus/common/common-util/src/main/java/com/sun/enterprise/util/FelixPrettyPrinter.java
The file was addednucleus/common/common-util/src/test/java/com/sun/enterprise/util/FelixPrettyPrinterTest.java
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/server/APIClassLoaderServiceImpl.java
Commit 2934723b4468a3508e74ca85bea89fd92aa69c1d by David Matějček
Level of "service (un)registered" message changed from INFO to CONFIG

- it is not relevant for the user
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/LogFacade.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/EmbeddedOSGiGlassFishImpl.java
Commit e1b4c2fc953944ebf7eab0f2a24edfefe09cf99d by David Matějček
The systemRootLoggerLevel changed to systemRootLogger.level

- it is a standard
- affects also get-log-attributes output, etc.
The file was modified nucleus/glassfish-jul-extension/src/main/java/org/glassfish/main/jul/cfg/GlassFishLogManagerProperty.java
The file was modified appserver/tests/admin/tests/src/test/java/org/glassfish/main/admin/test/AsadminLoggingITest.java
The file was modified nucleus/admin/template/src/main/resources/config/logging.properties
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishMain.java