Skip to content
Success

Changes

Summary

  1. Partial cleanup in war-util and classloaders (details)
  2. Fixed another few CDI TCK tests (details)
  3. Reflecting code review: Using Boolean.getBoolean (details)
  4. Fixed timeout tests in Servlet TCK (details)
  5. Fixed default httpOnly value - should be true (details)
  6. Rules for resource and class loading resolution aligned (details)
  7. GJULE integration with GlassFish (details)
Commit b4e5d0bf8f0d610126cf4ee1eb16a9950b898819 by David Matějček
Partial cleanup in war-util and classloaders

- generics, stringbuffers, formatting, deprecated methods
- bit of optimization
- debug removed (unused)
- delegate is true by default, synced
- logic around isDelegateFirstResource simplified (probably will be revisited
  for Faces TCK)
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/connector/AsyncContextImpl.java
The file was modified appserver/web/war-util/src/main/java/com/sun/enterprise/glassfish/web/WarHandler.java
The file was removedappserver/web/war-util/src/main/java/com/sun/logging/enterprise/system/container/web/.gitkeep_empty_dir
The file was removedappserver/web/war-util/src/main/java/com/sun/logging/enterprise/system/tools/deployment/.gitkeep_empty_dir
The file was modified nucleus/common/common-util/src/main/java/com/sun/enterprise/loader/ASURLClassLoader.java
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContext.java
The file was modified appserver/web/web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
The file was removedappserver/web/war-util/src/main/resources/com/sun/logging/enterprise/system/tools/deployment/.gitkeep_empty_dir
The file was modified appserver/web/war-util/src/main/java/org/glassfish/web/loader/WebappClassLoader.java
The file was removedappserver/web/war-util/src/main/resources/org/apache/naming/resources/.gitkeep_empty_dir
The file was removedappserver/web/war-util/src/main/resources/org/glassfish/web/loader/.gitkeep_empty_dir
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java
Commit ec02bb65d59515f28a20baf0ae0b9f265225e682 by David Matějček
Fixed another few CDI TCK tests

- some CDI TCK tests rely on loadOnStartup for servlets, so we made it a feature
- it is now possible to use a system property to enforce that all servlets will
  load on application startup: glassfish.servlet.loadAllOnStartup=true
  Default value is false, then servlets which don't have loadOnStartup attribute
  will load on the first request.
- thrown exceptions are always propagated
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/Wrapper.java
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardWrapper.java
The file was modified appserver/tests/tck/cdi/pom.xml
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContext.java
Commit f2794289435719ed25328c334980eff3e0909d90 by David Matějček
Reflecting code review: Using Boolean.getBoolean
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContext.java
Commit bc399c8972824ec224f326c9f59348afea49374b by David Matějček
Fixed timeout tests in Servlet TCK

- probably I had this line forgotten in my stash because of some recent
  experiment and I committed that in b4e5d0bf8f0d610126 by mistake
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/connector/AsyncContextImpl.java
Commit 08c46d267561ea62402ecb4fb1c7a42d231cae31 by Hiroki Sawamura
Fixed default httpOnly value - should be true

Signed-off-by: hs536 <sawamura.hiroki@fujitsu.com>
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/core/SessionCookieConfigImpl.java
Commit 3cf6b08506b988f66722b49f31b4713d9dc0de61 by David Matějček
Rules for resource and class loading resolution aligned

- overridablePackages are not added, but set, and then just used. Because it
  is just configured and then read, we don't need ConcurrentLinkedQueue
- useMyFaces now affects both classes and resources
- org.apache.commons.logging doesn't exist in GlassFish - removed
- com.sun.enterprise.overrideablejavaxpackages renamed to
  org.glassfish.main.webappCL.overridablePackages
  - I don't think anyone used it for years, but it really could be useful.
  - overridable packages are now set only by this system property.

Signed-off-by: David Matějček <dmatej@seznam.cz>
The file was modified appserver/web/war-util/src/main/java/org/glassfish/web/loader/WebappClassLoader.java
The file was modified appserver/web/web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/Loader.java
Commit 1d6cdb2bbc94b63b85800b7b8fb60dbf39a7772e by David Matějček
GJULE integration with GlassFish

- own folder and CL for bootstrap dependencies - no need for JVM options
- sorted logging.properties
- HK2 services ARE NOT the logging system, but USE the logging system
- AdminMain sets the log manager, but doesn't set the configuration yet - this
  step is on the server (it has to load logging.properties first). All log
  records are buffered automatically -> no need for earlyLogMessages any more,
  they also contained around 20 selected messages, but all other logs were lost.

- url classloaders have toString
- DirectoryClassLoader doesn't throw IOE but ISE -> if anything would go wrong,
  we have ISE with stacktrace instead of NPE following swallowed IOE.

- Fixed some log messages
- Fixed SecurityManager complaints in QuickLook tests
The file was modified appserver/admin/template/src/main/resources/config/domain.xml
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/JobManagerService.java
The file was modified appserver/resources/resources-connector/src/test/resources/DomainTest.xml
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/CommandRunnerImpl.java
The file was modified appserver/appclient/client/acc/src/main/java/org/glassfish/appclient/client/acc/ACCLogger.java
The file was modified nucleus/admin/rest/rest-service/src/main/java/org/glassfish/admin/rest/resources/custom/LogNamesResource.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/logviewer/backend/LogFilterForInstance.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ExcludeFieldsSupport.java
The file was modified nucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/parser/LogParserTest.java
The file was modified appserver/appclient/client/acc/pom.xml
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContext.java
The file was addednucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassfishUrlClassLoader.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/UniformLogParser.java
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/DirectoryClassLoader.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/DeleteLogLevel.java
The file was modified appserver/web/web-glue/osgi.bundle
The file was modified nucleus/deployment/common/pom.xml
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/Environment.java
The file was modified nucleus/admin/rest/rest-service/src/main/java/org/glassfish/admin/rest/RestLogging.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/SetLogAttributes.java
The file was addednucleus/common/common-util/src/main/java/com/sun/logging/LogDomainsLogger.java
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/AdminConsoleConfigUpgrade.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ODLLogFormatter.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/UniformLogFormatter.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/MainHelper.java
The file was modified nucleus/admin/config-api/src/main/java/org/glassfish/config/support/DomainXml.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/OSGiGlassFishRuntimeBuilder.java
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/AdminMain.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/logviewer/backend/LogFile.java
The file was modified nucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/LoggingAnnotationsTest.java
The file was modified nucleus/core/kernel/pom.xml
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParserListener.java
The file was modified nucleus/core/bootstrap/osgi.bundle
The file was modified appserver/pom.xml
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/core/proxy/AMXProxyHandler.java
The file was addednucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassfishBootstrapClassLoader.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParserFactory.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/SyslogHandler.java
The file was modified nucleus/core/logging/osgi.bundle
The file was modified nucleus/cluster/gms-adapter/src/main/java/org/glassfish/gms/GMSConfigUpgrade.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/RotateLog.java
The file was modified nucleus/common/common-util/pom.xml
The file was modified appserver/deployment/jakartaee-full/src/main/java/org/glassfish/javaee/full/deployment/EarLibClassLoader.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/ODLLogParser.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/BundleProvisioner.java
The file was modified nucleus/core/kernel/src/test/resources/DomainTest.xml
The file was addednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/OneLineLogParser.java
The file was modified nucleus/common/common-util/src/main/java/com/sun/logging/LogDomains.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/GlassFishMainActivator.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEvent.java
The file was modified nucleus/admin/config-api/src/test/java/com/sun/enterprise/configapi/tests/EnabledTest.java
The file was modified nucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingXMLNames.java
The file was modified nucleus/admin/rest/rest-service/src/main/java/org/glassfish/admin/rest/resources/custom/StructuredLogViewerResource.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/RawLogParser.java
The file was modified nucleus/admin/template/src/main/resources/config/logging.properties
The file was modified appserver/logging/logging.properties
The file was modified nucleus/common/simple-glassfish-api/src/main/java/org/glassfish/embeddable/GlassFishRuntime.java
The file was modified nucleus/deployment/common/src/test/java/com/sun/enterprise/deploy/shared/FileArchiveTest.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogRotationTimer.java
The file was modified appserver/appclient/client/acc-standalone/pom.xml
The file was addednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ServerLogFileManager.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/v3/logging/AgentFormatterDelegate.java
The file was modified nucleus/glassfish-jul-extension/src/main/java/org/glassfish/main/jul/GlassFishLogger.java
The file was modified nucleus/core/bootstrap/pom.xml
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParser.java
The file was modified nucleus/distributions/nucleus-common/src/main/resources/bin/nadmin
The file was modified nucleus/test-utils/pom.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/GFLogRecord.java
The file was modified nucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/logviewer/backend/LogFileTest.java
The file was removednucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/client/.gitkeep_empty_dir
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/EmbeddedOSGiGlassFishRuntimeBuilder.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogManagerService.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/InstanceGetLogFileCommand.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/osgi/EmbeddedOSGiGlassFishRuntime.java
The file was removednucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingOutputStream.java
The file was modified nucleus/common/internal-api/src/main/java/org/glassfish/internal/api/LogManager.java
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/core/AMXProxy.java
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/commands/ListJobsCommand.java
The file was removednucleus/core/logging/src/test/java/com/sun/enterprise/server/logging/LogEventListenerTest.java
The file was modified nucleus/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/ConfigBeansUtilities.java
The file was modified nucleus/common/common-util/osgi.bundle
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/remote/RemoteCommand.java
The file was modified nucleus/admin/template/src/main/resources/config/domain.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEventListener.java
The file was modified nucleus/core/kernel/osgi.bundle
The file was modified appserver/concurrent/concurrent-impl/src/main/java/org/glassfish/concurrent/runtime/ContextSetupProviderImpl.java
The file was modified appserver/web/web-glue/pom.xml
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/commands/SetLogFileFormat.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/LogFacade.java
The file was modified nucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/parser/uniform-server.log
The file was modified appserver/tests/appserv-tests/devtests/admin/cli/resources/configs/v3_0_1domain.xml
The file was modified nucleus/core/extra-jre-packages/pom.xml
The file was modified nucleus/test-utils/src/main/java/org/glassfish/tests/utils/junit/HK2JUnit5Extension.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/ParsedLogRecord.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishMain.java
The file was modified appserver/web/web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java
The file was removednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/logviewer/backend/logentry.bin
The file was modified nucleus/distributions/nucleus/src/main/assembly/nucleus-new.xml
The file was addednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/parser/oneline-server.log
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogRotationTimerTask.java
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/logging/Logging.java
The file was modified nucleus/common/amx-core/pom.xml
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/parser/LogParserException.java
The file was modified nucleus/core/logging/pom.xml
The file was modified nucleus/parent/pom.xml
The file was removednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/logviewer/backend/README.txt
The file was removednucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/test/.gitkeep_empty_dir
The file was modified nucleus/common/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean/LoggingImpl.java
The file was modified nucleus/featuresets/atomic/pom.xml
The file was modified nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/AdminRESTConfigUpgrade.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/Syslog.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/ASMain.java
The file was modified nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/remote/RemoteCLICommand.java
The file was modified nucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingConfig.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEventBroadcaster.java
The file was modified nucleus/distributions/atomic/src/main/assembly/atomic.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/GFFileHandler.java
The file was modified nucleus/core/logging/src/test/resources/com/sun/enterprise/server/logging/parser/odl-server.log
The file was modified appserver/admin/cli/pom.xml
The file was addednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/ServerLogFileService.java
The file was modified appserver/distributions/glassfish/src/main/assembly/glassfish.xml
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/FormatterDelegate.java
The file was removednucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/LogEventImpl.java
The file was modified appserver/distributions/web/src/main/assembly/web.xml
The file was modified nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncherLogger.java
The file was modified nucleus/admin/config-api/src/main/java/com/sun/enterprise/config/util/ConfigApiLoggerInfo.java
The file was modified nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncherMain.java
The file was removedappserver/web/web-glue/src/main/java/commons-logging.properties
The file was removednucleus/core/bootstrap/src/main/java/org/glassfish/.gitkeep_empty_dir
The file was modified nucleus/admin/cli/pom.xml
The file was modified nucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingConfigImpl.java
The file was modified nucleus/glassfish-jul-extension/src/test/java/org/glassfish/main/jul/GlassFishLoggerTest.java
The file was modified nucleus/core/logging/src/main/java/com/sun/enterprise/server/logging/logviewer/backend/LogFilter.java
The file was modified nucleus/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/ClassPathBuilder.java
The file was modified nucleus/admin/launcher/pom.xml
The file was modified nucleus/glassfish-jul-extension/src/main/java/org/glassfish/main/jul/GlassFishLogManager.java