Changes

Stabilized LoggingPrintStreamTest

- yield helped a bit, but did not guarantee that all records will be processed
- close guarantees that.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: eaa4b06)

Fixed WebsocketITest TCK test call

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 3cc312c)

Servlet tests include one which requires a mail server

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 5aa589f)

Updated TCK Faces dependency to JEE10

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 819a114)

Added possibility to override settings.xml

- useful on the build server

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 06c6f08)

EjbITest.ejb requires mail server

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: f2f5fb1)

The env._ variable is not present on Jenkins

- but I tried that, at least ;)
- note that this probably cannot work on windows, but TCK tests are already
  unsupported on windows.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: a05ab44)

DOL module vs. technical debt and generics

- I tried to narrow generics in this packages, which made visible some weird
  constructions, maybe from some unfinished former refactoring.
- sometimes I inverted some conditions to make them more readable too, etc.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: e0da2ee)

Fix for issue #23601 - message moved to the code

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 495beda)

Fixed another error message - was in a wrong bundle

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: d67ecc9)

Removed classesChanged method

- unused and in PersistenceDescriptor was using heterogenous collection
 (commit: 9a905ca)

Fixed reflection issue of MimeMappingDescriptor

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 0f1aee1)

Fixed resource leaks in ConnectorUtil

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: bb2e6b1)

TxIsolationLevel enum

- recently we fixed typo in one name, so I created this.
- the package; probably we should create some JDK adapter where we would
  collect JDK enhancements.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 151c571)

Another wave of generics and source cleanups around DOL

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: b9be6ff)

Fixed mistake I did in ResourceContainerContextImpl

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: d1247f3)

Fix for mistake I did in 632a9693aa

- fixed copy and paste, equals instead of == for string
- reduced noise in logs - don't log twice, better set the exception cause.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: e4752ad)

Cleanup in SetMethodAction


Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 71a23f7)

Deprecated methods in Descriptor class, removed unused code

- see issue #24084 , now I just documented the problem.
 (commit: 6444a4c)

Fixed another bug I created in SetMethodAction

- I forgot that I am in a cycle

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: fae5b12)

Further cleanups around DataSourceDefinitionDescriptor

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 27d3388)

DescriptorConstants moved to their classes

- the interface wasn't an interface, just a container of constants.
- all constants were used just on a single place

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 2de560d)

Removed deprecated dead methods from ConnectorDescriptor

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 74360a4)

Fixed io leaks in WebServicesDeployer, updated copying file

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 6ac8d0f)

Refactoring in DOL + consequences

- main target: generic collections, cleanup

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 36a75ce)

Fixed makeClone method

- Previous commit is uncompilable because as I added generics it made visible
  class incompability
- However the method is not used anywhere

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 1801789)

The makeClone removed

- it wasn't used

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: f93b7d9)

Fix for webservice_all tests - the wsdl file can already exist

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: c41f308)

Fixed webservice_all's run_test.sh

- common_test.sh is loaded before the run_test_id call, so it uses correct
  directory even when used runtests.sh

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: a7b0577)

Cleanups around ConfigPropertyNode

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: d6e163f)

Stronger type control - and using descriptor in EjbBundleRuntimeNode

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: bd15ca7)

Cleanups in DOL - generics, visibility, docs

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: e1cd0fe)

Cleanup of scanners

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 87fd0de)

Generics around DeploymentDescriptorFile

- more clear and fixed api: getRootXMLNode's parameter is not <T>, but
  may be another type too.
- deprecation in comments transformed to annotation

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: d4178c2)

Cleanup around AuthMechanism and OutboundResourceAdapter

- constants of PoolManagerConstants dissolved where used OR replaced
  by the same definitions in the Resource API jar.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 4ee062f)

Another cleanup in DOL

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 72b727d)

Removed unused constants

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 762513e)

Another block of cleanups in DOL

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 2e2f15f)

Formatting in scanners

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: ec2685f)

Removed skip-annotation-class-list file

- the exclusions are hard-coded now as they were never overrided (and they
  could not be)

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 27ed3ff)

Reducing complexity of annotation-framework + dol

- removed dead code (part of)
- generics
- formatting
- using correct loggers (apf used global, dol sometimes used apf)
- it will take more iterations, but this state passed ql-all, webservices tests
- I am still quite unhappy as some classes use fields as local variables, even
  fields in injected services with unknown context (to me).

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 21870ec)

Fixed mistake I did in f1e97925bb12495153c426ac4b56fe4d5065c44c in hashCode

- MethodKey represents a method for the annotation's point of view,
- class and package are used just to resolve the visibility of the method.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: b7bef7e)

New useful loggers in logging.properties

- stdout+stderr to add possibility to disable them
- exousia
- reduced level form common and dol to standard levels
 (commit: 09ca418)

Fixed AsadminLoggingITest + added javadoc

- The asadmin command doesn't do what one would expect ...

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: e2592cd)

Improved ejb30 tests

- it is hard to find someting when the code swallows exceptions and doesn't log
- fixed equals - it ignored result

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: d2ba362)

Improved ComponentDefinition

- Moved filter from Factory here as it is not used elsewhere
- Reduced duplicit calls

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 7ed97d9)

Removed unused methods from JavaEEScanner

- btw Parser is a Closeable and it wasn't closed.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 159c72a)

AnnotatedElementHandler is not used anywhere, it is just a redundant iface

- it's only implementor is AnnotationContext, they should become one soon
  to simplify the system
- the method getHandler(Class<H> handlerType) wasn't used anywhere

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 9909f9c)

Second constructor for Role

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: dbec2b0)

RoleMapper - removed unused code

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 63b2f68)

New ScatteredWebArchivist

- evolved from EmbeddedWebArchivist, because that conflicted with generics
  in following commits (used class typing to resolve that, but it is not
  possible now any more).
- EmbeddedDecorator duplicated EmbeddedInhabitantsParser and wasn't used

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 0a95c36)

Finishing AnnotatedElementHandler replacement

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 2d5172b)

Scattered WAR support fixed

- fixes two tests in ejb_group_embedded (Jenkins failure in this branch)
- one test remaining

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 80420f2)

Separated User, Role, Group so it is possible to easily distinguish them

- original code caused weird behavior on some places, avoided by hacks
- some hacks were not removed yet, but they are not conflicting with this change
- separated Principal and PrincipalDescriptor
- PrincipalImpl was deleted, replaced by UserNameAndPassword
- fixed devtests using Principal.toString instead of getName

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
 (commit: 9bdfb03)