Skip to content
Failed

Changes

Summary

  1. Set source/target container figure to null after Zest connection removal (details)
  2. Integrate Zest-based examples into our test suite (details)
Commit f6dc4252e737121d0f4a55cca4014a3050145fb8 by Alois Zoitl
Set source/target container figure to null after Zest connection removal

The local variables should be cleared when the figure is removed, even
if either of the containers has already been disposed.

Amends 2288625a8c910773a4e3076691b39ad3c13a2cc8
The file was modified org.eclipse.zest.core/src/org/eclipse/zest/core/widgets/GraphConnection.java (diff)
Commit d606e6287d69a4183c888bf4147b167c94ebfc83 by Alois Zoitl
Integrate Zest-based examples into our test suite

With this change, we instantiate and verify the correctness of the Zest
examples as part of our JUnit test suite. Special care needs to be
taken, in order to make sure that the examples can be used in the test
environment, but also still be executed as standalone applications.

This means that those snippets must not create a new Display instance,
as one is already created by the test suite and multiple displays are
forbidden. The snippet is then instantiated by reflectively calling the
main method.

Because the snippets block until the shell is closed by the user, a
little trick is needed to allow for the tests to be executed. The actual
test is scheduled as an asynchronous task before the snippet is created,
which is then executed by the call to "Display.readAndDispatch()".

For this exact reason has the FileDialog been removed from
GraphJFaceSnippet3, as this would block the UI thread prematurely, thus
making testing impossible. The example is still functional, as it will
instead load the example file from the classpath.

In almost all cases, the SpringLayoutAlgorithm of the code snippets has
been replaced by a GridLayout, in order to make the test more stable and
reproducible.

This contribution is done in preparation for the Zest 2.0 migration as a
means to increase the test coverage and thus spot any changes that are
introduced.
The file was addedorg.eclipse.zest.tests/src/org/eclipse/zest/tests/examples/GraphJFaceTests.java
The file was modified org.eclipse.zest.examples/META-INF/MANIFEST.MF (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet3.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet4.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/CustomLayout.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet1.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet6.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet8.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/NestedGraphSnippet.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet1.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet11.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet9.java (diff)
The file was modified org.eclipse.zest.examples/.classpath (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet7.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/uml/UMLExample.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet5.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/ZoomSnippet.java (diff)
The file was addedorg.eclipse.zest.tests/src/org/eclipse/zest/tests/examples/AbstractGraphTest.java
The file was modified org.eclipse.zest.tests/src/org/eclipse/zest/tests/ZestTestSuite.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/PaintSnippet.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet8.java (diff)
The file was modified org.eclipse.zest.core/META-INF/MANIFEST.MF (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet13.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet3.java (diff)
The file was modified org.eclipse.zest.tests/META-INF/MANIFEST.MF (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet6.java (diff)
The file was addedorg.eclipse.zest.tests/src/org/eclipse/zest/tests/utils/WidgetVisitor.java
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet12.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/AnimationSnippet.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet5.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet10.java (diff)
The file was addedorg.eclipse.zest.tests/src/org/eclipse/zest/tests/utils/Snippet.java
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/LayoutExample.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet7.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet2.java (diff)
The file was addedorg.eclipse.zest.tests/src/org/eclipse/zest/tests/utils/GraphicalRobot.java
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet4.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/GraphSnippet14.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/HelloWorld.java (diff)
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/swt/NestedGraphSnippet2.java (diff)
The file was addedorg.eclipse.zest.tests/src/org/eclipse/zest/tests/examples/GraphUMLTests.java
The file was modified org.eclipse.zest.examples/src/org/eclipse/zest/examples/jface/GraphJFaceSnippet2.java (diff)
The file was addedorg.eclipse.zest.tests/src/org/eclipse/zest/tests/examples/GraphSWTTests.java