Skip to content

Changes

Summary

  1. Bug 529144 - Renderers do not cache validation color and icon (details)
  2. TCI - removed warning (details)
  3. TCI - removed warnings (details)
  4. Bug 529510 - ECPE4Editor does check whether an ECPProject is present, (details)
  5. Bug 522147 - Reset value for invalid input in NumberControl (details)
  6. Bug 529514 - PreSetValidationServiceImpl should run additional checks (details)
  7. Bug 529402 - ClassCastException in ECPSubstitutionLabelProvider (details)
  8. Bug 529403 - Missing Null checks in Validation Service (details)
  9. Bug 529414 - Checkstyle deprecates FileContensHolder (details)
  10. Bug 529485 - Server uses different CS config than local IDE build (details)
  11. Bug 529485 - Server uses different CS config than local IDE build (details)
  12. TCI - fixed warnings (details)
Commit 227d09ef685b9a99808d4446cfb091c1145f84b6 by Johannes Faltermeier
Bug 529144 - Renderers do not cache validation color and icon

Implement cache and test in AbstactControlSWtRenderer

Change-Id: I8e06e75e7246d6ff654920c645c0a1d8dda1c3f8
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
The file was modified bundles/org.eclipse.emf.ecp.view.template.service/src/org/eclipse/emf/ecp/view/template/service/ViewTemplateProviderImpl.java
The file was modified bundles/org.eclipse.emf.ecp.edit.swt/src/org/eclipse/emf/ecp/edit/spi/swt/util/SWTValidationHelper.java
The file was modified bundles/org.eclipse.emf.ecp.view.core.swt/src/org/eclipse/emf/ecp/view/spi/core/swt/AbstractControlSWTRenderer.java
The file was modified tests/org.eclipse.emf.ecp.view.core.swt.tests/AllPluginTests core.swt.launch
The file was modified tests/org.eclipse.emf.ecp.view.template.service.test/src/org/eclipse/emf/ecp/view/template/service/ViewTemplateService_Test.java
The file was modified bundles/org.eclipse.emf.ecp.view.template.model/src/org/eclipse/emf/ecp/view/template/model/VTViewTemplateProvider.java
The file was modified tests/org.eclipse.emf.ecp.view.core.swt.tests/src/org/eclipse/emf/ecp/view/spi/core/swt/AbstractControlSWTRenderer_PTest.java
The file was modified tests/org.eclipse.emf.ecp.view.template.service.test/All Integration Tests for ecp.view.template.service.launch
Commit fb82b9fda08fa5ffebcd879828b894af18ca23c7 by Jonas Helming
TCI - removed warning

Removed unneccessary suppress

Change-Id: I88d9bb3bc706a4d09cbf6256401237f31f7d9069
The file was modified bundles/org.eclipse.emfforms.swt.table/src/org/eclipse/emfforms/spi/swt/table/DefaultTableViewerColumnBuilder.java
Commit db16d169bc439520101b434640878e533b317b6c by Jonas Helming
TCI - removed warnings

Added version info to package imports and exports

Change-Id: Ibb45ff2175e0d683cd73ecf1d03a3bfdc4381b57
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
The file was modified tests/org.eclipse.emfforms.swt.common.test/META-INF/MANIFEST.MF
Commit fbdfc977fdf8bbe393580e52b50587471d93bdf4 by Jonas Helming
Bug 529510 - ECPE4Editor does check whether an ECPProject is present,
although it does not really need one

Change-Id: I9fd509e8f0fc652155cd380363318d01705102c8
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
The file was modified bundles/org.eclipse.emf.ecp.ui.e4/src/org/eclipse/emf/ecp/ui/e4/editor/ECPE4Editor.java
Commit ea8f7a60f5c827c3b364a6ba9078b43bc33a637f by Lucas Koehler
Bug 522147 - Reset value for invalid input in NumberControl

* Fixed by only using a PreSetValidationStrategy if a
PreSetValidationService exists
* Improved ViewModelContextImpl#hasService to actually reflect what
#getService would return
* Test for the number control renderer that tests the invalid input
behavior
* removed presetvalidation bundle dependency from core.swt.tests
* moved test cases to AllPluginTests.java because they fail as normal
unit tests (makes no difference for Hudson)
* The dispose test's VMC returns no PreSetValidationService for now.


Change-Id: I636432d6b89881a4102115318c5c9d4a4c8e5465
Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
The file was modified tests/org.eclipse.emf.ecp.view.core.swt.tests/META-INF/MANIFEST.MF
The file was modified tests/org.eclipse.emf.ecp.view.core.swt.tests/src/org/eclipse/emf/ecp/view/core/swt/tests/AllPluginTests.java
The file was modified tests/org.eclipse.emf.ecp.view.core.swt.tests/src/org/eclipse/emf/ecp/view/core/swt/tests/CorrectDipose_PTest.java
The file was modified bundles/org.eclipse.emf.ecp.view.core.swt/src/org/eclipse/emf/ecp/view/spi/core/swt/SimpleControlSWTControlSWTRenderer.java
The file was modified bundles/org.eclipse.emf.ecp.view.context/src/org/eclipse/emf/ecp/view/internal/context/ViewModelContextImpl.java
The file was modified tests/org.eclipse.emf.ecp.view.core.swt.tests/AllPluginTests core.swt.launch
The file was modified tests/org.eclipse.emf.ecp.view.core.swt.tests/src/org/eclipse/emf/ecp/view/internal/core/swt/renderer/NumberControlRenderer_PTest.java
Commit c69dcd5bde575276e988752548067880008bd693 by Jonas Helming
Bug 529514 - PreSetValidationServiceImpl should run additional checks
for Enum features as well

* Skip validator instead of immediate return to run additional
constraints as well
* Add test which asserts that additional contraints are called for enum

Change-Id: I1a73528bbabea3dcdca07e427607de94cd9e797c
Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
The file was modified tests/org.eclipse.emf.ecp.view.validation.test/src/org/eclipse/emf/ecp/view/validation/test/PreSetValidationService_Test.java
The file was modified bundles/org.eclipse.emfforms.common.prevalidation/src/org/eclipse/emfforms/internal/common/prevalidation/PreSetValidationServiceImpl.java
Commit 4254206025d1bc4e16caac553d392a6252c8a6e5 by Johannes Faltermeier
Bug 529402 - ClassCastException in ECPSubstitutionLabelProvider

AdapterFactory.adapt may sometimes not return a class that is
compatible with IItemLabelProvider, as for example when ecore model
element has EObject as super type.

Change-Id: I51c0b570b3995bbcce9d0b6ef01c1e9fdf3df653
Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com> [Test case]
The file was modified tests/org.eclipse.emf.ecp.view.validation.test/src/org/eclipse/emf/ecp/view/validation/test/SubstitutionLabel_PTest.java
The file was modified bundles/org.eclipse.emf.ecp.view.validation/src/org/eclipse/emf/ecp/view/internal/validation/ECPSubstitutionLabelProvider.java
Commit 5aca7575b1548bb6b3534cda2ca61615b28e3581 by Johannes Faltermeier
Bug 529403 - Missing Null checks in Validation Service

Avoid adding null elements to a ConcurrentLinkedQueue

Change-Id: I37bd429e2c9914c9f4608efd78d2a730c4c32ec6
Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com> [Test case]
The file was modified tests/org.eclipse.emf.ecp.view.validation.test/src/org/eclipse/emf/ecp/view/validation/test/ValidationService_PTest.java
The file was modified bundles/org.eclipse.emf.ecp.view.validation/src/org/eclipse/emf/ecp/view/internal/validation/ValidationServiceImpl.java
The file was modified tests/org.eclipse.emf.ecp.view.validation.test/META-INF/MANIFEST.MF
Commit c6c73cc1d221c7c9b9ca5119dd3eba63418bb465 by Eugen Neufeld
Bug 529414 - Checkstyle deprecates FileContensHolder

updated checkstyle config. removed absolute configs for some bundles to
relative config.

Change-Id: I8790b3e433e121dfdd9f31f8d47e513f145385cc
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
The file was modified releng/org.eclipse.emf.ecp.releng/checkstyle/esmCheckstyle.xml
The file was modified bundles/org.eclipse.emfforms.swt.treemasterdetail.decorator.validation.default/.checkstyle
The file was modified releng/org.eclipse.emf.ecp.releng/checkstyle/esmCheckstyleTest.xml
The file was modified bundles/org.eclipse.emfforms.editor/.checkstyle
The file was modified bundles/org.eclipse.emfforms.editor.ecore/.checkstyle
The file was modified bundles/org.eclipse.emfforms.editor.viewmodel/.checkstyle
The file was modified bundles/org.eclipse.emfforms.swt.treemasterdetail/.checkstyle
Commit 118a47a8d05f485ef8fd65460752f8feb64a219d by Jonas Helming
Bug 529485 - Server uses different CS config than local IDE build

referenced local CS file an removed reference to suppressions

Change-Id: I89f18e602bdb06e6934269bf309d015fc79f68ec
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
The file was modified releng/spreadsheet/org.eclipse.emfforms.spreadsheet.releng.tests/pom.xml
The file was modified releng/spreadsheet/org.eclipse.emfforms.spreadsheet.releng/pom.xml
The file was modified releng/org.eclipse.emf.ecp.releng/pom.xml
The file was modified releng/org.eclipse.emf.ecp.releng.tests/pom.xml
Commit 04adac03e92f1564347ed1a77a80b6d2e5ae3d60 by Jonas Helming
Bug 529485 - Server uses different CS config than local IDE build

adapted MiH CS

Change-Id: Ief9e136ac2c8561269d6a5c8c071743dec38a1dc
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
The file was modified examples/org.eclipse.emf.ecp.makeithappen.model/checkstyle/esmCheckstyle.xml
Commit cac62305e0118ec4cf1e5d79f249f77a4f0a1545 by Jonas Helming
TCI - fixed warnings

Fixed header to comply with CS. moved "REUSED CLASS" tag due to new
check style version. Suppression does not affect header check anymore.

Change-Id: Ia6a2189d3ace0f5f788da35a9d274624485e6691
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
The file was modified bundles/org.eclipse.emfforms.swt.treemasterdetail/src/org/eclipse/emf/edit/ui/action/emfforms/StaticSelectionCommandAction.java
The file was modified bundles/org.eclipse.emfforms.swt.treemasterdetail/src/org/eclipse/emfforms/spi/swt/treemasterdetail/util/CreateChildAction.java
The file was modified bundles/org.eclipse.emf.ecp.view.treemasterdetail.ui.swt/src/org/eclipse/emf/edit/ui/action/ecp/StaticSelectionCommandAction.java