Changes

Version change from 3.0.3-SNAPSHOT to 3.0.4-SNAPSHOT

First commit to prepare new version after 3.0.3 (final) release.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: d20db39)

Minor messaging improvements (#1674)

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
 (commit: 294c8ce)

PrintInnerJoinInWhereClause as query hint - backport from master (#1682)

This change extend usage of `PrintInnerJoinInWhereClause` from current persistence unit property into query hint like

```
@NamedQuery(
    name="QueryOrder.findAllOrdersWithEmptyOrderLinesHintFalse",
    query="SELECT o FROM QueryOrder o WHERE o.queryOrderLines IS EMPTY",
    hints={@QueryHint(name=QueryHints.PRINT_INNER_JOIN_IN_WHERE_CLAUSE, value="false")})
```

or
```
String jpql = "SELECT o FROM QueryOrder o WHERE o.queryOrderLines IS EMPTY";
Query query = em.createQuery(jpql, QueryOrder.class);
query.setHint(QueryHints.PRINT_INNER_JOIN_IN_WHERE_CLAUSE, "false");
```

It allows developers more preciously target (optimize) this property to the selected queries.
Fixes #1522.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 0e90769)

Issue 1711: ClassCastException while updating foreignkeys with identity generation

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
 (commit: f7e045a)

Bugfix for: Specifying QName in XmlVariableNode results namespace written twice (#1718)

Bugfix for: Specifying QName in XmlVariableNode results namespace written twice
Fix + unit test.
Fixes #1709

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 0d54d41)

remove the noisy entries from the logs - backport from the master (#1748)


Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
(cherry picked from commit e2da068a260cb9bf9afeaf5df23fb7ace188cdcb)

GitHub Actions change JDK to Adopt JDK distribution due a issue with javadoc

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 099442d)

Documents conversion to Asciidoc format (#1753)

Purpose of this PR is to make current documentation available at https://www.eclipse.org/eclipselink/documentation/ (section Guides) more flexible and easier to modify.
Each guide is published there under separate maven module under `org.eclipse.persistence.documentation` which is new documentation parent.
Main advantages of Asciidoc format are:
- easy modifications
- style is separated from the content
- various output formats available

Each guide is located under `<maven_module>/src/docs/asciidoc` which is default source directory for `asciidoctor-maven-plugin`. Expected main/entry document file name to each guide is `main.adoc` file. `main.adoc` contains common attributes and contains a lot of includes. All included images are in PNG format as GIFs are not accepted in case of PDF output.
Current configuration generates HTML (Web), PDF (Printable), EPUB (e-book) outputs.

Documentation guides are not build by default, but under `doc` Maven profile. See:
`mvn clean package -rf :org.eclipse.persistence.documentation -P docs`

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 7f7f76b)

Issue 1755: Add support for non-breaking spaces

Signed-off-by: William Dazey <wadazey@us.ibm.com>
 (commit: bd4d995)

Fix Javadoc errors

Signed-off-by: William Dazey <wadazey@us.ibm.com>
 (commit: 16ab37c)

Class read fallback needs to reread the stream from the beginning (#1766) (#1767)

Backport from master

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
(cherry picked from commit 9fd3f9c51a7a121b02abaa549a7eb19af446d16e)
 (commit: b58dc42)

Class read fallback needs to reread the stream from the beginning - build fix (#1769)

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 61661a0)

Fix ConcurrentModificationException in BatchFetchPolicy - backport from 2.7 (#1708)

Fixes #1506 . This change will fix the ConcurrentModificationException of the attributeExpression list, when running the same (batch)query with different entity managers.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: e7971e4)

Diagnostic new feature - corrupted cache (backport from master) (#1785)

This is new diagnostic feature which could help developers to analyze inconsistent query results. Inconsistent means, that there is mix of managed and detached entities in the query result by logical error in their code. It should happens if JPA L2 caching is enabled.
E.g. let's have following code:

em.remove(branchBDiagnostic);
commitTransaction(em);
//branchBDiagnostic is in Detached state
...
em.getTransaction().begin();
branchADiagnostic.getBranchBs().add(branchBDiagnostic);
branchBDiagnostic.setBranchA(branchADiagnostic);
//Detached entity (branchBDiagnostic) is not persisted again - logical error
commitTransaction(em);

//This em.find() will resolve objects from cache
BranchADiagnostic branchADiagnosticFindResult = em.find(BranchADiagnostic.class, BRANCHA_ID);
...

if cache validation is enabled by
persistence unit property
<property name="eclipselink.query-results-cache.validation" value="true"/>
or by query hint
query.setHint("eclipselink.query-results-cache.validation", true);
EclipseLink will print into log output messages like

[EL Warning]: cache: 2022-12-07 14:26:50.86--UnitOfWork(1211586911)--stack of visited objects that refer to the corrupt object: [BranchADiagnostic{id=1}]
[EL Warning]: cache: 2022-12-07 14:26:50.86--UnitOfWork(1211586911)--corrupt object referenced through mapping: org.eclipse.persistence.mappings.OneToManyMapping[branchBs]
[EL Warning]: cache: 2022-12-07 14:26:50.86--UnitOfWork(1211586911)--corrupt object: BranchBDiagnostic{id=11}

Note: <Entity>.toString() method is used.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: daee815)

GitHub Actions fix for Javadoc generation (#1796)


Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 23fe71f)

Issue 1779: Add DB2zOS support for UNICODE Timestamps

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
 (commit: 633f401)

Add Oracle21c support (#1824)

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
 (commit: 430c97e)

Issue 1827: Add java.time support for DB2 schema generation (#1829)

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
 (commit: a4d3d5d)

Persistence weaver logging (remove useless log message)  (#1838)

* Remove useless log message during a veawing (#1837)

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
(cherry picked from commit 1092bbf6034f88c7e32a41d0f6e07e6e32d66c16)

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 4c963f7)

Issue 1540: Improve Oracle platform java time support (#1836)

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
 (commit: 3c625c6)

Issue 1544: Derby mapping of LocalTime should map to TIME type (#1833)

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
 (commit: bffaaaf)

Issue 1735: Improve DB2 ZOS support for LIKE ESCAPE (#1788)

Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
 (commit: 036d372)

ASM version switch to 9.5 to be ready for JDK 21. (#1858)

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: fc4f178)

fix #1596 Major performance issue in case of many new entities (#1843) (#1863)

* Issue 1596: use a hash-based collection to lookup objects in the cache instead of a linear search
* Adjusted source according to review:
- extended tests
- updated copyright year
- call removeObjectFromPrimaryKeyToNewObjects in preMergeChanges
- remove list from primaryKeyToNewObjects if it is empty
- simplify tests


(cherry picked from commit 76d82744b14f9a3ad11c1a5215542955b43bea1a)

Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com>
Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
Co-authored-by: Patrick Schmitt <13404745+zuplyx@users.noreply.github.com>
 (commit: edb84b9)

Oracle DDL Parser dependency update 3.0.0 -> 3.0.1 (#1868)

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: ca12e9f)

SDO potential memory leak fix 2.0 (#1869)

This change solve potential memory leak if SDO component is used in JEE environment.
There is refactor of SDOHelperContext.helperContexts map content (nested map). Instead of current ConcurrentHashMap is CacheIdentityMap used which supports Least Recently Used (LRU) strategy. This one should be controlled by new SDO system property eclipselink.sdo.helper.contexts.max.size.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: f773207)

Bugfix for - Missing error message when calling JpaHelper.getReportQuery() with wrong argument (#1911) (#1913)

Fixes #1893

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
(cherry picked from commit 6d59a82a5b2be5b7e5403a95ce436b071fa744ad)
 (commit: 3c9f7df)

Javadoc fix: remove wrong comments for the locate function (#1945)

 (commit: f654304)

ASM version upgrade to 9.6 (JDK 22 ready) - backport from master (#1965)

JPA WDF test fix

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: 813a6a9)

Eclipselink.jar - add JPMS descriptor (module-info.java) (#1972)

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
 (commit: d32bad7)