Changes

Connection type 'Hono' introduced

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

HonoConfig introduced to provide properties for the new Hono-connection type

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

DefaultHonoConfig and conf files update

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Config values added

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Redundant file removed

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

HonoCredentials taken from static configuration

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Config refactored

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Config refactored

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Connection "enrichment"

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

CR-11462 Add HonoValidator impl and Junit tests

Connection "enrichment"

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Fixed HonoValidator merge issues

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Hono-connection enrichment fixed

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

ConfigValues renamed to HonoConfigValue, minor fixes

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Review issues fixes, unit tests fixed

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Review issues fixes, unit tests fixed

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

DefaultHonoConfig class moved from api to service, URI init fixed

Minor refactoring of ConfigWithFallback.
* Extracted method for getting a JsonObject as a Map to improve readability.
* Also use new features of Java 17 to improve readability.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Streamline behaviour of DefaultScopedConfig in case of an unknown enum value.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Refactored HonoConfig.
* Moved interface from connectivity API to connectivity service to limit its scope.
* Moved utility method for getting URI from HonoConfig to implementing class because it is the only place where it is required now.
* Changed getter for bootstrap server URIs to actually return a set of URIs instead of a comma separated string.
* Renamed getter for credentials to state which type of credentials it returns in case there would be other credential types in future.
* Let DefaultHonoConfig base on ScopedConfig to get DittoConfigErrors in case of configuration errors.
* Added unit tests for DefaultHonoConfig.
* Refined some Javadoc comments.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Connection enrichment refactored, HonoConfig cleaned up.

Connection enrichment extracted in a new class DefaultHonoConnectionFactory
HonoConfig cleaned up from the method getTenantId() and the parameter of getCredentials()
HonoConfig simplified - extension mechanism removed.

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Refactored `HonoAddressAlias` and added unit tests.
* Renamed method `getName` to `getAliasValue` to distinct it more clearly from an enum's inherent `name` method.
* Converted methods for resolving addresses from static methods to instance methods. This makes them less error-prone because the alias value does not have to be provided. Furthermore, got rid of the boolean parameter in favour of a more expressive method name.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Refactored `HonoValidator` and adjusted unit tests.
* Applied clean code principles to `HonoValidator` to improve its readability.
* Made existing unit tests more comprehensive.
* Added some unit test cases.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Unit tests created

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Fixed compilation errors of `HonoConnectionFactoryTest`.
`HonoAddressAlias` was refactored beforehand which caused the compilation errors.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Cleaned up `HonoConfig`.

* Removed unused method `getUri`.
* Do not extend `Extension` because it really does not.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Refactored `HonoConnectionFactory`.

* Made the factory more abstract by bringing in more aspects of the template method pattern.
* Moved dependency to `HonoConfig` and some implementation to default implementation.
* Concept of tenant ID is unknown to Ditto, thus removed it.
* Moved methods for resolving addresses from `HonoAddressAlias` to `HonoConnectionFactory`.
* Extended exception handling of `ConnectionPersistenceActor#startAndAskClientActors` to catch failures related to `HonoConnectionFactory`.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Reordered import.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Further simplified `HonoAddressAlias`.

* Removed method `aliasValues` from `HonoAddressAlias` as it was only used in tests.
* Removed method `forAliasValue` from `HonoAddressAlias` because it was only used in `HonoConnectionFactory`.
* Adjusted `HonoAddressAliasTest` accordingly.
* Added mapping from Hono address alias values to `HonoAddress` to `HonoConnectionFactory`.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Fixed unit test.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Moved back method for getting `HonoAddressAlias` by alias value to the enum itself.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

Made `HonoConnectionFactory` a `DittoExtensionPoint`.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>

initial commit of "Policy imports" functionality after Ditto 3.0 refactoring - preserved via former PoCs and contributions on that topic

Co-authored-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
Co-authored-by: Dirk Van Haerenborgh <dirk.vanhaerenborgh@aloxy.io>
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>

newInstance() method added to UserPasswordCredentials class

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

replyTargetEnabled bug in ImmutableSource fixed

Custom `headerMappings` and custom `groupId` in `specificConfig` allowed.
Messaging credentials embedded in URI.
`originalAddress` resolved too.

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

groupId handling changed

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Replace importable flag of a policy entry with ImportableType enum to allow more differentiated options (implicit, explicit, never). Simplify included/excluded notation from policy imports and expect only a list of (included) policy entries. Adapt PolicyImporter accordingly.

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Some polishing, method names, comments, etc. Added more tests to PolicyImporterTest.

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

fix test by adding some more subjects to increase size of policy entry (the limits changed a bit after recent modifications)

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

use default value for importable type defined in ImmutablePolicyEntry

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Resolve imports when creating the PolicyEnforcer

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

rename Policy.getImports() to Policy.getPolicyImports to be consistent with other methods

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

fix check for existence of policy import in DeletePolicyImportStrategy

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

fix compile error

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

fix failing unittests

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

add missing DeletePolicyImportStrategyTest

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

invalidate policy enforcer cache of policies that import a changed policy

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

Ensure that a policy tag is published when the imports of a policy change

* This change indicates a semantic change of the policy and should lead
  to cache invalidation

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

change Policy.getPolicyImports() to not return an optional of PolicyImports but instead default to an empty PolicyImports instance if no imports are defined and always return a non-null instance

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

adapt to previous changes of policy model

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Fix resolving of imported policies in PolicyEnforcerActor

* TODO: think about making PolicyEnforcerProvider and PolicyCacheLoader
  an akka extension in order to make it a singleton

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

Make PolicyCacheLoader an Extension and therefore a singleton

* Only exception is the search, where the cache loader is instantiated
  differently

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

Stabilized unittest

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

Fix failing unittest which didn't expect empty imports by default

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

remove wrong @Nullable annotation

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

implement pre-enforcer to enforce read access on imported policies

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Use fully resolved policy (including imports) when building write models
for the search index

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

Invalidate search index for thing when a policy imported by the thing policy changes

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

load PolicyEnforcerProvider using an extension

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

add basic logging to PolicyImportsPreEnforcer

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

ignore order of referenced policy tags

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

enforce read access on all policy entries that are imported implicitly

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

small fixes and improvements of error handling related to policy imports

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Fixed multiple issues regarding imported policies in the search index

* The query in MongoThingsSearchUpdaterPersistence wasn't correct because
  the "id" field was extracted from the JSON pointer which appended a leading
  slash
* We need to remember deleted but still imported policies otherwise the
  search index is not updated when the imported policy is recreated
* Imported policies need to be taken into account when checking if a
  write model is outdated
* The Metadata built by the ThingUpdater needs to preserve the thingPolicy
  aswell as the referenced policy tags

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

add policy imports documentation to openapi

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

make policy import resolving asynchronous

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

optimize policy enforcer cache invalidation

* Maintain a map from imported policies to their importing policies which allows
  to avoid iterating over the full cache content when invalidating the policy cache

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

optimize map building

* Map is now only modified when the policy is loaded from the cache loader
  instead of every access of the cache
* Also fix issue that the map was never "cleaned up" which is now happening
  on invalidation

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

Consider change of importable type as semantical change

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

remove unused code in LabelInvalidException

Signed-off-by: Yannic Buergmann <yannic.buergmann@bosch.io>

throw PolicyImportInvalidException if policy import references own policy, consolidate/simplify policy size validation in policy strategies

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

fix failing tests

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Hono-credentials added to connectivity-extension.conf

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

retrieveHonoConnection piggyback command introduced.

A new piggyback command 'retrieveHonoConnection' is implemented which retrieves a 'real' connection of type 'Hono' (with already resolved address aliases, added header mappings , specificConfig etc.)

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Automatic reconnect of 'hono' connection after credentials are changed.

On Hub-credentials changes, ConnectionSupervisorActor gets notified by SolutionModifiedActor in order to restart the potentially active 'Hono'-connection with the new parameters.

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Copyright headers fixes

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

check also for self reference in policy modify commands

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

improve logging

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Javadoc improved.

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

some fixes after merge

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Integrate Hono connection in ditto ConnectionRoute

validate policy on modification and check whether the policy or an imported entry allows WRITE on policy root resource

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

do not fallback to ImportableType implicit if given type is not valid but return an error instead (default is still implicit, if value is not provided)

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

Revert "validate policy on modification and check whether the policy or an imported entry allows WRITE on policy root resource"

This reverts commit 92f7ac587379516ad69c5998bbc46880cedbc667.

Hono-connection resolving added for TestConnection (dry-run)

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

HubParamsModified renamed to HubInstanceInfoModified, few logs added

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

fix timing issues for LiveSignalEnforcementTest

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

fix compilation after merging master

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

CR-11683 Bug fixed in handling of 'Event'

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

document policy imports and extend ditto protocol specification

Co-authored-by: Kalin Kostashki <kalin.kostashki@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>

added limit for maximum number of policies to be imported

 - created a custom PolicyImportsTooLargeException in order to facilitate sending of correct error response to user
 - small typos and fixes as needed
 - made the policy imports limit configurable in ditto-limits.conf

Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.io>

Review issues fixes.

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Automatic reconnect fixed to filter hono-connections only

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>

Auto-reconnect review issues fixed.

Signed-off-by: Andrey Balarev <andrey.balarev@bosch.io>