Changes

Make Select Configurations Dialog resizable

Fixes #240

Bug 552070 - Build not configured correctly error while building a project

https://bugs.eclipse.org/bugs/show_bug.cgi?id=552070

After closing and opening a Core Build project (Make, CMake,
Autotools, and Meson), the project could not be built for Debug
anymore. Error: "Build not configured correctly".

Restoration of the debug build configurations failed, because the
settings had been removed during closure of the project.
CBuildConfiguration(IBuildConfiguration config, String name)
failed with a CoreException. The CBuildConfigurationManager
silently catched the exception and put the IBuildConfiguration for
debug in the noConfigs list.

Fix pack expansion for array elements

When parameter pack contains array type the EvalCompositeAccess.getType() will
attempt to return type of array element.

Fix this by providing EvalPackAccess which returns pack elements as is.

Fix copyright header typo

Add basic support for c++20 three-way comparison operator

Replace useGNUExtensions flag in test code with scanner configuration id

Add STD and GNU scanner configuration ids and pass these as needed instead of
boolean flag useGNUExtensions. This will be used later by C++20 scanner tests.

Add test for c++20 three-way comparison expression

Add rewriter test for c++20 three-way comparison expression

Add variable read/write flag test for c++20 three-way comparison

Add operator name test for c++20 three-way comparison

Fix precedence for c++20 three-way comparison operator

Add and correct since tags for new API in 8.1.0

o.e.cdt.core 8.0.0 was released as part of CDT 11, so this new
non-breaking API needs a version bump to 8.1.0.

Add simple evaluation for c++20 three-way comparison 

Drop three-way comparison from C parser, this is C++ only.

Do not allow structured binding initializer referencing introduced name (#241)

If name lookup ends up with a variable, additionally check if node being
resolved is part of the structured binding initializer introducing found
variable. If this is the case, produce problem binding and report structured
binding declaration error via codan.

This change also prevents infinite recursion trying to resolve auto type of
introduced variable while evaluating such problematic initializer.

Re-read the makefile targets when a project becomes eligible

Without this change when the project is not a "hasTargetBuilder" then
the projectMap will contain an entry mapping the project to
an empty set of makefile targets. So when we get a project added,
make sure to re-read the target settings by clearing the cached
versions.

Fixes #244

Issue #254: Constructors of inner classes not resolved properly

- add test case to reproduce #254
- add special case to detect constructors which were declared in the
index file set of the tu

Remove unneeded escapes in markdown

Handle case where AST name has no location

In cases where an IASTName has no image location we were getting
NPEs in this code. See javadoc for getImageLocation for cases
when image location can be null. See #251's description for a
full case of when this can happen.

All other calls to IASTName.getImageLocation in CDT were also checked
and this was the only place in the code where the return value
was not checked for null.

Fixes #251

Document an internal method to make it easier for the next editor

While working on #251 I had to understand what this code did,
I include the method javadoc in the hope it saves the next person
who touches this code some time.

Prepare o.e.cdt.debug.ui for CDT 11.1.0 development

Extract macro argument location

The previous commit in this series addresses the NPE that
can be hit. This code covers the case of the OP in #251
to actually find the correct expression to pass to GDB.

Improvement to #251

Update to 2023-03 M2 requirements

Remove field in test

The field implies that the fSourceViewer has a longer life
than it does. But reality is that the viewer is only
valid until the editor gets reopened while the test is
running.

Provide a base UI test case for JUnit5

This is the analogous class to BaseUITestCase, but for JUnit5.

Convert test to JUnit5

This is a pre-requisite to be able to use flaky test tag

Mark DocCommentHighlightingTest as flaky

This test regularly fails on CI builds, but the test passes ok.

Fixes #259

Add definitions for integer overflow builtins from GCC

Closes #271

Fix arithmetic conversion from larger unsigned operand type

Fixes: 16944a0de7 ("Arithmetic conversions for unary and binary expressions, bug 231859.")
Closes: https://github.com/eclipse-cdt/cdt/issues/265

Test arithmetic conversion from larger unsigned operand type

Make sure AST is available to C getExpressionType too

C++ parser methods already store current lookup point which makes AST available
via thread-local variable. Do the same for C parser to enable SizeofCalculator
accessing type size macros via AST while processing C code.

Prevent CME in LaunchBarManager

This change synchronizes access to LaunchBarManager.descriptors, to
avoid a ConcurrentModificationException when adding descriptors for 2
launches at the same time.

Fixes: #262

Clean up for synchronization of LaunchBarManager.descriptors

This change makes LaunchBarManager.descriptors a synchronized map,
slightly reducing the extra code and complexity added for #262.

Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>

Add c++17 fold expression

Fix rebase error for pr #234 - C++ Fold Expressions

PR #234 had a compilation error once it was rebased which
wasn't identified until after it was rebased and merged
to main causing build to fail.

This PR is to fix that rebase error.

Fix missing plugin.properties

Fix incorrect since tags

Apply truncation and sign-extension to result of initializer evaluation

Actually apply type conversion in CPPEvaluation maybeApplyConversion()

Currently type of parameters of instantiated template function is ignored while
preparing activation record, which makes constexpr evaluation of instantiated
body use types of arguments in function call expression instead:

    template<typename T> bool f(T t) { return t > 0; }
    t<unsigned int>(-1); // CDT returns false because conversion is not done

Fix this by applying EvalTypeId to argument if cost of standard conversions is
Rank.CONVERSION to make sure createActivationRecord() would populate activation
record with argument values matching template parameter types.

Fix type conversion in unary and binary expression evaluations.

Add another integer conversion test for issue 265

Bug: https://github.com/eclipse-cdt/cdt/issues/265

More tests for c++17 fold expression

c++17 simplify fold expression parser and fix cast-expression on sides

Simplify parser by deferring fold-expression op token check until complete
expression can be examined.

Binary expression builder already produces a chain of BInaryOperator with
cast-expression objects. Use that to restrict valid fold-expression sequence
to the one containing only cast-expression on sides.

Fix codan return value check with typedef return and template function

New API to custom parse #define lines from GCC during scanning

Option to override the matching of macro defines for the Core Build
GCC toolchain. This may be needed for custom compilers.

Also-by: Jonah Graham <jonah@kichwacoders.com>

[releng] Update to snapshots of LSP4E and TM4E

[releng] Make it easier to run cleanup scripts out of tree

Add .clangd file to simplify project sharing with non-CDT

In the example CMake project add a .clangd to enable pointing
clangd at the appropriate compilation database without having
to make a copy of it.

[releng] 2023-03 M3 dependencies

Add more C++ builtins

Add __has_unique_object_representations
    __is_aggregate
    __is_assignable
    __is_nothrow_assignable
    __is_nothrow_constructible

Fix typo in testTemplateIDAmbiguity_341747a testing 3rd expression

Add null check for Disassembly view source

Disassembly view is expected to be populated with lines that are fetched from a given source file. There might be the case where instructions on what lines to append are wrong. This results in a null response that will propagate through the code leading to a NPE.

The current commit is proofing the code from NPE by:
- removing the source position of the lines that were not found within the given file
- null checking the source before becoming a key element in the code flow
- adding logging if expected lines are not found in the given file

Resolves: #287

Test for binary expression with variable template args, bug 497931

Includes test case from comment 8 of bug 497931 with minor correction
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=497931

Recognize more unary expression operators that may end template-id

Scan for more template-id alternatives in expression, bug 497931

If parsing expression part for an alternative terminates with BacktrackException,
selectFallback() would short-circuit to the longest remaining variant. If that
happens to successfully complete parsing till the end of expression token
sequence, all of remaining variants are discarded, including the first found
alternative which was to parse identifier as template name.

This causes expression() to only consider one branchpoint out of all possible
variants. Allow it to find more variants by scanning through all branchpoints
looking for the alternative with leftmost parsed boundary.

This is probably still not ideal but fixes this common std library construct:

  template <typename T>
  inline constexpr bool X = true;
  template <typename T>
  inline constexpr bool Y = true;

  template<typename T> bool predicate() {
    return X<T> && Y<T>; // CDT finds this one: (X) < (T) > (&&Y<T>)
                         // Fix it to also consider (X<T>) && (Y<T>)
  }

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=497931

[releng] 2023-03 RC1 dependencies

Run workflows on CDT 11.1 branch

Fix maven at 3.8.7

Until we update Tycho to 3.0.3+ we use the older Maven

Thanks to @ghentschke for figuring this out in
https://github.com/Bachmann-electronic-GmbH/eclipse-cdt-lsp/commit/f7761791be51f27fcc364e14b3f0eafff9a6235b

Fixes #308

[releng] Prepare repo for CDT 11.2 development

Part of #320

Update versions of maven plugins

Part of #320

Update copyright year on all features

Part of #320

Bump bundle versions changed due to new Tycho

When we update Tycho we pull in a new version of ECJ which means
we can get some differences in the class files even though
there is no difference in the source. This commit bumps
all the bundles that are affected by this.

This is kept as a separate commit from the Tycho update
because if we need to revert the Tycho update we would still
need to bump all these bundles to make jgit timestamp qualifier
happy.

Part of #320
See also #308

Upgrade to Tycho 3.0.3 (latest)

Part of #320
See also #308

CDT 11.1 p2 composites on download.eclipse.org

Part of #202