SuccessChanges

Summary

  1. tmf.ui: Callstack the entry selection done only on the first match. (details)
  2. doc: add and update documentation for latency views (details)
  3. timing: Bug 500592: fix symbols for with debug info of Lttng 2.8 (details)
  4. doc: update doc with OS Overview Perspective. (details)
  5. lttng.ust: Do not skip unknown lines in addr2line output (details)
  6. lttng.ust: Do not block in UstDebugInfoAnalysisModule (details)
  7. doc: Add developer documentation for JUL logging (details)
  8. tmf: SWTBot integration tests for Project Explorer trace folders (details)
  9. lami.chart: use formatter on x axis for continuous data type (details)
  10. SegStore: fix iterator caching in segment store. (details)
  11. doc: update screenshot for system call latency statistics (details)
Commit e92f8db18967327f34a19693f4fe5fdd7d997df0 by Matthew Khouzam
tmf.ui: Callstack the entry selection done only on the first match.

Fixes issue which caused many requests to be queued before
the sync operation is completed.

Bug: 500615
Change-Id: I563e37a2fb6c0a1cd1b93c801257d43d4ce03c38
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80177
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
(cherry picked from commit ec19e9090d14648b412211b9fecd6db01d91607c)
Reviewed-on: https://git.eclipse.org/r/80503
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/callstack/CallStackView.java
Commit 84fc8ad9a2ddc54a604a23280487e7d74a8b28ff by Bernd Hufmann
doc: add and update documentation for latency views

This includes function density view, syscall views and latency views

Change-Id: Ie9207501e0c04681ef6be01cf29839362aaea35a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80326
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
(cherry picked from commit cbcddd0b3cd69e52152582b4c55b5a69b8ba99d7)
Reviewed-on: https://git.eclipse.org/r/80501
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/FunctionDensityView.png
The file was addeddoc/org.eclipse.tracecompass.doc.dev/doc/images/zoomout_nav.gif
The file was modifieddoc/org.eclipse.tracecompass.doc.user/doc/User-Guide.mediawiki
Commit e474bc24b8092e024522c7ea7c1da9a5b57e7433 by Bernd Hufmann
timing: Bug 500592: fix symbols for with debug info of Lttng 2.8

The process ID of the trace application is propagated so that it can
be used for the Function Duration Density view and Flame Graph view.

For the Flame Graph it uses the the timestamp of the maximum segment to
get the symbol name from the LTTng UST symbol provider.

For the Function density view it takes the start time of the segment.

Change-Id: Id3eb817f156e30b9be4996b732de05bc335418b9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80298
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
(cherry picked from commit c2845a63b7bf74179d9a7b8207dbb8a68aa716d8)
Reviewed-on: https://git.eclipse.org/r/80486
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/flamegraph/FlamegraphEvent.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/flamegraph/FlameGraphPresentationProvider.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/callgraph/ICalledFunction.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/callgraph/AbstractCalledFunction.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/callgraph/CalledStringFunction.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/callgraph/CallGraphAnalysis.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/callgraph/AggregatedCalledFunction.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/callgraph/CalledFunctionFactory.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/callgraph/SymbolAspect.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/callgraph/CalledFunction.java
Commit f2d0c63d4dc73d2f87b6887018185f82152b19d1 by Matthew Khouzam
doc: update doc with OS Overview Perspective.

Change-Id: Ib1b26566958aa0a899b0a1f3024296f9bd7266cf
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80355
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
(cherry picked from commit 6b590bd0858396edd085cf38f517c1ecb4eff129)
Reviewed-on: https://git.eclipse.org/r/80549
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/osOverview/select_os_overview.png
The file was modifieddoc/org.eclipse.tracecompass.doc.user/doc/User-Guide.mediawiki
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/osOverview/os_overview_perspective.png
Commit 5b93cfe801b03b3d24d60ea92000db0895930cb2 by Alexandre Montplaisir
lttng.ust: Do not skip unknown lines in addr2line output

addr2line will use "??" to indicate unknown function names or
source files. In these cases we should still report the other
information that may be available, instead of skipping the whole
callsite.

Change-Id: I2cd055b68950c8a6b5c21fd984cd82f2e3544245
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
(cherry-pick of 574eedca5174aef6f51d57703f8e78e65a4073fe)
Reviewed-on: https://git.eclipse.org/r/80339
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java
Commit 16e2a0501c9d4c64faf01d0a18bb5dc1578041c2 by Alexandre Montplaisir
lttng.ust: Do not block in UstDebugInfoAnalysisModule

Query methods in the module should not call waitForCompletion()
on the analysis, but should return whatever data they have
(or null).

This is because this is called by the aspects, which are called
by the event table, which are called by the UI thread! The UI
should not block while the analysis is waiting construction.

If a specific caller wants to wait for the full data, they can
call waitForCompletion() manually, like the tests do.

Change-Id: I2cf4e3544a8eea71a65f1e16fe7d4b5ba881d5ca
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
(cherry-pick of 599e5482448fede7d30a73bd9a3471b97be7ba4f)
Reviewed-on: https://git.eclipse.org/r/80340
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core.tests/src/org/eclipse/tracecompass/lttng2/ust/core/tests/analysis/debuginfo/UstDebugInfoAnalysisModuleTest.java
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/UstDebugInfoAnalysisModule.java
Commit 2623cd9270056aedd8fb44b28a04ad6b06b377ae by Genevieve Bastien
doc: Add developer documentation for JUL logging

This explains the guidelines to add logging statements to Trace Compass

Change-Id: I2f2dd4a110150da9700049cf775bc4dbfcf90f75
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77247
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
(cherry picked from commit 5e7d2b674f54083339c928b1010b9bd951a5691a)
Reviewed-on: https://git.eclipse.org/r/80519
The file was modifieddoc/org.eclipse.tracecompass.doc.dev/doc/Developer-Guide.mediawiki
Commit e3c72b6916eb3f5493c783c4301a2c782f4cb799 by Marc-Andre Laperle
tmf: SWTBot integration tests for Project Explorer trace folders

This covers 20 test scenarios from the test specification dealing
with trace folders, mostly dealing with importing traces. More test
will be added later to cover completely this section of the test
specification.

The change extracts some common code with existing tests.
Add more tests are added, we could remove some tests from the
non-integration test suite because there will be too much overlap.

Change-Id: I6d8e7753ca2341042a767a4a8e1f395041ff070b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/79987
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/80135
The file was modifiedctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ctf/ui/swtbot/tests/StandardImportAndReadSmokeTest.java
The file was addedreleng/org.eclipse.tracecompass.integration.swtbot.tests/src/org/eclipse/tracecompass/integration/swtbot/tests/projectexplorer/ProjectExplorerTracesFolderTest.java
The file was addedctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ctf/ui/swtbot/tests/SWTBotImportWizardUtils.java
The file was modifiedreleng/org.eclipse.tracecompass.integration.swtbot.tests/META-INF/MANIFEST.MF
The file was modifiedreleng/org.eclipse.tracecompass.integration.swtbot.tests/src/org/eclipse/tracecompass/integration/swtbot/tests/projectexplorer/TestDirectoryStructureUtil.java
Commit 078a9c627ecdc26374415554c8ec5f6a0b3dd4d8 by Alexandre Montplaisir
lami.chart: use formatter on x axis for continuous data type

Swt bar chart use categories instead of tick simply format categories
label while constructing the map.

Change-Id: I80bbf0b06a65e716a4ae87b06bc0731bb827c6dc
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
(cherry picked from commit e59a591f32dfc2c58164f2e90b62c10743e5d12a)
Reviewed-on: https://git.eclipse.org/r/80576
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.lami.ui/src/org/eclipse/tracecompass/internal/provisional/analysis/lami/ui/viewers/LamiBarChartViewer.java
Commit b5c1b13435a29c6c8cd25cd676421d6386a52c77 by Matthew Khouzam
SegStore: fix iterator caching in segment store.

Fix bug 500607

Change-Id: Id1ae2c2176624ddab35ef541c4f34f036e361f3c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80158
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
(cherry picked from commit 581e0f63122e0fca06d682dbc28fdf6e66ad2e53)
Reviewed-on: https://git.eclipse.org/r/80586
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core/src/org/eclipse/tracecompass/internal/analysis/timing/core/store/ArrayListStore.java
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.core.tests/src/org/eclipse/tracecompass/analysis/timing/core/tests/store/AbstractTestSegmentStore.java
Commit 40f578a80cd87741aa4387c35a39af066ca63197 by Bernd Hufmann
doc: update screenshot for system call latency statistics

to show the Total column

Change-Id: Id845c486831025027fe1b9da0fdaef92a0b23129
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80525
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
(cherry picked from commit 5c3932e3567f7d15783f2ce51b35ec4f3da9b9e8)
Reviewed-on: https://git.eclipse.org/r/80607
The file was modifieddoc/org.eclipse.tracecompass.doc.user/doc/images/LatenciesStatistics.png