SuccessChanges

Summary

  1. doc: Bug 495211: Update developer guide for ITmfStateSystem API (details)
  2. analysis.lami: Use the openResource command to open reports (details)
  3. analysis.lami: Use openResource command to run analyses (details)
  4. releng: Change update site for RCP upgrades to the stable one (details)
  5. lttng: bug 495211 document the critical flow view (details)
  6. doc: Bug 495211. Update follow CPU in user guide (details)
  7. doc: Bug 495211. Update Statistics View user guide (details)
  8. lttng: Make use of "is_pic" event field in debug info analysis (details)
  9. tmf: Bug 495219: Fix NPE in checkpoint indexer seeking on disposed trace (details)
  10. doc: Bug 495211. Add flat/hierarchical threads presentation user guide (details)
Commit 0304c4400e45ccad152f3eea62bdca967ab67642 by Patrick Tasse
doc: Bug 495211: Update developer guide for ITmfStateSystem API

Change-Id: I20bad86bfbd2bde033e04b8ea215fe0a6d2ac847
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74725
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
(cherry picked from commit b181e542108373930d5e41c72e5d42b78cc14be7)
Reviewed-on: https://git.eclipse.org/r/74788
The file was modifieddoc/org.eclipse.tracecompass.doc.dev/doc/Developer-Guide.mediawiki
Commit 8a53e9d4fa56059fa14252fdfea12b2714472790 by Alexandre Montplaisir
analysis.lami: Use the openResource command to open reports

Instead of defining our own command, we can hook into the
Eclipse-provided org.eclipse.ui.navigate.openResource command,
so that the reports can then be opened using the usual
keybindings to open resources.

Also hook it into OpenAction so that Enter and double-click
opens the report.

Bug: 493941

Change-Id: I4c546b60a77c2d531c8c9f18961984e5962ef56f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
(cherry picked from commit 685a6e679bc1093b92eafac992780c88398fe3bf)
Reviewed-on: https://git.eclipse.org/r/74733
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.lami.ui/plugin.xml
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/handlers/OpenAction.java
Commit d709c08bba48b93bc58aec4088d03ad9c7f640ef by Alexandre Montplaisir
analysis.lami: Use openResource command to run analyses

Bug: 493941

Change-Id: I628c5f7aef0674f4e83dbd9e611ec3616754f758
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
(cherry picked from commit f8e7a6be665dcda94eee4e49283bf7a778f262cf)
Reviewed-on: https://git.eclipse.org/r/74734
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.lami.ui/plugin.xml
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/handlers/OpenAction.java
Commit 681b7e6056a129a68e7ca6fe02718a22f03274b0 by Bernd Hufmann
releng: Change update site for RCP upgrades to the stable one

Change-Id: Ie3492d908ef6a08a746240da201ae9024f3a8fd6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74804
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
The file was modifiedctf/org.eclipse.tracecompass.ctf/p2.inf
The file was modifiedtmf/org.eclipse.tracecompass.tmf/p2.inf
The file was modifiedrcp/org.eclipse.tracecompass.rcp.product/tracing.product
Commit 9538c3d93007e45756780e720abfcc7e45256959 by Matthew Khouzam
lttng: bug 495211 document the critical flow view

The documentation introduces the view and the required steps to actually load
and run the wait analysis on a process.

Change-Id: I860ef950ef48381c5b5da3009d0a780970684f94
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74568
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/74809
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/waitAnalysis/KernelWaitAnalysisDjango.png
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/waitAnalysis/KernelWaitAnalysisFollow.png
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/waitAnalysis/KernelWaitAnalysisProjectExplorer.png
Commit 9b6f1f64406d034fe630f7dab86b26f3f51cc219 by Matthew Khouzam
doc: Bug 495211. Update follow CPU in user guide

Add follow CPU to Resources View user guide and CPU filtering to CPU
Usage View user guide.

Change-Id: Ie0572582f9228b7a4784d612e21fcca07dc9ccba
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74718
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-on: https://git.eclipse.org/r/74810
The file was modifieddoc/org.eclipse.tracecompass.doc.user/doc/User-Guide.mediawiki
Commit 86565890dc30ee6b8af3005354c59eaac1d68377 by Jean-Christian Kouame
doc: Bug 495211. Update Statistics View user guide

Change-Id: Id266dbb9ba577edea8acafbc196cfbc29f37cfb2
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74704
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
(cherry picked from commit 65a51c8efa6ebc4cac3243daa0b98a5ad7483ba7)
Reviewed-on: https://git.eclipse.org/r/74778
The file was removeddoc/org.eclipse.tracecompass.doc.user/doc/images/LTTng2StatisticsView.png
The file was modifieddoc/org.eclipse.tracecompass.doc.user/doc/User-Guide.mediawiki
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/LTTng2StatisticsPieChartView.png
The file was addeddoc/org.eclipse.tracecompass.doc.user/doc/images/LTTng2StatisticsTableView.png
Commit 731df40b1684821cbf9af0c3541135d3d3b2afa5 by Alexandre Montplaisir
lttng: Make use of "is_pic" event field in debug info analysis

A field with name "is_pic" is now present in LTTng 2.8 final in
"bin_info" events to indicate if the referred binary is PIC
(position-independent code) or not. We can make use of this
field to identify PIC binaries much more reliably than by just
looking at the file name.

Bug: 495551

Change-Id: Ib553f43e8236c399c56387ff8e20a8428c688fb5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74816
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/UstDebugInfoBinaryFile.java
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/UstDebugInfoLoadedBinaryFile.java
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/UstDebugInfoAnalysisModule.java
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/UstDebugInfoBinaryAspect.java
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core.tests/src/org/eclipse/tracecompass/lttng2/ust/core/tests/analysis/debuginfo/UstDebugInfoAnalysisModuleTest.java
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/UstDebugInfoStateProvider.java
The file was modifiedlttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/trace/layout/LttngUst28EventLayout.java
Commit bd824de90728c1e2677064a8f48fd34a9ee1f11d by Patrick Tasse
tmf: Bug 495219: Fix NPE in checkpoint indexer seeking on disposed trace

In BTree, if it is disposed (file is null), return -1 (insertion point
0) in the binary search. This will correspond to checkpoint 0 in the
flat array.

In FlatArray, if it is disposed (file is null) return null as checkpoint
in get(long).

In TmfCheckpointIndexer, if the returned checkpoint is null in
restoreCheckpoint(long), return the context given by the trace
implementation of seekEvent((ITmfLocation) null). It should properly
handle a disposed trace.

Change-Id: I3148d2e10118628e387d206054de55d5238a9807
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74474
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
(cherry picked from commit 7b3400bd1c99cfd700b342a3563bd04ce6d5156e)
Reviewed-on: https://git.eclipse.org/r/74818
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/trace/indexer/BTree.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/trace/indexer/checkpoint/TmfCheckpointIndexer.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/trace/indexer/FlatArray.java
Commit 3bf3b9952f952318ccd13d5ae48e7430c4756b24 by Matthew Khouzam
doc: Bug 495211. Add flat/hierarchical threads presentation user guide

Change-Id: I11a6c4f9293e0118f032e0da01d2984d8bb65fc1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74777
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
(cherry picked from commit 24c0b35e7948e3806be992366057b9203743bffe)
Reviewed-on: https://git.eclipse.org/r/74822
The file was modifieddoc/org.eclipse.tracecompass.doc.user/doc/User-Guide.mediawiki