SuccessChanges

Summary

  1. tmf: Revert removal of deprecated API use for support of older Eclipse (details)
  2. tmf.ui: Fix histogram deadlock when max time is Long.MAX_VALUE (details)
  3. timing.ui: better hide the 0 line of the density chart (details)
  4. tmf: Improve time graph model elements toString() (details)
Commit f90e48f01e61d75a4e65e9a653d431a8f2d1cff3 by bernd hufmann
tmf: Revert removal of deprecated API use for support of older Eclipse

The constructor "FilteredTree(Composite, int, PatternFilter, boolean,
boolean)" is undefined in Eclipse 2019-06 and older. Use the
deprecated constructor instead, whose usage has been recently removed
in Trace Compass. Call setUseHashlookup(true) directly on the tree
viewer, which has the same effect as using the new constructor.

When this deprecated API is removed by the platform and Trace Compass
still needs to support older platforms, then we can implement a utility
that uses reflection to call the right constructor version.

Change-Id: I9bbad0d181899127fd0e67fa50c31de2d40e1a09
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/160111
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/widgets/timegraph/dialogs/FilteredCheckboxTree.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/tree/AbstractSelectTreeViewer.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/wizards/SelectTracesWizardPage.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/dialogs/offset/OffsetDialog.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/wizards/SelectRootNodeWizardPage.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/widgets/timegraph/dialogs/TimeGraphFilterDialog.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/tracetype/preferences/TraceTypePreferencePageViewer.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/widgets/timegraph/dialogs/TriStateFilteredCheckboxTree.java
Commit aa318111613f505514984e2e2400dd7ad5aca95b by genevieve bastien
tmf.ui: Fix histogram deadlock when max time is Long.MAX_VALUE

If the maximum time of the trace is Long.MAX_VALUE, there was an
infinite loop since the limit never gets higher than the timestamp.

Change-Id: I2abafb63a1865613fa0118fedbcb1c106273f67b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/160275
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/histogram/HistogramDataModel.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.ui.tests/src/org/eclipse/tracecompass/tmf/ui/tests/histogram/HistogramDataModelTest.java
Commit e924705ae8b7317029aa3f4643d2f79bb6f1ada3 by matthew khouzam
timing.ui: better hide the 0 line of the density chart

Hide the blue line that was at 0. As chart is logarithmic the value
cannot be zero by default.

[fixed] Don't show the blue line at the bottom of a 0 in the density chart

Change-Id: Ia96ef6eca9a7125004a75a674e13b1676dc42809
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/160138
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
The file was modifiedanalysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/analysis/timing/ui/views/segmentstore/density/AbstractSegmentStoreDensityViewer.java
Commit e662235d8a555392a517eb69fa2f6587596b6944 by patrick tasse
tmf: Improve time graph model elements toString()

Change-Id: I5782107836cb330048f51c9e88d0e665726344f3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/159271
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/model/timegraph/TimeGraphRowModel.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/model/timegraph/TimeGraphModel.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/model/timegraph/TimeGraphState.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/model/timegraph/TimeGraphEntryModel.java
The file was modifiedtmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/model/timegraph/TimeGraphArrow.java