SuccessChanges

Summary

  1. remove: Potential NP access for getChannel(String) (#4155) (details)
  2. remove some potential NP access (#4157) (details)
  3. [Hue] Added state updates for switch changes (#3967) (details)
  4. Astro: Sun phase calculation fix (#4158) (details)
  5. Astro: Schedule Jobs 30sec after midnight to ensure to be on the next day (#4131) (details)
  6. MQTT broker reconnect and close cleanup (#4160) (details)
  7. Fix Weatherunderground thing is stuck in Initializing state (#4124) (details)
  8. Implemented two fixes/improvements for the Tradfri binding: (#4159) (details)
  9. the reconnect timing should be constant after object creation (#4166) (details)
  10. Updated README with skipTests flag (#4150) (details)
  11. Rest API: possibility to add multiple items at once (#4165) (details)
  12. ThingTypeI18nLocalizationService: fix issue #4152 (#4171) (details)
  13. Fix GenericItemProvider missing added event on startup (#4163) (details)
  14. allows to start-stop-start-stop-... a reconnect strategy (#4168) (details)
  15. Mqtt: Fix reloading configuration. Fix reconnect (#3980) (details)
  16. Core/net: Add getInterfaceAddresses. This completes getAllBroadcastAddresses() and is useful for discovery services (#4172) (details)
  17. Prevent WARN log when config is marked with PID (#4174) (details)
  18. Convert ConfigDispatcherTest to Java test (#4175) (details)
Commit ceface5054b90dfa4e400ef4f6e57d4cc3dc132a by Kai Kreuzer
remove: Potential NP access for getChannel(String) (#4155)

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/src/main/java/org/eclipse/smarthome/binding/astro/handler/AstroThingHandler.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.fsinternetradio.test/src/test/java/org/eclipse/smarthome/binding/fsinternetradio/test/FSInternetRadioHandlerOSGiTest.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/src/main/java/org/eclipse/smarthome/binding/astro/internal/job/Job.java (diff)
The file was modifiedbundles/core/org.eclipse.smarthome.core.thing.test/src/test/java/org/eclipse/smarthome/core/thing/internal/ChannelStateDescriptionProviderOSGiTest.java (diff)
Commit b53b704eaf4420de82c4246f00df344bc783eeab by Kai Kreuzer
remove some potential NP access (#4157)

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.digitalstrom/src/main/java/org/eclipse/smarthome/binding/digitalstrom/handler/BridgeHandler.java (diff)
The file was modifiedbundles/automation/org.eclipse.smarthome.automation.module.script.defaultscope/src/main/java/org/eclipse/smarthome/automation/module/script/defaultscope/internal/ItemRegistryDelegate.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.hue/src/main/java/org/eclipse/smarthome/binding/hue/internal/HueThingHandlerFactory.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/META-INF/MANIFEST.MF (diff)
The file was modifiedbundles/automation/org.eclipse.smarthome.automation.core/src/main/java/org/eclipse/smarthome/automation/core/internal/RuleEngine.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.ntp/src/main/java/org/eclipse/smarthome/binding/ntp/handler/NtpHandler.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.tradfri/src/main/java/org/eclipse/smarthome/binding/tradfri/internal/TradfriHandlerFactory.java (diff)
The file was modifiedbundles/automation/org.eclipse.smarthome.automation.core/src/main/java/org/eclipse/smarthome/automation/core/internal/composite/AbstractCompositeModuleHandler.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/MqttBrokerConnection.java (diff)
The file was modifiedbundles/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/scheduler/AbstractExpression.java (diff)
The file was modifiedbundles/storage/org.eclipse.smarthome.storage.json.test/src/main/java/org/eclipse/smarthome/storage/json/JsonStorageServiceOSGiTest.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.sonos/src/main/java/org/eclipse/smarthome/binding/sonos/handler/ZonePlayerHandler.java (diff)
The file was modifiedbundles/core/org.eclipse.smarthome.core.thing/src/main/java/org/eclipse/smarthome/core/thing/dto/ThingDTOMapper.java (diff)
Commit abb299d7b47e562504a35cdd201fb1a33560ea3b by Kai Kreuzer
[Hue] Added state updates for switch changes (#3967)

* Added state updates for switch changes.
Also added a few log messages and fixed a compiler warning.

Fixes #2775.

Signed-off-by: 9037568 <namraccr@gmail.com>
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.hue/src/main/java/org/eclipse/smarthome/binding/hue/handler/LightStatusListener.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.hue/src/main/java/org/eclipse/smarthome/binding/hue/handler/HueBridgeHandler.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.hue/src/main/java/org/eclipse/smarthome/binding/hue/handler/HueLightHandler.java (diff)
Commit 0d932b7b9e85c62360b5edb43b890cc5d542818e by Simon Kaufmann
Astro: Sun phase calculation fix (#4158)

* Fixed sun phase calculation
* Removed noon from sun phase, because it is not a real phase
* Fixed range matching

Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/src/main/java/org/eclipse/smarthome/binding/astro/internal/calc/SunCalc.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/src/main/java/org/eclipse/smarthome/binding/astro/internal/model/Range.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/README.md (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/src/main/java/org/eclipse/smarthome/binding/astro/internal/job/DailyJobSun.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/src/main/java/org/eclipse/smarthome/binding/astro/internal/util/DateTimeUtils.java (diff)
Commit ee1f59029b00ad9bbcdb07c81d356dd4a2df9d9b by Markus Rathgeb
Astro: Schedule Jobs 30sec after midnight to ensure to be on the next day (#4131)

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.astro/src/main/java/org/eclipse/smarthome/binding/astro/handler/AstroThingHandler.java (diff)
Commit 1c2e23f09595c5985f22b07b843f6510e9fc0c07 by Kai Kreuzer
MQTT broker reconnect and close cleanup (#4160)

Fixes:
If the MQTT broker connection is closed the reconnect strategy is still
hold alive and a reconnect is not stopped.
If the MQTT broker could not be reached all the time there will be
multiple reconnect tasks been started / running.

This changes also contains some inspiration from #3980.

Also-by: David Gräff <david.graeff@web.de>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/reconnect/PeriodicReconnectStrategy.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/MqttBrokerConnection.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/reconnect/AbstractReconnectStrategy.java (diff)
Commit 067b169d8bd4415d17c0a42a29374fc5ad0b86b4 by Simon Kaufmann
Fix Weatherunderground thing is stuck in Initializing state (#4124)

* Fix Weatherunderground thing is stuck in Initializing state

Fixes #4123
Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.weatherunderground/ESH-INF/i18n/weatherunderground_fr.properties (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.weatherunderground/src/main/java/org/eclipse/smarthome/binding/weatherunderground/handler/WeatherUndergroundHandler.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.weatherunderground/ESH-INF/i18n/weatherunderground.properties (diff)
Commit c4f8da949035ca9f8c7f7bd336fae4d000e79c1e by Kai Kreuzer
Implemented two fixes/improvements for the Tradfri binding: (#4159)

- Removal of older discovery results, so that devices are instantaneously retrieved in inbox after deletion
- Fixed bulb channels not receiving updates from remote (#3869)

Signed-off-by: Alexander Kostadinov <alexander.g.kostadinov@gmail.com>
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.tradfri/src/main/java/org/eclipse/smarthome/binding/tradfri/handler/TradfriLightHandler.java (diff)
The file was modifiedextensions/binding/org.eclipse.smarthome.binding.tradfri/src/main/java/org/eclipse/smarthome/binding/tradfri/internal/discovery/TradfriDiscoveryService.java (diff)
Commit eaa60228d2c2ccc07c47bb21f65d42456854648b by Kai Kreuzer
the reconnect timing should be constant after object creation (#4166)

The reconnect timing should not be changed after the periodic reconnect
strategy has been connected. Using unmodifiable members will make that
values thread safe. The caller also does the internal state the
reconnect strategy currently is using, so it make IMHO no sense to
change some timing without knowing at which time it will affect the
current behavior.
If the MQTT broker connection should use another timed strategy you
could create a new reconnect strategy and set it for the existing
connection.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/reconnect/PeriodicReconnectStrategy.java (diff)
Commit 3e77c4d22afc88e1f355e1bd2809b6207b264b19 by Kai Kreuzer
Updated README with skipTests flag (#4150)

Thanks @kaikreuzer for [the info](https://github.com/eclipse/smarthome/pull/4148#issuecomment-325430137)! :-)

Signed-off-by: kubawolanin <hi@kubawolanin.com>
The file was modifiedREADME.md (diff)
Commit 028988927a80a7c333799e0b5779ed36047228a6 by Kai Kreuzer
Rest API: possibility to add multiple items at once (#4165)

* Rest API: possibility to add multiple items at once

Fixes #4060

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
The file was modifiedbundles/io/org.eclipse.smarthome.io.rest.core/src/main/java/org/eclipse/smarthome/io/rest/core/item/ItemResource.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.rest.core/META-INF/MANIFEST.MF (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.rest.core.test/src/test/java/org/eclipse/smarthome/io/rest/core/item/ItemResourceOSGiTest.java (diff)
Commit 841066f11d7ce42779f0e14fdb73dbde717c0966 by Kai Kreuzer
ThingTypeI18nLocalizationService: fix issue #4152 (#4171)

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
The file was modifiedbundles/core/org.eclipse.smarthome.core.thing/src/main/java/org/eclipse/smarthome/core/thing/i18n/ThingTypeI18nLocalizationService.java (diff)
Commit 484cc84c9f5491ecdaa2c16f0932b007dc8b16fd by Kai Kreuzer
Fix GenericItemProvider missing added event on startup (#4163)

- fixes #4162
- also fixes duplicate added events for items see https://github.com/eclipse/smarthome/issues/4161#issuecomment-326000211 and closes #617
- minor cosmetics

Signed-off-by: Henning Treu <henning.treu@telekom.de>
The file was modifiedbundles/model/org.eclipse.smarthome.model.item/OSGI-INF/genericitemprovider.xml (diff)
The file was modifiedbundles/model/org.eclipse.smarthome.model.item/META-INF/MANIFEST.MF (diff)
The file was modifiedbundles/model/org.eclipse.smarthome.model.item/src/org/eclipse/smarthome/model/item/internal/GenericItemProvider.java (diff)
Commit 0f334f05f01a1dd8e3fe9e1b171403f014c15ad1 by Kai Kreuzer
allows to start-stop-start-stop-... a reconnect strategy (#4168)

* allows to start-stop-start-stop-... a reconnect strategy

A MQTT Broker Connection must be able to handle start and stop
iterations.

Related to: https://github.com/eclipse/smarthome/pull/3980#issuecomment-326222638
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/MqttBrokerConnection.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/reconnect/PeriodicReconnectStrategy.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/reconnect/AbstractReconnectStrategy.java (diff)
Commit a27e6ef4d0ac034e12df5db037af27765a70074b by Kai Kreuzer
Mqtt: Fix reloading configuration. Fix reconnect (#3980)

Also-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: David Gräff <david.graeff@web.de>
The file was addedbundles/io/org.eclipse.smarthome.io.transport.mqtt/OSGI-INF/.gitignore
The file was removedbundles/io/org.eclipse.smarthome.io.transport.mqtt/OSGI-INF/mqtt-service.xml
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/src/main/java/org/eclipse/smarthome/io/transport/mqtt/MqttService.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt.test/src/test/java/org/eclipse/smarthome/io/transport/mqtt/MqttServiceTests.java (diff)
The file was modifiedbundles/io/org.eclipse.smarthome.io.transport.mqtt/META-INF/MANIFEST.MF (diff)
Commit 7a8e74296b4680ef3375d756b8e5ffee1fa4452a by Kai Kreuzer
Core/net: Add getInterfaceAddresses. This completes getAllBroadcastAddresses() and is useful for discovery services (#4172)

Signed-off-by: David Gräff <david.graeff@web.de>
The file was modifiedbundles/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java (diff)
The file was modifieddocs/documentation/features/frameworkUtilities.md (diff)
Commit 0b90f4a7ac464bbae2e32752870b81347f31abc1 by Kai Kreuzer
Prevent WARN log when config is marked with PID (#4174)

Signed-off-by: Henning Treu <henning.treu@telekom.de>
The file was modifiedbundles/config/org.eclipse.smarthome.config.dispatch/src/main/java/org/eclipse/smarthome/config/dispatch/internal/ConfigDispatcher.java (diff)
Commit 002c46876e1b182ced5acb82535ce144986817da by Kai Kreuzer
Convert ConfigDispatcherTest to Java test (#4175)

Signed-off-by: Henning Treu <henning.treu@telekom.de>
The file was addedbundles/config/org.eclipse.smarthome.config.dispatch.test/ConfigDispatcherOSGiTest.launch
The file was addedbundles/config/org.eclipse.smarthome.config.dispatch.test/src/test/java/org/eclipse/smarthome/config/dispatch/test/ConfigDispatcherOSGiTest.java
The file was modifiedbundles/config/org.eclipse.smarthome.config.dispatch.test/OSGI-INF/configdispatchertest.xml (diff)
The file was removedbundles/config/org.eclipse.smarthome.config.dispatch.test/.settings/org.eclipse.jdt.groovy.core.prefs
The file was modifiedbundles/config/org.eclipse.smarthome.config.dispatch.test/.classpath (diff)
The file was modifiedbundles/config/org.eclipse.smarthome.config.dispatch.test/.project (diff)
The file was removedbundles/config/org.eclipse.smarthome.config.dispatch.test/ConfigDispatchTest.launch
The file was modifiedbundles/config/org.eclipse.smarthome.config.dispatch.test/build.properties (diff)
The file was modifiedbundles/config/org.eclipse.smarthome.config.dispatch.test/META-INF/MANIFEST.MF (diff)
The file was removedbundles/config/org.eclipse.smarthome.config.dispatch.test/src/test/groovy/org/eclipse/smarthome/config/dispatch/test/ConfigDispatchTest.groovy