SuccessChanges

Summary

  1. [546681] Remove redundant SWTBotSiriusDiagramEditor editor fields (details)
  2. [546681] Adjust SessionSaveableTest to dialog title change (details)
  3. [546681] Fix potential invalid thread access in SessionEditor (details)
  4. [546681] Fix NPEs when closing editors asynchronously (details)
  5. [546681] Fix lifecycle of SessionEditor (details)
Commit 13d899a205e4368936fe1830a52c8377fe1cd667 by pierre-charles david
[546681] Remove redundant SWTBotSiriusDiagramEditor editor fields
Many classes duplicate, and more importantly, hide fields which already
exists in the AbstractSiriusSwtBotGefTestCase: this makes some helpers
defined in AbstractSiriusSwtBotGefTestCase inoperant at best and buggy
at worst as those versions (in AbstractSiriusSwtBotGefTestCase)
reference the masked field, which is generally null as the test itself
uses its local version.
Bug: 546681 Change-Id: Iecf571f395798d9bebb7c369c9595c3caf9e82d7
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/EdgeStabilityOnBendpointsAlignmentTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/LinkNoteFragmentModelCreationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/DiagramDocumentationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/DuplicationCausedBySelectionTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/layout/PackageLayoutStabilityOnManyViewsCreationToolTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ArrangeAllLinkedBorderedNodesLayoutStabilityAppTemoinTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ContainerChildrenPresentationChangeTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/FileModificationValidationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ReconnectEdgeBendpointStabilityTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/layout/LayoutStabilityOnManualRefreshTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/NodeCreationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ReconnectEdgeExtraMappingTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/VSMAndDiagramEditorSynchronisationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/EdgeLabelStabilityTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/TreeFoldingTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/AbstractHideRevealDiagramElementsLabelTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ContainerCreationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/EdgeStabilityOnDragAndDropTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/SessionOpeningWithAirdNoDiagramTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/layout/EdgeAndPortStabilityOnSemanticChangeTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/DiagramCreationDescriptionFromDNodeListElementTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ArrangeAllLinkedBorderedNodesLayoutStabilityTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/CascadingSiriusURITest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ExtraMappingEdgeCreationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/SiriusInternationalizationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/DoubleClickToolNavigationOperationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/HideLabelIconsWithPreferencesTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/PortSelectionTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ReconnectEdgeWithChangedRoutingStyleTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ToolWizardTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/uml/AbstractUmlDragAndDropTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/NoteCreationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/layout/EdgeWithPathLayoutTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/DragNDropTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/layout/EdgeLayoutStabilityWithToolWizardTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/DiagramCreationDescriptionTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/GroupElementsInOneOtherTests.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/editor/vsm/FeatureAssistTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/RemovedDefaultColorMenuTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/ArrangeSelectionOnBreakdownDiagramTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/EdgeStabilityOnLayerManagementTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/BorderedNodeResizeCreationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/DNodeListCreationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/NavigateToNewRepresentationTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/OpenMultipleRepresentationsTest.java
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/editor/vsm/ContentAssistTest.java
Commit 6013c414690615ab0944475eb31b23edd63c940f by pierre-charles david
[546681] Adjust SessionSaveableTest to dialog title change
Bug: 546681 Change-Id: Icd13473dd4135ebc95f3b7ac9e84a3cbbe51db71
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modifiedplugins/org.eclipse.sirius.tests.swtbot/src/org/eclipse/sirius/tests/swtbot/SessionSaveableTest.java
Commit 7ec752590a5e421a0aa0a36977e7d304e2ad5f61 by pierre-charles david
[546681] Fix potential invalid thread access in SessionEditor
Bug: 546681 Change-Id: I01bc8df428db8f941c06f2933288b3176586c7b7
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modifiedplugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/SessionEditor.java
Commit 48d1ddfaa8091e333005f84e7f28a9d2b63f5e9f by pierre-charles david
[546681] Fix NPEs when closing editors asynchronously
Patch https://git.eclipse.org/r/c/125716 on the platform cleans up some
fields which asynchronous callbacks used to access for closing the
editors. At the time the callbacks are executed, getPage() and
getWorkbenchWindow() now return null.
For DDiagramEditorImpl, the solution is the same that was used in GMF
Runtime 1.12.1 itself, but it is reproduced here to avoid the bug when
running with previous versions of GMF.
For tables & trees, we rely on our own helpers as the context if
different and we do not have access to all the methods needed for the
GMF solution.
Bug: 546681 Change-Id: I9a7831ea2643c7f7b8090633f524e2c035406fc8
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modifiedplugins/org.eclipse.sirius.table.ui/src/org/eclipse/sirius/table/ui/business/internal/dialect/TableDialectUIServices.java
The file was modifiedplugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/internal/editor/DDiagramEditorImpl.java
The file was modifiedplugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/SessionEditor.java
Commit 864496bca0e8ff03d498ec2d9ea582db4d79afe4 by pierre-charles david
[546681] Fix lifecycle of SessionEditor
Make sure we cleanup all our resources and remove all our listeners in
dispose(). No need anymore to override the close() method.
Bug: 546681 Change-Id: I3d8e29ae7734de7b9fdecbd622bddb63c0e3ca31
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modifiedplugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/SessionEditor.java