FailedChanges

Summary

  1. Bug 404990 - [breakpoints] Delete breakpoint, undo, redo, undo. Gone. (details)
  2. Bug 81461 - [console] needs key to clear (details)
  3. Bug 563752 - [console] FileLink with offset need line number which is (details)
  4. Bug 306131 - [console] Null byte to stdout results in truncation of line (details)
  5. Bug 564849 - [Tests] Fix unstable JUnit tests (details)
Commit 4c211278c0d0edf4fb86da00b36eac39edd348d1 by Paul Pazderski
Bug 404990 - [breakpoints] Delete breakpoint, undo, redo, undo. Gone.

The issue is located in both, the redo and the second undo operation.

Delete breakpoint and redo of this operation have the (for this issue
relevant) difference that the first set a 'breakpoint deleted' attribute
on the marker while the redo does not set/update this attribute.
The simple fix is to move the "mark deleted" into the delete marker
operation which is executed from an 'initial' delete as well as from a
redo.

After fixing that a breakpoint is restored but the view does not
updated.
BreakpointManager does not properly send added notifications. Most of
the time it works because an added breakpoint will be registered and the
registration will trigger the added notification.
However for the add of the second undo the registered attribute is
already set, the setRegister(true) which normally triggers the add
notification is not executed.

Change-Id: Ib509ec9c8116ac4a7bb3f8bcf38dc470e0b90b8b
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
The file was addedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/TestBreakpoint.java
The file was addedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/DebugTestModelPresentation.java
The file was modifiedorg.eclipse.debug.ui/ui/org/eclipse/debug/ui/DebugUITools.java
The file was addedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/BreakpointTests.java
The file was modifiedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/BreakpointOrderingTests.java
The file was modifiedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/AutomatedSuite.java
The file was modifiedorg.eclipse.debug.tests/plugin.xml
The file was addedorg.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/DeleteBreakpointMarkersOperation.java
The file was modifiedorg.eclipse.debug.core/core/org/eclipse/debug/internal/core/BreakpointManager.java
The file was modifiedorg.eclipse.debug.tests/plugin.properties
Commit 57d79764eaace00697da31d84379a04ff27042c0 by Paul Pazderski
Bug 81461 - [console] needs key to clear

Does not include a default key binding.

Change-Id: I93361fa760ba7c72e83da39abee10dfbb6e35abb
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
The file was modifiedorg.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/console/ProcessConsolePageParticipant.java
The file was modifiedorg.eclipse.debug.ui/plugin.properties
The file was modifiedorg.eclipse.debug.ui/plugin.xml
Commit f624f1e041e6e85acf4d750fd92b5d08c5cca71a by Paul Pazderski
Bug 563752 - [console] FileLink with offset need line number which is
ignored

FileLink can be created with offset+length or line number to be selected
once the link is activated. All of those position parameters are
optional and there is no reason to specify offset+length and line number
on the same link.
However before this commit the offset+length was ignored if no line
number >= 0 was given.

Change-Id: Iaf105bc25acaec064763ebe60abf7cdcc409b58c
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
The file was addedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/console/FileLinkTests.java
The file was modifiedorg.eclipse.debug.ui/ui/org/eclipse/debug/ui/console/FileLink.java
The file was modifiedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/AutomatedSuite.java
Commit df0a30251c7d67951b24884e2c3cc71c4bb69b3e by Paul Pazderski
Bug 306131 - [console] Null byte to stdout results in truncation of line

If interpretation of ASCII control characters is enabled handle null
bytes (\0) by simply filtering them out. This is useful because null
bytes can truncate console lines on some platforms and brings unexpected
results on copy text on most platforms.

Change-Id: Ic6a46c3eba4582c8f54fcd6735b8763738d47623
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
The file was modifiedorg.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java
The file was modifiedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/console/IOConsoleTests.java
Commit df9297cf8536bdaa582eed3649065e2323ea791e by Paul Pazderski
Bug 564849 - [Tests] Fix unstable JUnit tests

OutputStreamMonitorTests
  Two of the tests are explicit written for UTF-8 but the monitor is
initialized with default charset. Since many modern systems use UTF-8 as
default the test still works most of the times.

InputStreamMonitorTests
  The closing test stops the input monitoring thread and immediately
checks if the thread is stopped. I saw a few random test failures
locally from this race condition.

BreakpointTests
  Calling dispose on a view is not the right way to close the view.

Change-Id: I4e01475032dc5dd69810eedc467ba1ff3efb2ef3
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
The file was modifiedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/console/InputStreamMonitorTests.java
The file was modifiedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/console/OutputStreamMonitorTests.java
The file was modifiedorg.eclipse.debug.tests/src/org/eclipse/debug/tests/breakpoint/BreakpointTests.java