FailedChanges

Summary

  1. Bug 562165 - [Win32] Text editor should support ligatures on Windows (details)
  2. Bug 563451: Cleanup variable names in S-Leak (details)
  3. Bug 563451: Add a save to file option for S-Leak (details)
  4. v4934r6 (details)
  5. Bug 563531 - [regression][StyledText] Scrolling with arrow down key does (details)
  6. v4934r6 (details)
  7. Bug 563018: Improve description of Color.dispose (details)
  8. Bug 563407 - Icons from disabled CommandContributionItem are invisible (details)
  9. Bug 563531 - [Tests][StyledText] Scrolling with arrow down key does not (details)
  10. v4934r6 (details)
  11. Bug 536008 - [Dark Theme] Disabled label looks bad in dark theme (details)
  12. Bug 536008 - [Dark Theme] Disabled label looks bad in dark theme (details)
  13. v4934r6 (details)
Commit b5c4cc2ad0e1493c82bb09dcbbdb40bfc316a767 by niraj modi
Bug 562165 - [Win32] Text editor should support ligatures on Windows
- Updated the test snippet/image.

Change-Id: I0b6e182ba2dcbbd8b43a767e7ea28585678a7a4a
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
The file was modifiedexamples/org.eclipse.swt.snippets/previews/Snippet377.png
The file was modifiedexamples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet377.java
Commit dba44ca8a2f5a66a1c6813d883a76853360f2afa by alexander kurtakov
Bug 563451: Cleanup variable names in S-Leak

The names of the variables for the controls and the sizes
did not really match. This commit makes the variables
match to make further edits to this code easier.

Change-Id: I832bc151939c8715fefae2ed16573f53b1ef5400
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
The file was modifiedbundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/Sleak.java
The file was modifiedbundles/org.eclipse.swt.tools.spies/META-INF/MANIFEST.MF
The file was modifiedbundles/org.eclipse.swt.tools.spies/pom.xml
Commit 2b98a74aad27bd8b077ee0162491a0aa28f34c6f by alexander kurtakov
Bug 563451: Add a save to file option for S-Leak

Two new buttons are added, save and save as.

There are some options:
- save to incrementing file numbers to make it easier to
capture multiple files without prompts
- save the preview to png files cross referenced to the
main text file
- include stack traces if "Stack" is checked


Change-Id: I915a27ce4856b83bdc278499d1d673276aa287f1
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
The file was modifiedbundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/Sleak.java
Commit 5ecea402709fbe4e53794e46617850fbe0a72344 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 6e641395f4220586d372e17c9814a8641736cc33 by niraj modi
Bug 563531 - [regression][StyledText] Scrolling with arrow down key does
not update caret painting
- Partially reverting one of the change w.r.t. to "setCaretLocation()"
from bug 168557 fix

Change-Id: I60278489b05fa222f4a368572438b16730505e49
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
Commit adfa3e1233ac695f927d779754d55a241ece7c85 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 68dac2b31c95dd12c485fe519da1f04ed284ff0b by alexander kurtakov
Bug 563018: Improve description of Color.dispose

Change-Id: Ie4d98d4249a9f7a7ef36a1483de9c6ffc2b5fc21
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/Color.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Color.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/Color.java
Commit bafd10404c2982b2b5b5e75b583e4839b54288d6 by andrey loskutov
Bug 563407 - Icons from disabled CommandContributionItem are invisible

Change-Id: I1ffeb554724c4908de7031ffdb281a6cff1feb09
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolItem.java
Commit d125f2576857587481e794299871af484812f593 by niraj modi
Bug 563531 - [Tests][StyledText] Scrolling with arrow down key does not
update caret painting

A test case for regression from
2abb22fa4db3f7c87fc38290f55d0d8c4d4a4465.

Change-Id: I5622f35d8819866078f8f1376111b26803d14990
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
The file was modifiedtests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledText.java
Commit e96e047be0ea6674f6bc611ab4a5c9a20b6e7fb7 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 8880b3fabd253cf3cae94e4988c8006ad665515c by Alexandr Miloslavskiy
Bug 536008 - [Dark Theme] Disabled label looks bad in dark theme

This is a preparation patch. Changes:
1) Get rid of `IMAGE_AND_TEXT` that was disabled for 15 years.
   Owner draw code for text Labels is preserved for the next patch.
   It is also fixed to always draw text on top, as native Label does.
2) Also remove duplicate code in `Label.setAlignment()`.

Change-Id: I74b048d8f12eba13000b5264fdd4549359a61f56
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Label.java
The file was addedtests/org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/tests/win32/snippets/Bug536008_DarkDisabledLabel.java
Commit 9033556b301c479bcb934b2f0f8082701b56f23d by Alexandr Miloslavskiy
Bug 536008 - [Dark Theme] Disabled label looks bad in dark theme

Added a theme tweak to set foreground color for disable Label.

Image labels are not supported due to complexity and lack of demand.

Change-Id: Ib81641b3cbeeb3ddd84435f71fef583a81a52d93
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Label.java
The file was modifiedtests/org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/tests/win32/snippets/Bug536008_DarkDisabledLabel.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java
Commit 3acfca8cb48769e74d6a0e68a66fe398f9f5f5bd by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml