FailedChanges

Summary

  1. [trivial] Remove redundant instanceof/cast (details)
  2. Bug 560316: Preparation: Fix WS_BORDER behavior for Text (details)
  3. Bug 563210 - Icons missing for xsl, jar, sh etc files in Package/Project (details)
  4. Bug 560316 - [win32][Dark theme] Text border color is too bright for dark theme (details)
  5. Bug 560284 - [win32][Dark] Table header delimiters color is bad for dark theme (details)
  6. v4934r6 (details)
  7. Bug 563253 - [GTK][hidpi] org.eclipse.swt.graphics.GC is disposed and (details)
  8. v4934r6 (details)
  9. Bug 548535 - 4.12 SWT.jar's version.txt incorrect (details)
  10. Bug 562193 - [Win32] Enable Custom DarkTheme on Windows (details)
  11. v4934r6 (details)
Commit 1885cf19dcbcbc4ef7332320f2aadaacb9bd699d by alexander kurtakov
[trivial] Remove redundant instanceof/cast

Change-Id: I4953d45d5bdcc0b628f808649727edda9270c6c9
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
The file was modifiedexamples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/graphics/GradientDialog.java
Commit b6321a99e75b725c0d32bf08cb11485cb2fae744 by niraj modi
Bug 560316: Preparation: Fix WS_BORDER behavior for Text

Currently, Text will never use `WS_BORDER`.
However, it will be used in the next commit.

Change-Id: Ifdfc6be1127fd3ac629634bb8869968b45e71f89
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Text.java
Commit d62778411f432f94ac17aa9e4af5841c8a5badab by sravan kumar lakkimsetti
Bug 563210 - Icons missing for xsl, jar, sh etc files in Package/Project
Explorer and Resource Dialog

Change-Id: I5f30b749066be6160022b606c8e8374a7db6b802
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/internal/graphics/ImageUtil.java
Commit 3cd2dc7cb792b9be2c78013774b23a7cbecd4560 by niraj modi
Bug 560316 - [win32][Dark theme] Text border color is too bright for dark theme

I found that `WS_BORDER` instead of `WS_EX_CLIENTEDGE` works quite well.

Affected controls will slightly change preferred size (on my Win10,
that's just one pixel less on every side), except `Text`. For `Text`,
the size is preserved (see comment in `Text.computeTrimInPixels()`).

Fine-grained knobs are given because for some controls, the effect may
be undesirable, for example Spinner will now have a double border. Maybe
some additional fixes could solve it, but I wasn't interested in fixing
every control possible.

Change-Id: Ied6c549689d91b01b89681c508215b26f9f89aa2
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/List.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Label.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Spinner.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tree.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Text.java
The file was addedtests/org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/tests/win32/snippets/Bug560316_DarkTextBorders.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Canvas.java
Commit fdad775eff1272fde91253a01f85ee57d35b3ec6 by niraj modi
Bug 560284 - [win32][Dark] Table header delimiters color is bad for dark theme

The color is configurable, because Eclipse and the product I'm working
on are likely to use different colors.

For API design goals, see recent patch for Bug 444560.

Change-Id: I9a1dec43d6081097bb0db0a47a0f381163ba5b32
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
The file was addedtests/org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/tests/win32/snippets/Bug560284_DarkTableHeaderLineColor.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java
Commit 334d975dac108357c2ae36ebdc0e62d895c44df8 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 076d14b0c9594754adf7a81d04fccd84ea8e0db2 by sravan kumar lakkimsetti
Bug 563253 - [GTK][hidpi] org.eclipse.swt.graphics.GC is disposed and
destroyed when Image is re-drawn

Change-Id: Ic43dc8b442ad43422ad901a18109a5282eabb457
The file was addedtests/org.eclipse.swt.tests.gtk/ManualTests/org/eclipse/swt/tests/gtk/snippets/Bug563253_GraphicsSnippet.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/Image.java
Commit 248bc58797f262b0dfb437926cfd6e6ac14e55f3 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit b69209f789e98f492fdd732764390b5040c8b863 by lakshmi shanmugam
Bug 548535 - 4.12 SWT.jar's version.txt incorrect

This reverts commit f2ba416efc8d19fa6f4d7d019e63b670865a3abc.
Put the correct version in version.txt. Fix the version updation in
buildSWT.xml.

Change-Id: I81515524d1f77dec1a589a0c013bcbdb8b239a85
The file was addedbundles/org.eclipse.swt/Eclipse SWT/common/version.txt
The file was modifiedbundles/org.eclipse.swt/buildFragment.xml
The file was modifiedbundles/org.eclipse.swt/buildSWT.xml
Commit c9cfc11cb0c2c3c9f1cf1880fe8d587600943046 by niraj modi
Bug 562193 - [Win32] Enable Custom DarkTheme on Windows

Change-Id: I67a0c70d9820ce79c64dd7556b116df1e1f073e5
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java
Commit ad1e4ed2222daf79edfa1a57e87c1b6221963ce3 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml