FailedChanges

Summary

  1. Bug 562951 - [GTK] Eclipse crashes on start-up with OpenJDK 11 debug build (details)
  2. Bug 562165 part2 - [Win32] Text editor should support ligatures on (details)
  3. Bug 562806 - ppcle native build machine is down (details)
  4. v4934r6 (details)
  5. v4934r6 (details)
  6. v4934r6 (details)
  7. Bug 507611 - CTabFolder has wrong initial size (details)
  8. v4934r6 (details)
  9. Bug 562165 part3 - [Win32] Text editor should support ligatures on (details)
  10. Bug 563040 - Drop PPC64LE from eclipse platform build (details)
  11. v4934r6 (details)
  12. Bug 560197 - Remove SWT.MOZILLA related code (details)
  13. Use List.sort directly. (details)
  14. v4934r6 (details)
  15. Bug 553170 - NPE in PartRenderingEngine (details)
  16. Bug 548535 - 4.12 SWT.jar's version.txt incorrect (details)
  17. Bug 562774 - [GTK] Display#post sends events to withdrawn windows (details)
  18. Bug 562193 - [Win32] Enable Custom DarkTheme on Windows (details)
  19. v4934r6 (details)
  20. Bug 562463 - [GTK] No spinning/busy cursor is seen in (details)
  21. Bug 444560 - [Win32] Support background color for scrollbars (details)
  22. v4934r6 (details)
  23. Revert "Bug 562806 - ppcle native build machine is down" (details)
  24. Revert "Bug 563040 - Drop PPC64LE from eclipse platform build" (details)
  25. v4934r6 (details)
  26. v4934r6 (details)
  27. Bug 563018: Document dispose not required for Color (details)
  28. v4934r6 (details)
  29. Bug 560358 - [win32][Dark theme] Menu bar is not configurable (details)
Commit f8542f2ac4f69d858eef9cb20b9095e010eafe70 by nikita
Bug 562951 - [GTK] Eclipse crashes on start-up with OpenJDK 11 debug build

JNI code writes past the end of an array due to size mismatch
between gboolean (4 bytes) and jboolean (1 byte).

Remove g_object_get boolean overload to prevent this error in the future.

Change-Id: I66ab61498fd81b2e04a7147d06a2f88a240de572
Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.h
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os_stats.c
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/os.c
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java
Commit f3cd23ddfab550724653c8eef17a368a7f9e84dd by niraj modi
Bug 562165 part2 - [Win32] Text editor should support ligatures on
Windows
- Added Snippet377 to test Ligatures support using "Fira code" font.

Change-Id: Id8b21f0cdfd074df36bd8face37a6b73f93c3d9f
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
The file was addedexamples/org.eclipse.swt.snippets/previews/Snippet377.png
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/TextLayout.java
The file was addedexamples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet377.java
Commit 44ddaa682af412a6e883682b9d38343ebc13154e by alexander kurtakov
Bug 562806 - ppcle native build machine is down

Stop building ppc64le swt natives.

Change-Id: I677d76b3c64f2b50034ea9da59762d8f6bfdb3a6
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedbundles/org.eclipse.swt/buildSWT.xml
Commit e7eeb665b2b0027f80b3124b313a62d3f52045fb by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/common/library/make_common.mak
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/common/org/eclipse/swt/internal/Library.java
Commit 3b060e20de04bf7e930e3030c286fbd59d8df448 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit fc767ad83982960a78d82645f271f6683a7d0716 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit bfae5c9790e0327102cb5a33397b89aa08090059 by Paul Pazderski
Bug 507611 - CTabFolder has wrong initial size

CTabFolder performance was once improved by deferring some operations
including recalculation of tab height. Due to this asynchronous update
it might happen that a layout (and maybe other size related computation)
are performed using the outdated/wrong tab height.

Change-Id: Id9f96094c60234e35dc58d2c7b91e7a5f88a8d0f
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
The file was modifiedtests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_CTabFolder.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolder.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java
Commit 048a223027eed68acf675ecdf91af2a736603ddf by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 8b33522511068827c2bf4399522b66906bcec86c by niraj modi
Bug 562165 part3 - [Win32] Text editor should support ligatures on
Windows
- Updated Snippet377

Change-Id: I0fadced3b5c69d8a0a338219c8bb3be571bc9cd1
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
The file was modifiedexamples/org.eclipse.swt.snippets/previews/Snippet377.png
The file was modifiedexamples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet377.java
Commit 5617743dcbd4388d5c823dc2eebf2c512c9dfd37 by sravan kumar lakkimsetti
Bug 563040 - Drop PPC64LE from eclipse platform build

Change-Id: Ibb81aae0ca63e76f3b4d922bd4506f65dae9a183
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
The file was modifiedbundles/org.eclipse.swt/META-INF/p2.inf
The file was modifiedtests/org.eclipse.swt.tests.fragments.feature/feature.xml
Commit d7da245b3f5f532a4cca131d3854a118787e6e6a by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 13a201fc594576b80fcad1843401f006102a8268 by alexander kurtakov
Bug 560197 - Remove SWT.MOZILLA related code

Mozilla (XULRunner) support was removed many releases ago.

Change-Id: I1db8b399f0ae5e9cc35bbadab4b1e3656840c193
Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
The file was modifiedexamples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/browser-content.html
The file was modifiedexamples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet303.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT Browser/common/org/eclipse/swt/browser/Browser.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
The file was modifiedexamples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet260.java
The file was modifiedexamples/org.eclipse.swt.examples/src/examples_control.properties
Commit 39bf8b3a6413e6eb93082711f0e48631269de0aa by alexander kurtakov
Use List.sort directly.

Instead of Collections.sort(List)

Change-Id: I598da6be330e9ee001e78bca0f2d50e545f2e5e1
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedbundles/org.eclipse.swt.tools/Mac Generation/org/eclipse/swt/tools/internal/MacGenerator.java
The file was modifiedtests/org.eclipse.swt.tests.gtk/ManualTests/org/eclipse/swt/tests/gtk/snippets/Bug489640_ComboPerformanceTest.java
The file was modifiedbundles/org.eclipse.swt.tools/Mac Generation/org/eclipse/swt/tools/internal/DOMWriter.java
Commit a9e3ff7b537dec8d9c711b294425c7bcb0515c68 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 48c1bd953e01a608e739403c92649bf2e0217870 by lakshmi shanmugam
Bug 553170 - NPE in PartRenderingEngine

Added null check for application. Not sure how it becomes null here.

Change-Id: Ib96eae40387754ad66defbd0b89a73affe874982
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Commit f2ba416efc8d19fa6f4d7d019e63b670865a3abc by alexander kurtakov
Bug 548535 - 4.12 SWT.jar's version.txt incorrect

Stop putting version.txt in the jars.

Change-Id: I63708fc01c5a2e8797cb59b80ec546623de2e954
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedbundles/org.eclipse.swt/buildSWT.xml
The file was removedbundles/org.eclipse.swt/Eclipse SWT/common/version.txt
The file was modifiedbundles/org.eclipse.swt/buildFragment.xml
Commit 87983ef4bf5c63bd67a5591cd3032ad1a5b514e9 by alexander kurtakov
Bug 562774 - [GTK] Display#post sends events to withdrawn windows

Change-Id: I9bd47ffc0ce36549162cf1f54b43faba6907c583
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/GDK.java
Commit a9dca4fe20f3cece4ee5a10483591d52bf4f727d by Alexandr Miloslavskiy
Bug 562193 - [Win32] Enable Custom DarkTheme on Windows

1) Reduce the amount of copy&pasted code in Display.setData() in
   preparation for more keys in dark theme related patches

2) Prepare an emergency switch to disable all dark theme related tweaks.
   It's designed to be used in case of potential regressions.

Change-Id: Idcc56ece0f10ca89803a60e3b0100ab1ca55afb8
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Commit 360f2c8d1cbe2d9ca4a5bb549825c3243117e184 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit d5687e0c8df71a87837048a9eef441cc13a863cf by sravan kumar lakkimsetti
Bug 562463 - [GTK] No spinning/busy cursor is seen in
BusyIndicator.showWhile()

Change-Id: I63431d128ea584136565723ac0c09ea214e02430
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
The file was addedtests/org.eclipse.swt.tests.gtk/ManualTests/org/eclipse/swt/tests/gtk/snippets/Bug562463_BusyIndicatorIssue.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
Commit 6c7c628ae9f6e3cb9f0080fba82e3b0f24ccdced by niraj modi
Bug 444560 - [Win32] Support background color for scrollbars

This patch reworks the previous patch to meet the new design that will
cover this and other dark theme tweaks.

New design goals are:
1) Feature can be enabled without reflection in cross-platform
2) Feature can be enabled in run time
   This is the most typical scenario.
   For example, Eclipse and the product I'm working on both select the
   theme after reading application config, which happens after creating
   `Display`.
3) Feature can be configured individually
   Different SWT-based products need different settings to match their
   dark themes best.
4) There's an emergency switch to turn it off without recompiling code
   This can be done using system property:
   org.eclipse.swt.internal.win32.disableCustomThemeTweaks
5) It's more performance-friendly
   Previous approach used system property, which due to (2) needed to be
   re-read every time SWT wanted to know if it's active. (4) would have
   caused two properties to be read. (6) also fits nicely.

Additional changes:
6) Added code that tests whether theme is present. See comment in code.
7) Adjusted names to better indicate that setting has additional side
   effects and is not just about scrollbars.

Change-Id: Ie5bb957452dd4c0602b8c4fe3c32aedcc94a28ac
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Scrollable.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Slider.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Text.java
Commit 92f3a83e82679a48e417a4f9231ee29c48b5a254 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 669a4c51c5f6b6c0bb3690102ec9e68e7fa52413 by sravan kumar lakkimsetti
Revert "Bug 562806 - ppcle native build machine is down"

This reverts commit 44ddaa682af412a6e883682b9d38343ebc13154e.

Change-Id: I0b67f0ebcc62b31825e1a17eb4c7ef216d46d9d2
The file was modifiedbundles/org.eclipse.swt/buildSWT.xml
Commit 80c8f3f25741fe685aa6fe0c05cd0d431ddf1f31 by sravan kumar lakkimsetti
Revert "Bug 563040 - Drop PPC64LE from eclipse platform build"

This reverts commit 5617743dcbd4388d5c823dc2eebf2c512c9dfd37.

Change-Id: Ifb0f8549d5541fc05ee6515eaffdd550bdead258
The file was modifiedbundles/org.eclipse.swt/META-INF/p2.inf
The file was modifiedtests/org.eclipse.swt.tests.fragments.feature/feature.xml
Commit 0b84b6ad117276a07631d332347d137393d65b10 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 4b3c85e0207bf84882680bbb3a27d3fe4a971c36 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 359680f217565c4ee358bea50768cbec1b5cf402 by lars vogel
Bug 563018: Document dispose not required for Color

Colors have not really required disposal for a while, ever since
limited color display support was removed from SWT

Change-Id: Ia30aecfe4d00e6c15f7fd63ffa7967540d61c85f
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/Color.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/Color.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Color.java
Commit 9d0bbcac1bc083b0e858a3590c8ac03fdab49e44 by releng-bot
v4934r6
The file was modifiedbundles/org.eclipse.swt/pom.xml
Commit 0a02b26d9e63e6218f57c3699c2a225028a4a2ff by niraj modi
Bug 560358 - [win32][Dark theme] Menu bar is not configurable

This approach has some drawbacks, see code comment near
`Display.MENUBAR_FOREGROUND_COLOR_KEY`. One the other hand, it's much
easier to achieve compared to fully owner drawn menus.

I also fixed `OS.HBMMENU_CALLBACK` which was wrong on 64-bit. Windows
seems to recognize the wrong value, though.

For API design goals, see recent patch for Bug 444560.

Change-Id: I738d74bf03b173f5e8149648b83b6b397da295f9
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Menu.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/MenuItem.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Shell.java
The file was modifiedbundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java
The file was addedtests/org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/tests/win32/snippets/Bug560358_DarkMenuBar.java