SuccessChanges

Summary

  1. Bug 471328: [Wizard] Creating a model without a containing project (details)
  2. Bug 470811: [Tree Table] Destroy TreeTable doesn't work fine (details)
  3. 443799: [Code Quality] Cleanup code according to FindBugs results (details)
  4. 443799: [Code Quality] Cleanup code according to FindBugs results (details)
  5. 443799: [Code Quality] Cleanup code according to FindBugs results (details)
  6. 443799: [Code Quality] Cleanup code according to FindBugs results (details)
  7. 443799: [Code Quality] Cleanup code according to FindBugs results (details)
  8. Bug 473183: [Tests] Improve test performance by sharing diagram editors (details)
  9. Bug 473183: [Tests] Improve test performance by sharing diagram editors (details)
Commit 84dd9b4cc6bfdba7eaae74ed90aa7f84b4325f77 by Gerrit Code Review @ Eclipse.org
Bug 471328: [Wizard] Creating a model without a containing project results in an NPE exception
https://bugs.eclipse.org/bugs/show_bug.cgi?id=471328

- modified the validation of the NewModelFilePage to prevent users to create a model outside a proper container

Signed-off-by: Quentin Le Menez <quentin.lemenez@cea.fr>
The file was modifiedplugins/uml/diagram/org.eclipse.papyrus.uml.diagram.wizards/src/org/eclipse/papyrus/uml/diagram/wizards/messages/messages.properties
The file was modifiedplugins/uml/diagram/org.eclipse.papyrus.uml.diagram.wizards/src/org/eclipse/papyrus/uml/diagram/wizards/messages/Messages.java
The file was modifiedplugins/uml/diagram/org.eclipse.papyrus.uml.diagram.wizards/src/org/eclipse/papyrus/uml/diagram/wizards/pages/NewModelFilePage.java
Commit 5778f720c8d364f07ee22a7502f564bcfc287040 by Gerrit Code Review @ Eclipse.org
Bug 470811: [Tree Table] Destroy TreeTable doesn't work fine
https://bugs.eclipse.org/bugs/show_bug.cgi?id=470811

- Manage the NullPointerException at the deletion
- Manage an other NullPointerExceptionat the opening
- Manage a problem of dispose for the index and label header
- Add the JUnit tests for this bug

Change-Id: I1cb14fb72f3ca46059ea229c1259063df2c5ad3d
Signed-off-by: Nicolas FAUVERGUE <nicolas.fauvergue@all4tec.net>
The file was modifiedplugins/infra/nattable/org.eclipse.papyrus.infra.nattable/src/org/eclipse/papyrus/infra/nattable/manager/table/TreeNattableModelManager.java
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.generic.tests/resources/bugs/bug470811/OpenAndDeleteTest.notation
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.generic.tests/resources/bugs/bug470811/OpenAndDeleteTest.uml
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.clazz.config.tests/resources/bugs/bug470811/OpenAndDeleteTest.uml
The file was modifiedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.clazz.config.tests/src/org/eclipse/papyrus/uml/nattable/clazz/config/tests/tests/AllTests.java
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.clazz.config.tests/resources/bugs/bug470811/OpenAndDeleteTest.di
The file was modifiedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.clazz.config.tests/META-INF/MANIFEST.MF
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.clazz.config.tests/resources/bugs/bug470811/OpenAndDeleteTest.notation
The file was modifiedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.generic.tests/src/org/eclipse/papyrus/uml/nattable/generic/tests/tests/AllTests.java
The file was modifiedplugins/infra/nattable/org.eclipse.papyrus.infra.nattable/src/org/eclipse/papyrus/infra/nattable/manager/table/AbstractNattableWidgetManager.java
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.clazz.config.tests/src/org/eclipse/papyrus/uml/nattable/clazz/config/tests/bugs/OpenAndDeleteTest.java
The file was modifiedplugins/infra/nattable/org.eclipse.papyrus.infra.nattable/src/org/eclipse/papyrus/infra/nattable/dataprovider/AbstractLabelHeaderDataProvider.java
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.generic.tests/resources/bugs/bug470811/OpenAndDeleteTest.di
The file was modifiedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.generic.tests/META-INF/MANIFEST.MF
The file was addedtests/junit/plugins/uml/nattable/org.eclipse.papyrus.uml.nattable.generic.tests/src/org/eclipse/papyrus/uml/nattable/generic/tests/bugs/OpenAndDeleteTest.java
The file was modifiedplugins/infra/nattable/org.eclipse.papyrus.infra.nattable/src/org/eclipse/papyrus/infra/nattable/manager/table/NattableModelManager.java
The file was modifiedplugins/infra/nattable/org.eclipse.papyrus.infra.nattable/src/org/eclipse/papyrus/infra/nattable/dataprovider/AbstractIndexHeaderDataProvider.java
Commit 40c937a2fb1889edf528c4e439cbc230a801ee0f by Camille Letavernier
443799: [Code Quality] Cleanup code according to FindBugs results
https://bugs.eclipse.org/bugs/show_bug.cgi?id=443799

- Fix 2 issues in infra.core
The file was modifiedplugins/infra/core/org.eclipse.papyrus.infra.core/src/org/eclipse/papyrus/infra/core/resource/additional/AdditionalResourcesModel.java
The file was modifiedplugins/infra/core/org.eclipse.papyrus.infra.core/src/org/eclipse/papyrus/infra/core/services/SaveLayoutBeforeClose.java
Commit d25c0a3bd415e9a65f5abf75f891e32e1b97d48e by Camille Letavernier
443799: [Code Quality] Cleanup code according to FindBugs results
https://bugs.eclipse.org/bugs/show_bug.cgi?id=443799

- Fix issues in infra.gmfdiag.common
The file was modifiedplugins/infra/gmfdiag/org.eclipse.papyrus.infra.gmfdiag.common/src/org/eclipse/papyrus/infra/gmfdiag/common/providers/AbstractViewProvider.java
The file was modifiedplugins/infra/gmfdiag/org.eclipse.papyrus.infra.gmfdiag.common/src/org/eclipse/papyrus/infra/gmfdiag/common/commands/CreateEditBasedElementCommand.java
The file was modifiedplugins/infra/gmfdiag/org.eclipse.papyrus.infra.gmfdiag.common/src/org/eclipse/papyrus/infra/gmfdiag/common/GmfMultiDiagramDocumentProvider.java
The file was modifiedplugins/infra/gmfdiag/org.eclipse.papyrus.infra.gmfdiag.common/src/org/eclipse/papyrus/infra/gmfdiag/common/providers/ThemeInitializerManager.java
The file was modifiedplugins/infra/gmfdiag/org.eclipse.papyrus.infra.gmfdiag.common/src/org/eclipse/papyrus/infra/gmfdiag/common/editpolicies/PapyrusPopupBarEditPolicy.java
The file was modifiedplugins/infra/gmfdiag/org.eclipse.papyrus.infra.gmfdiag.common/src/org/eclipse/papyrus/infra/gmfdiag/common/utils/MDTUtil.java
Commit 4ef6469ed77914d52ca5fd3989ec8086a5d8dcc5 by Camille Letavernier
443799: [Code Quality] Cleanup code according to FindBugs results
https://bugs.eclipse.org/bugs/show_bug.cgi?id=443799

- Fix issues in infra.gmfdiag.css
The file was modifiedplugins/infra/gmfdiag/css/org.eclipse.papyrus.infra.gmfdiag.css/src/org/eclipse/papyrus/infra/gmfdiag/css/theme/ThemeManager.java
The file was modifiedplugins/infra/gmfdiag/css/org.eclipse.papyrus.infra.gmfdiag.css/src/org/eclipse/papyrus/infra/gmfdiag/css/engine/WorkspaceCSSEngine.java
The file was modifiedplugins/infra/gmfdiag/css/org.eclipse.papyrus.infra.gmfdiag.css/src/org/eclipse/papyrus/infra/gmfdiag/css/engine/BaseCSSEngine.java
The file was modifiedplugins/infra/gmfdiag/css/org.eclipse.papyrus.infra.gmfdiag.css/src/org/eclipse/papyrus/infra/gmfdiag/css/engine/ProjectCSSEngine.java
Commit 6c88e623bdd5c30129f7f6d3fb73378c7ac52c61 by Camille Letavernier
443799: [Code Quality] Cleanup code according to FindBugs results
https://bugs.eclipse.org/bugs/show_bug.cgi?id=443799

- Fix issues in infra.widgets
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/editors/MultipleValueSelectorDialog.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/providers/CollectionContentProvider.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/providers/TreeCollectionContentProvider.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/providers/UnchangedObject.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/providers/UnsetObject.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/providers/EmptyContentProvider.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/editors/ReferenceDialog.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/editors/AbstractEditor.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/editors/MultipleValueEditor.java
The file was modifiedplugins/infra/widget/org.eclipse.papyrus.infra.widgets/src/org/eclipse/papyrus/infra/widgets/editors/StyledTextReferenceDialog.java
Commit ec9d4a7356f64575d0d9cb58777b197271dde9b1 by Camille Letavernier
443799: [Code Quality] Cleanup code according to FindBugs results
https://bugs.eclipse.org/bugs/show_bug.cgi?id=443799

- Fix issues in uml.tools
The file was modifiedplugins/uml/tools/org.eclipse.papyrus.uml.tools/src/org/eclipse/papyrus/uml/tools/util/MultiplicityParser.java
The file was modifiedplugins/uml/tools/org.eclipse.papyrus.uml.tools/src/org/eclipse/papyrus/uml/tools/model/UmlUtils.java
The file was modifiedplugins/uml/tools/org.eclipse.papyrus.uml.tools/src/org/eclipse/papyrus/uml/tools/databinding/OwnerObservableValue.java
Commit 4f8d07ae18b85d0ccbbb51e3a0083a24c9892751 by Christian W. Damus
Bug 473183: [Tests] Improve test performance by sharing diagram editors
https://bugs.eclipse.org/bugs/show_bug.cgi?id=473183

Implement a new test rule, employed by the AbstractPapyrusTestCase in
the UML common diagram test API, that creates a single editor shared
by all test cases in the suite class.  The contents of the UML and
notation resources are cleaned up after each test case to restore
them to the initial state as configured by the command that the test
suite uses to create the diagram.

Test-suite classes may be annotated with @StateNotShareable to opt out
of this sharing of diagram editors, if necessary.  This is done for
a handful of test suites that exhibit errors and other failures when
attempting to share a diagram editor.

(Cherry-picked from Mars a814078)
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.interactionoverview.tests/src/org/eclipse/papyrus/uml/diagram/interactionoverview/tests/canonical/TestInteractionOverviewDiagramChildNode.java
The file was modifiedtests/junit/plugins/core/org.eclipse.papyrus.tests/Papyrus ALL tests.launch
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.clazz.tests/test/org/eclipse/papyrus/uml/diagram/clazz/test/canonical/TestStaticFeatureRepresentation.java
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.tests/.classpath
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.sequence.tests/src/org/eclipse/papyrus/uml/diagram/sequence/tests/bug/TestDecompositionMove_364812.java
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.sequence.tests/src/org/eclipse/papyrus/uml/diagram/sequence/tests/bug/m7/TestGraphicalGate_389531.java
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.sequence.tests/src/org/eclipse/papyrus/uml/diagram/sequence/tests/bug/TestAdvancedDragDrop_364696.java
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.interactionoverview.tests/src/org/eclipse/papyrus/uml/diagram/interactionoverview/tests/canonical/TestInteractionOverviewDiagramActivityTN.java
The file was addedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.tests/src/org/eclipse/papyrus/uml/diagram/tests/canonical/SharedTestSuiteState.java
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.sequence.tests/src/org/eclipse/papyrus/uml/diagram/sequence/tests/bug/TestDecompositionCombinedFragment_364813.java
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.tests/src/org/eclipse/papyrus/uml/diagram/tests/canonical/AbstractPapyrusTestCase.java
The file was addedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.tests/src/org/eclipse/papyrus/uml/diagram/tests/canonical/StateNotShareable.java
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.tests/META-INF/MANIFEST.MF
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.tests/.settings/org.eclipse.jdt.core.prefs
Commit 1d13cd3bb367c6c4d1c7d52b564e673063d80300 by Christian W. Damus
Bug 473183: [Tests] Improve test performance by sharing diagram editors
https://bugs.eclipse.org/bugs/show_bug.cgi?id=473183

Disable diagram-editor sharing for a Sequence Diagram test suite that
bombs when sharing the editor.

(Cherry-picked from Mars cb45bd7)
The file was modifiedtests/junit/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.sequence.tests/src/org/eclipse/papyrus/uml/diagram/sequence/tests/bug/m7/TestDurationConstraint_402967.java