FailedChanges

Summary

  1. GH-1535: As a smith I want to migrate the HLC Builder to use LSP Server (details)
Commit e5dd98674d35c20b57e9e187787ee42f06492753 by noreply
GH-1535: As a smith I want to migrate the HLC Builder to use LSP Server
(Part 4) (#1547)
* fix double read of resource in case of issues

* integrated some N4JS subclasses into xtext copies

* some fixes: NPEs, wrong projects, JavaDoc

* add validation for wrong argument

* add validation for wrong argument and test

* enable restart of LSP server

* fix NPE when adding a FQN

* merge (copy/paste) some changes from GH-1538

* add isIndexOnly to IProjectConfig to be checked when creating in
Builder

* add isIndexOnly to IProjectConfig to be checked when creating in
Builder

* fix test helpers to cope with building libs from mvn call

* lots of refactorings to merge N4JS- and X-classes, and to reduce
lambdas

* refactored BuildRequest, introduced IssueAcceptor

* introduce ProjectStateHolder to encapsule project state

* refactor (move) project state persister

* store and load validation issues to/from disk

* switch to new compiler for n4js-libs

* NPE fix

* fix wrong return values

* add initializers to Issues

* propagate exceptions during validation

* fix sorting of Non-comparables (was never working)

* support clean and non-persisting builds

* refactor XIncrementalBuilder: extract inner classes

* add switch to clean before compile or lsp

* add option --noPersist

* clean-up of changes due to github.com/eclipse/xtext-core/issues/1209

* fix missing package.json in the source containers

* fix test and align doc of CliCompileResult

* fix wrong path

* move up assignment since resourceSet is used already during build

* clean-ups: remove obsolete code

* enable shadowing until GH-1314 is done

* fix project discovery for yarn main node_modules folder and npms

* fix getAllResources to exclude files from node_modules folders

* fix performance issue: introduce caching for external libraries

* refactoring to reduce lambdas

* set as external when inside of node_modules folder

* set to warning due to GH-1314

* add experimental GH-1552 (inactive)

* replace the old n4jsc.jar by the new one

* fix tests due to switch from error to warning

* adjust n4js-libs to new n4jsc.jar

* adjust help text of n4jsc.jar

* remove obsolete "--clean" call to n4jsc.jar

* comment TODO

* support writing test catalog in new n4jsc

* fix tag regarding semver syntax

* support cleaning flow information to reduce memory footprint

* rename to more explicit name

* use immutable view instead of copy

* filter file types to n4js relevant types

* support counting of transpiled or deleted files during build

* use data of generated files instead of scan file system

* disable renaming of old hlc

* add debug outputs

* more debug messages

* more debug messages 2

* more debug messages 3

* more debug messages 4

* next try

* next try

* next try

* more debug messages 5

* more debug messages 6

* catch Throwables

* more debug messages 7

* more debug messages 8

* reverted debug output, SystemExitRedirector. Incorporate review
feedback

* revert deletion

* add tests for ProjectDiscoveryHelper

* unset tag
The file was removedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSLanguageServerImpl.java
The file was modifiedn4js-libs/packages/n4js-cli/package.json (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/ProjectStatePersisterConfig.java
The file was modifiedn4js-libs/packages/n4js-cli/tests/test-n4jsc.js (diff)
The file was modifiedn4js-libs/packages/n4js-mangelhaft-cli/tests/npm-test.sh (diff)
The file was removedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSProjectManager.java
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/DocumentResourceProvider.java
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/build/XBuildRequest.java (diff)
The file was modifiedtesthelpers/org.eclipse.n4js.cli.tests.helper/src/org/eclipse/n4js/cli/helper/CliCompileResult.java (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/external/HlcExternalLibraryWorkspace.java (diff)
The file was removedplugins/org.eclipse.n4js/src/org/eclipse/n4js/projectModel/lsp/ex/ISourceFolderEx.java
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/postprocessing/N4JSPostProcessor.java (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/internal/lsp/N4JSProjectConfig.java (diff)
The file was removedplugins/org.eclipse.n4js/src/org/eclipse/n4js/projectModel/lsp/ex/IWorkspaceConfigEx.java
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/ReflectionUtils.java (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/utils/ProjectDiscoveryHelper.java (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/validation/validators/PolyfillValidatorFragment.java (diff)
The file was modifiedversion.json (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/N4JSIdeModule.java (diff)
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmSimple1.pdt
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/lsp/LspServer.java (diff)
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/yarnSimple3.pdt
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/hover/N4JSHoverService.java (diff)
The file was modifiedtests/org.eclipse.n4js.cli.tests/src/org/eclipse/n4js/cli/frontend/tests/FrontendHelpTest.java (diff)
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/InstallCompileRunN4jscExternalWithSingleProjectCompileTest.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/findReferences/XWorkspaceResourceAccess.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSOutputConfigurationProvider.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/META-INF/MANIFEST.MF (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/build/XStatefulIncrementalBuilder.java
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/validation/N4JSIssue.java
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/N4jscOptionsValidater.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ui/src/org/eclipse/n4js/ui/internal/N4JSEclipseModel.java (diff)
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/compiler/IssueSerializer.java (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/ProjectStateHolder.java
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/N4jscOptions.java (diff)
The file was modifiedplugins/org.eclipse.n4js.flowgraphs/src/org/eclipse/n4js/flowgraphs/dataflow/DataFlowVisitor.java (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/DefaultBuildRequestFactory.java
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/postprocessing/ASTMetaInfoCache.java (diff)
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmNodeModules2.pdt
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/yarnSimple1.pdt
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/validation/N4JSDiagnosticConverter.java
The file was removedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/HashedFileContent.java
The file was modifiedtesthelpers/org.eclipse.n4js.cli.tests.helper/src/org/eclipse/n4js/cli/helper/N4jscTestLanguageClient.java (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/internal/lsp/N4JSSourceFolder.java (diff)
The file was modifiedplugins/org.eclipse.n4js.tester/src/org/eclipse/n4js/tester/TestDiscoveryHelper.java (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/ProjectStatePersister.java
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/compiler/N4jscCompiler.java (diff)
The file was removedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSBuildManager.java
The file was modifiedtests/org.eclipse.n4js.packagejson.xpect.ui.tests/xpect/GH_991_nested-node-modules-folder/P/package.json.xt (diff)
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmSimple2.pdt
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/InstallCompileRunN4jscExternalWithDefinitionFilesTest.java (diff)
The file was modifiedtests/org.eclipse.n4js.cli.tests/src/org/eclipse/n4js/cli/frontend/tests/FrontendCompileTest.java (diff)
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/n4idl/ObsoleteVersionedImportsTest.xtend (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSProjectDescriptionFactory.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/build/XIncrementalBuilder.java (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/projectModel/lsp/IN4JSSourceFolder.java (diff)
The file was addedn4js-libs/packages/n4js-cli/src/index.n4js
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/N4jscFactory.java (diff)
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/InstallCompileRunN4jscExternalMainModuleTest.java (diff)
The file was modifiedtesthelpers/org.eclipse.n4js.cli.tests.helper/src/org/eclipse/n4js/cli/N4jscTestOptions.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ts/src/org/eclipse/n4js/ts/findReferences/TargetURIKey.java (diff)
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/InstallCompileRunN4jscExternalWithSingleFileCompileTest.java (diff)
The file was addedtests/org.eclipse.n4js.hlc.tests/probands/external_shadowNestedNodeModules/node_modules/dep/src-gen/Dep.js
The file was modifiedlsp-clients/n4js-vscode-extension/src/extension.n4js (diff)
The file was modifiedtesthelpers/org.eclipse.n4js.cli.tests.helper/src/org/eclipse/n4js/cli/helper/InProcessExecuter.java (diff)
The file was modifiedplugins/org.eclipse.n4js.flowgraphs/src/org/eclipse/n4js/flowgraphs/FlowAnalyser.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/XDefaultProjectDescriptionFactory.java (diff)
The file was removedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/ProjectStatePersister.java
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/IBuildRequestFactory.java
The file was removedplugins/org.eclipse.n4js/src/org/eclipse/n4js/projectModel/lsp/ex/IProjectConfigEx.java
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmSimple5.pdt
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/yarnMultiPackages1.pdt
The file was addedtests/org.eclipse.n4js.cli.tests/src/org/eclipse/n4js/cli/projectdiscovery/tests/ProjectDiscoveryTest.java
The file was removedplugins/org.eclipse.n4js/src/org/eclipse/n4js/projectModel/lsp/IN4JSWorkspaceConfig.java
The file was addedtests/org.eclipse.n4js.cli.tests/src/org/eclipse/n4js/cli/projectdiscovery/tests/CreateProjectStructureUtils.java
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/InstallFromManifestCompileRunN4jscExternalImportsTest.java (diff)
The file was modifiedtests/org.eclipse.n4js.packagejson.xpect.ui.tests/xpect/version/error/package.json.xt (diff)
The file was modifiedplugins/org.eclipse.n4js.generator.headless/src/org/eclipse/n4js/generator/headless/HeadlessHelper.java (diff)
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/N4jscMain.java (diff)
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/N4jscScopedProjectTest.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/N4JSIdeSetup.java (diff)
The file was modifiedtests/org.eclipse.n4js.cli.tests/src/org/eclipse/n4js/cli/frontend/tests/FrontendLspTest.java (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/build/XBuildResult.java
The file was modifiedn4js-libs/packages/n4js-mangelhaft-cli/src/n4js/org/eclipse/n4js/mangelhaft/runner/node/NodeTestAPI.n4js (diff)
The file was modifiedn4js-libs/packages/n4js-mangelhaft-cli/src/n4js/org/eclipse/n4js/mangelhaft/runner/node/NodeTestCLI.n4js (diff)
The file was modifiedtests/org.eclipse.n4js.lang.tests/src/org/eclipse/n4js/ide/server/ProjectStatePersisterTest.java (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/HashedFileContent.java
The file was modifiedn4js-libs/packages/n4js-mangelhaft-cli/src/n4js/org/eclipse/n4js/mangelhaft/runner/node/NodeTestOptions.n4js (diff)
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/InstallCompileRunN4jscExternalShadowNestedNodeModulesTest.java (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/XProjectManager.java (diff)
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmNodeModules1.pdt
The file was removedn4js-libs/packages/n4js-cli/index.n4jsd
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/internal/N4JSProject.java (diff)
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmNodeModules3.pdt
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/LspLogger.java (diff)
The file was modifiedtesthelpers/org.eclipse.n4js.cli.tests.helper/META-INF/MANIFEST.MF (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/validation/validators/N4JSFlowgraphValidator.java (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSRequestManager.java
The file was removedn4js-libs/packages/n4js-cli/index.js
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/AT_IDEBUG_542_missing_dep_to_project_under_testTest.java (diff)
The file was modifiedplugins/org.eclipse.n4js.cli/src/org/eclipse/n4js/cli/compiler/N4jscLanguageClient.java (diff)
The file was modifiedplugins/org.eclipse.n4js/META-INF/MANIFEST.MF (diff)
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/yarnSimple2.pdt
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/internal/lsp/N4JSWorkspaceConfig.java (diff)
The file was modifiedplugins/org.eclipse.n4js.cli/META-INF/MANIFEST.MF (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/validation/messages.properties (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/XWorkspaceManager.java (diff)
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/postprocessing/ASTFlowInfo.java (diff)
The file was removedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSInternalStatefulIncrementalBuilder.java
The file was modifiedplugins/org.eclipse.n4js/src/org/eclipse/n4js/validation/N4JSValidator.xtend (diff)
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/AT_IDEBUG_532_transpilecrashTest.java (diff)
The file was modifiedlsp-clients/n4js-vscode-extension/src-gen/extension.js (diff)
The file was modifiedn4js-libs/yarn.lock (diff)
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/XLanguageServerImpl.java (diff)
The file was removedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/N4JSWorkspaceManager.java
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/XBuildManager.java (diff)
The file was modifiedplugins/org.eclipse.n4js.tester/src/org/eclipse/n4js/tester/TestCatalogSupplier.java (diff)
The file was modifiedtesthelpers/org.eclipse.n4js.cli.tests.helper/src/org/eclipse/n4js/cli/helper/GeneratedJSFilesCounter.java (diff)
The file was modifiedreleng/org.eclipse.n4js.libs.build/src/org/eclipse/n4js/libs/build/BuildN4jsLibs.java (diff)
The file was modifiedplugins/org.eclipse.n4js.flowgraphs/src/org/eclipse/n4js/flowgraphs/N4JSFlowAnalyser.java (diff)
The file was modifiedplugins/org.eclipse.n4js.cli/pom.xml (diff)
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/ParallelBuildManager.java
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/build/XURIBasedFileSystemAccessFactory.java
The file was modifiedtests/org.eclipse.n4js.hlc.tests/src/org/eclipse/n4js/hlc/tests/N4jscBasicTest.java (diff)
The file was removedplugins/org.eclipse.n4js/src/org/eclipse/n4js/projectModel/lsp/IN4JSProjectConfig.java
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmSimple4.pdt
The file was addedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/xtext/server/IssueAcceptor.java
The file was addedtests/org.eclipse.n4js.cli.tests/ProjectDiscoveryTests/npmSimple3.pdt
The file was modifiedplugins/org.eclipse.n4js.ide/src/org/eclipse/n4js/ide/server/FileBasedWorkspaceInitializer.java (diff)
The file was modifiedtools/org.eclipse.n4js.hlc/pom.xml (diff)