SuccessChanges

Summary

  1. Remove redundant "static" qualifier from enum declarations (details)
  2. GitmoduleEntry: Remove redundant import of class from same package (details)
  3. Reorder modifiers to follow Java Language Specification (details)
  4. Use indexOf(char) and lastIndexOf(char) rather than String versions (details)
  5. SimilarityRenameDetector: Fix inconsistent indentation (details)
  6. Revert "Prepend hostname to subsection used to store file timestamp (details)
Commit 9be93b7991d6c1d82ba606d60bfd3b2971a60123 by david pursehouse
Remove redundant "static" qualifier from enum declarations
Nested enum types are implicitly static.
Change-Id: Id3d7886087494fb67bc0d080b4a3491fb4baac19 Signed-off-by:
David Pursehouse <david.pursehouse@gmail.com>
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/IndexDiff.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/GitProtocolConstants.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/diff/DiffEntry.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/errors/NoMergeBaseException.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/ProcessResult.java
The file was modifiedorg.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/ShowCommands.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileObjectDatabase.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/ignore/internal/Strings.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/ignore/IgnoreNode.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/RefUpdate.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/patch/FormatError.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/TransportProtocol.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/GitDateFormatter.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/RebaseTodoLine.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/ReceiveCommand.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/RemoteRefUpdate.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/patch/FileHeader.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/attributes/Attribute.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackWriter.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/patch/BinaryHunk.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/api/CheckoutCommand.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/PackParser.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/UploadPack.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/diff/DiffConfig.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/treewalk/TreeWalk.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/CoreConfig.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/PacketLineIn.java
The file was modifiedorg.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/LfsStore.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/diff/Edit.java
The file was modifiedorg.eclipse.jgit.test/tst/org/eclipse/jgit/lib/ConfigTest.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/ketch/KetchLeader.java
Commit 2d1acae6d8a5e90e7bb5192ce1b99f2e2f436775 by david pursehouse
GitmoduleEntry: Remove redundant import of class from same package
Change-Id: I613489a937dd53780b0abfd6b1bd0ed964a5ddd8 Signed-off-by:
David Pursehouse <david.pursehouse@gmail.com>
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/GitmoduleEntry.java
Commit 064834d350d38f672a69947cf924f56d52bd1274 by david pursehouse
Reorder modifiers to follow Java Language Specification
The Java Language Specification recommends listing modifiers in the
following order:
1. Annotations 2. public 3. protected 4. private 5. abstract 6. static
7. final 8. transient 9. volatile 10. synchronized 11. native 12.
strictfp
Not following this convention has no technical impact, but will reduce
the code's readability because most developers are used to the standard
order.
This was detected using SonarLint.
Change-Id: I9cddecb4f4234dae1021b677e915be23d349a380 Signed-off-by:
David Pursehouse <david.pursehouse@gmail.com>
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/ignore/FastIgnoreRule.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/RebaseTodoLine.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/treewalk/WorkingTreeIterator.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/IndexDiff.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/api/PullCommand.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsObjDatabase.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/reftable/ReftableDatabase.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/PackFile.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/FS_POSIX.java
The file was modifiedorg.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/DiffAlgorithms.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/ObjectDirectory.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/SystemReader.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/merge/MergeAlgorithm.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/FS.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/RelativeDateFormatter.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/GC.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/reftable/BlockWriter.java
The file was modifiedorg.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/ObjectFileServlet.java
The file was modifiedorg.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/TextHashFunctions.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/RefDirectory.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/InflaterCache.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/ignore/internal/Strings.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectIdOwnerMap.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/nls/NLS.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/treewalk/FileTreeIterator.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/WalkEncryption.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackExt.java
The file was modifiedorg.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/SmudgeFilter.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectReader.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/FS_Win32_Cygwin.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/LockFile.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/ReceivePack.java
The file was modifiedorg.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/CleanFilter.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/patch/CombinedHunkHeader.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectLoader.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/FS_Win32.java
The file was modifiedorg.eclipse.jgit.test/tst/org/eclipse/jgit/util/GitDateParserBadlyFormattedTest.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/Base64.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/storage/file/FileBasedConfig.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/RepositoryCache.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/Monitoring.java
The file was modifiedorg.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/GcOrphanFilesTest.java
The file was modifiedorg.eclipse.jgit.test/exttst/org/eclipse/jgit/patch/EGitPatchHistoryTest.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/RefUpdate.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/errors/TranslationBundleException.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectInserter.java
Commit 6a72f2943d31d0e5a3ed402b5b769dde17f691f5 by david pursehouse
Use indexOf(char) and lastIndexOf(char) rather than String versions
An indexOf or lastIndexOf call with a single letter String can be made
more performant by switching to a call with a char argument.
Found with SonarLint.
As a side-effect of this change, we no longer need to suppress the
NON-NLS warnings.
Change-Id: Id44cb996bb74ed30edd560aa91fd8525aafdc8dd Signed-off-by:
David Pursehouse <david.pursehouse@gmail.com>
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/diff/SimilarityRenameDetector.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/ChangeIdUtil.java
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/attributes/AttributesRule.java
Commit fdabbe67e2db88d6c0bb9cf696ff681a0812814a by david pursehouse
SimilarityRenameDetector: Fix inconsistent indentation
Replace space indentation with tab indentation
Change-Id: Ic130d3bde5d3a73d8f5c6225974153573722d05b Signed-off-by:
David Pursehouse <david.pursehouse@gmail.com>
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/diff/SimilarityRenameDetector.java
Commit abb461533fccfd59117c3415cf9c0ed06e460473 by matthias sohn
Revert "Prepend hostname to subsection used to store file timestamp
resolution"
This reverts commit e102bbed995f0e6d3a1a8e5db6d08f9804fd3260.
Resolving the hostname comes with a performance penalty. We no longer
store the timestamp resolution in the global git config which might be
copied around to other machines but in a dedicated jgit config meant for
automatically determined options like timestamp resolution. Hence there
is no strong reason anymore to have a hardware specific identifier in
the subsection name of file timestamp resolution options.
Bug: 560414 Change-Id: If8dcabe981eb1792db84643850faa6033f14b1cf
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
The file was modifiedorg.eclipse.jgit/src/org/eclipse/jgit/util/FS.java