SuccessChanges

Summary

  1. Bug 394726 - [pull up] Pull up adds redundant qualifier (details)
  2. Bug 550334 - clean up: convert for loops enhanced results in NPE (details)
Commit 4e7be8c78f198f1e1115c56916533300ab9b81e6 by kenneth
Bug 394726 - [pull up] Pull up adds redundant qualifier
- Add check to see if qualifier is needed or if the import is enough
- Add test cases
Change-Id: I62bf19c666aeb7d80e958defb9b523ab9a59ec9f Signed-off-by:
Kenneth Styrberg <kenneth@kean.nu>
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/in/p/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/out/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/in/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/in/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/out/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/in/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/in/p/A.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/in/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/in/p/A.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/in/p/A.java
The file was modifiedorg.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/PullUpTests.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/in/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/in/p/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/out/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/out/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/out/p/A.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/out/p/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/in/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/out/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/out/p/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/out/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/out/q/Asuper.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/in/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/out/p/A.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/out/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/in/p/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod3/in/p/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/out/p/A.java
The file was modifiedorg.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/structure/PullUpRefactoringProcessor.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/in/q/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/in/p/A.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod2/out/p/C.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod1/out/p/A.java
The file was addedorg.eclipse.jdt.ui.tests.refactoring/resources/PullUp/testFieldMethod4/out/p/C.java
Commit 50b5c734f20a0e8bb0febfc5f9d1dd00b81e2078 by Jeff Johnston
Bug 550334 - clean up: convert for loops enhanced results in NPE
- fix ConvertForLoopOperation.validateBody() to invalidate body
if we are dealing with a Collections for loop and an array index
is found for the for index variable
- add new tests for this in CleanUpTest and ConvertForLoopQuickFixTest
Change-Id: I23796d0e88e2b2bf579348dc762b2d2567947524
The file was modifiedorg.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/ConvertForLoopQuickFixTest.java
The file was modifiedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/ConvertForLoopOperation.java
The file was modifiedorg.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest.java