SuccessChanges

Summary

  1. Bug 549470 - Refactor more fixes/cleanups used by jdt.ls (details)
  2. Bug 549457 - Autobuild does nothing on org.eclipse.jdt.core.prefs change (details)
  3. Bug 540337 - Bad Quickfix dialog reformats (details)
  4. Bug 549555 - Temp *.class files not deleted in system temp folder (details)
  5. Bug 549442 - Rework usages of AbstractUIPlugin#imageDescriptorFromPlugin (details)
Commit a88222fc103cb7de7d4568d11b955957d5eaa085 by Jeff Johnston
Bug 549470 - Refactor more fixes/cleanups used by jdt.ls
- fix StubUtility2Core.createImplementationStub() to use
CodeGeneration.getMethodBodyContent() to get any templates
used
- create UnusedCleanUpCore based on UsusedCleanUp
- create JavadocTagsSubProcessorCore
- move ReplaceRewrite. StatementRewrite,
AddUnimplementedMethodsOperation, NoCommentSourceRangeComputer
to jdt.core.manipulation
- create TypeParametersFixCore based on TypeParametersFix
- create UnimplementedCodeFixCore based on UnimplementedCodeFix
- create UnusedCodeFixCore based on UnusedCodeFix
- change TypeParametersFix, UnimplementedCodeFix, and
UnusedCodeFix to use their core counterparts
- change ModifierCorrectionSubProcessor to use core fix classes
- convert for loops to foreach loops where applicable
Change-Id: I6fb25641f37760880955baf300701d0c498983fc Signed-off-by: Jeff
Johnston <jjohnstn@redhat.com>
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/TypeParametersFixCore.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/UnusedCodeFixCore.java
The file was modifiedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/TypeParametersFix.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/ModifierCorrectionSubProcessor.java
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/fix/UnusedCodeCleanUpCore.java
The file was modifiedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/codemanipulation/StubUtility2Core.java
The file was modifiedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/UnusedCodeFix.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/UnimplementedCodeFixCore.java
The file was removedorg.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/util/NoCommentSourceRangeComputer.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/StatementRewrite.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ReplaceRewrite.java
The file was removedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/dom/StatementRewrite.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/AddUnimplementedMethodsOperation.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/MethodsSourcePositionComparator.java
The file was removedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/util/MethodsSourcePositionComparator.java
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/text/correction/JavadocTagsSubProcessorCore.java
The file was removedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/dom/ReplaceRewrite.java
The file was modifiedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/UnimplementedCodeFix.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/NoCommentSourceRangeComputer.java
The file was removedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/AddUnimplementedMethodsOperation.java
Commit abe74c95cd4bb707f45cdfafdfc15969525a3c90 by simeon.danailov.andreev
Bug 549457 - Autobuild does nothing on org.eclipse.jdt.core.prefs change
If the file .settings/org.eclipse.jdt.core.prefs changes, JDT does not
automatically rebuild the project. E.g. pulling different settings from
git will not result in a re-build; only changing the settings from the
Java compiler preference page will ask the user if they wish to rebuild
the workspace.
After a change in JDT core, a full build is triggered when such changes
are done. The preference page dialog option to not build on applying
Java compiler preference becomes invalid; this change removes this
dialog option.
In case this new behavior causes problems, e.g. in tooling which
re-generates project files without actually changing them, it is
possible to return to the previous behavior with the VM property:
-Dorg.eclipse.jdt.core.disableAutoBuildOnSettingsChange=true
Change-Id: Ief66752f9319051698209fbd28a5e9ca6bfee400 Signed-off-by:
Simeon Andreev <simeon.danailov.andreev@gmail.com>
The file was modifiedorg.eclipse.jdt.ui/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/OptionsConfigurationBlock.java
Commit 053e5c8e149d7fc89d9be2aff768442185c974e7 by Jeff Johnston
Bug 540337 - Bad Quickfix dialog reformats
- in AbstractAnnotationHover, modify
AnnotationInformationControl.createAnnotationInformation() to
add scroll bars to the StyledText area that shows the annotation
text so as to make space when the hover is focused and prevent
wrapping text in the focused hover
- also in computeSizeHint() use the minimum of preferred width +
trimsize + 4 and the constrained width so that an unnecessary
resize does not occur due to trim added on the screen edge
Change-Id: I267fa34378b16515852e2c167e08848172598824 Signed-off-by: Jeff
Johnston <jjohnstn@redhat.com>
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/AbstractAnnotationHover.java
Commit c59fdd54b18a4b376bce1deab9f528e1d7fdd742 by Andrey Loskutov
Bug 549555 - Temp *.class files not deleted in system temp folder
Change-Id: I249cd08ac16f7f05abf52e092922a4434350093c Signed-off-by:
Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/InternalClassFileEditorInput.java
Commit abf3e606f8fc69fe964a370f562df0fb9bfb8906 by Andrey Loskutov
Bug 549442 - Rework usages of AbstractUIPlugin#imageDescriptorFromPlugin
Use ResourceLocator#imageDescriptorFromBundle
Change-Id: I295c009bc8c1b84467a8137c45f1a294e7c6d21a Signed-off-by:
Alexander Fedorov <alexander.fedorov@arsysop.ru>
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/FilterTextControl.java