SuccessChanges

Summary

  1. Bug 549242 - Remove redundant abstract modifier on interface (details)
  2. Bug 548887 - Refactor PotentialProgrammingProblemsFix/CleanUp for jdt.ls (details)
  3. Use non-deprecated LocalSelectionTransfer. (details)
  4. Replace deprecated ViewerSorter with ViewerComparator (details)
  5. Bug 549357 - Modify new AbstractSerialVersionOperationCore for jdt.ls (details)
  6. Bug 548002 - For each conversion doesn't work for collections (details)
  7. Using indexOf char instead of indexOf String in jdt.ui (details)
Commit 50c5291155731d9f8e652a0835b77693c634ef2f by Jeff Johnston
Bug 549242 - Remove redundant abstract modifier on interface
Change-Id: If8843278d759a21e827f61e87c1e61d2179f96c4 Signed-off-by:
Fabrice-TIERCELIN <fabrice.tiercelin@yahoo.fr>
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/RedundantModifiersCleanUp.java
The file was modifiedorg.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest.java
Commit de2d9dba586fcaad896b5a53a638b3282659d95d by Jeff Johnston
Bug 548887 - Refactor PotentialProgrammingProblemsFix/CleanUp for jdt.ls
- create new PotentialProgrammingProblemsFixCore class in
jdt.core.manipulation
- change PotentialProgrammingProblemsFix to use the new
core class
- create new PotentialProgrammingProblemsCleanUpCore class in
jdt.core.manipulation
- change PotentialProgrammingProblemsCleanUp to use the
new core class
- remove SerialVersionHashOperation class and replace with
SerialVersionHashOperationCore plus SerialVersionHashOperationDisplay
and SerialVersionHashOperationDisplayCore
- replace SerialVersionDefaultOperation with
SerialVersionDefaultOperationCore
- create new AbstractSerialVersionOperationCore class in
jdt.core.manipulation
- remove AbstractSerialVersionOperation which is no longer used
Change-Id: If2c720c6e13cfad2dfa783d809c1dcdb4d60653f
The file was removedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/SerialVersionHashOperation.java
The file was removedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/CorrectionMessages.java
The file was removedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/CorrectionMessages.properties
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/text/correction/SerialVersionHashOperationCore.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/AbstractSerialVersionOperationCore.java
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/text/correction/CorrectionMessages.properties
The file was removedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/AbstractSerialVersionOperation.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/PotentialProgrammingProblemsCleanUp.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/PotentialProgrammingProblemsFixCore.java
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/fix/PotentialProgrammingProblemsCleanUpCore.java
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/text/correction/CorrectionMessages.java
The file was modifiedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/PotentialProgrammingProblemsFix.java
The file was removedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/SerialVersionDefaultOperation.java
The file was addedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SerialVersionDefaultOperationCore.java
The file was addedorg.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/text/correction/SerialVersionHashOperationDisplayCore.java
The file was addedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/SerialVersionHashOperationDisplay.java
Commit fc8324f39cabbd17beb403453f276fa481692ece by Alexander Kurtakov
Use non-deprecated LocalSelectionTransfer.
The deprecated one merely calls the new one so there can't be change in
behavior.
Change-Id: Idb3a71d3fb1a0932b9587d2ac5b3ccecebe9898f Signed-off-by:
Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/SelectionTransferDropAdapter.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dnd/JdtViewerDropSupport.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/WorkingSetDropAdapter.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/navigator/JavaDropAdapterAssistant.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dnd/BasicSelectionTransferDragAdapter.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dnd/JdtViewerDragSupport.java
The file was modifiedorg.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/packageview/WorkingSetDropAdapterTest.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultPage.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/CallHierarchyViewPart.java
Commit eb85e44ed5e93f755655e6798807af5d70761e63 by Alexander Kurtakov
Replace deprecated ViewerSorter with ViewerComparator
Change-Id: Ice406038f728d6eb310539e77b557ffc7ccee30e Signed-off-by:
Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/workingsets/ConfigureWorkingSetAssignementAction.java
Commit 51d289f03d3bb89429a57fb98e6e3816688f9908 by Jeff Johnston
Bug 549357 - Modify new AbstractSerialVersionOperationCore for jdt.ls
- add additional check for Javadoc comment to rewriteAST() method to
fix jdt.ls test failures with new code
Change-Id: I56e24f7dd71e879de2379098386e43363eb50c2b Signed-off-by: Jeff
Johnston <jjohnstn@redhat.com>
The file was modifiedorg.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/AbstractSerialVersionOperationCore.java
Commit ce2677be1d23a0c436216409b293ebc74498ecb2 by Jeff Johnston
Bug 548002 - For each conversion doesn't work for collections
- add support for Collections to ConvertForLoopOperation and
allow size() method to be used in for statement and
get(int) method to be used for element access in body
- modify and add some tests in ConvertForLoopQuickFixTest
- change all StringBuffer references in ConvertForLoopQuickFixTest
to be StringBuilder
Change-Id: Ia1dcc27522f622d12e544ed7c84ba2500d77c909 Signed-off-by: Jeff
Johnston <jjohnstn@redhat.com>
The file was modifiedorg.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/ConvertForLoopQuickFixTest.java
The file was modifiedorg.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/ConvertForLoopOperation.java
Commit fce8e441a9dd9a8de1f7fc58901c7e8140fe0423 by Jeff Johnston
Using indexOf char instead of indexOf String in jdt.ui
See https://sourceforge.net/p/findbugs/feature-requests/300/#cb7f for a
performance related discussion
Change-Id: Ib1aeab169e5443d4b8279c9629e7fe2806fd9f1d Signed-off-by: Lars
Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/IntroduceParameterRefactoring.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/PackagesViewLabelProvider.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/FilteredPreferenceTree.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java
The file was modifiedorg.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ChainCompletionTemplateBuilder.java
The file was modifiedorg.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RenameCompilationUnitProcessor.java