FailedChanges

Summary

  1. Bug 542860 - fixed "synthetic accessor method" warning (details)
  2. Bug 548505 - Use addAll instead of looping through a collection (details)
  3. Bug 548505 - Removes unused variable in CompilationUnit (details)
  4. Bug 548589 - [1.8][inference] Cannot infer type argument(s) for <R> (details)
  5. Bug 547591 - Add failOnWarning (-Werror like) flag to the batch compiler (details)
  6. Bug 548456 - Race condition in JavaElement.exists() and JavaModelCache (details)
  7. Bug 548662 - Several versions must be increased (details)
  8. Bug 547417 - trying to fix 180 test fails, take 3 (details)
  9. Add toString() to OpenableElementInfo (details)
  10. Bug 544921 - [performance] Poor performance with large source files (details)
Commit d8cf470faa5d6433d6f05d7fe7f7ee0051608f69 by loskutov
Bug 542860 - fixed "synthetic accessor method" warning
Change-Id: I774962ce154b0245218a654431b064818b32586b Signed-off-by:
Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
Commit 1ad679878046a65003a885ee0c5c701654f19154 by manpalat
Bug 548505 - Use addAll instead of looping through a collection
Simplifies reading the code.
Change-Id: Ia69651dbbb3a9dad1a20e336426cd48fe1d0c1a6 Signed-off-by: Lars
Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/internal/core/dom/rewrite/ASTRewriteFormatter.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/CompilationUnit.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/util/ModuleUtil.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/JavaProject.java
Commit dcc5dc9c9c6be1356e6fcc76cf06c9912feb98ea by Lars.Vogel
Bug 548505 - Removes unused variable in CompilationUnit
Change-Id: Icbb78a2bcb6e599bbef09dc5cd1f6ffefff8c89d Signed-off-by: Lars
Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/CompilationUnit.java
Commit 4ac2904e518928fb9f4aa2fc7f5f3e9b92d231e5 by stephan.herrmann
Bug 548589 - [1.8][inference] Cannot infer type argument(s) for <R>
map(Function<? super T,? extends R>)
Change-Id: I4f583c8491f730858fcaa94d16494b78aa5cbb92
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/InferenceContext18.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/GenericsRegressionTest_1_8.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ConstraintExpressionFormula.java
Commit 6457b6c80a6b7bdd29674a56ca3dd77128e86cc1 by stephan.herrmann
Bug 547591 - Add failOnWarning (-Werror like) flag to the batch compiler
Mimic javac's -Werror behavior. Report warnings as warnings but if
-fainOnWarning argument is given and there are warnings return false
from Main.compile or exit with -1. In case there are warnings and the
argument is passed print "error: warnings found and -failOnWarning
specified" at the end to make it clear to users why the build failed.
Change-Id: Id7268746ed29481a20dd6d295134dcd5db7ce437 Signed-off-by:
Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/Main.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/messages.properties
Commit ef0b1ee7a4ba561e8d3b59ac4f29dfada60a9cee by loskutov
Bug 548456 - Race condition in JavaElement.exists() and JavaModelCache
Concurrent calls to BinaryType.exists() can sometimes result in false
for one of the callers, despite the type existing.
This is the case due to the two-cache approach in JavaModelManager - it
has thread local JavaModelManager.temporaryCache and global shared
JavaModelManager.cache.
Given two threads calling BinaryType.exists() and nothing is in the
global cache, the 1st thread adds the necessary types to the shared
JavaModelManager.cache via JavaElement.openWhenClosed(), while the 2nd
thread enters JavaElement.openWhenClosed() and is at the beginning of
SourceRefElement.generateInfos().
In the SourceRefElement.generateInfos() 2nd thread then finds element
info for the parent of the BinaryType and assumes there is nothing to be
done, so it leaves the local JavaModelManager.temporaryCache empty.
After the call of SourceRefElement.generateInfos()
JavaElement.openWhenClosed() can't find anything in the local cache and
throws a JavaModelException which causes BinaryType.exists() to return
"false", which is wrong and not expected by the caller.
With this change, JavaElement.openWhenClosed() takes this case into
account and double checks with the JavaModelManager if no info was
generated during JavaElement.generateInfos(). This ensures that no
exception is thrown and that the correct element info is returned by
JavaElement.openWhenClosed(). Without the exception, BinaryType.exists()
returns true as expected.
This change also adds a test which can sometimes show the behavior with
sufficient repetition, if no fix is applied.
To observe the problem manually:
1. set repetition in the test to 1 2. set a breakpoint at the start of:
SourceRefElement.generateInfos() 3. run the test 4. resume one of the
threads at the breakpoint from 2. 5. resume the other thread at the
breakpoint from 2. 6. observe that BinaryType.exists() returns false for
the 2nd thread
Change-Id: Id576dd5eabfa060277ab31a9c7eb8da05ce71410 Signed-off-by:
Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey
Loskutov <loskutov@gmx.de>
The file was addedorg.eclipse.jdt.core.tests.model/workspace/JavaModelManagerTests/lib.jar
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/AllJavaModelTests.java
The file was addedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/JavaModelManagerTests.java
The file was addedorg.eclipse.jdt.core.tests.model/workspace/JavaModelManagerTests/.project
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/JavaElement.java
The file was addedorg.eclipse.jdt.core.tests.model/workspace/JavaModelManagerTests/.classpath
Commit 679e7292c0717bd8f4d605db0877d8af50283d6f by jarthana
Bug 548662 - Several versions must be increased
Change-Id: I6b77db290718ec5d0487a921d59e0e6ebac8cf22 Signed-off-by: Jay
Arthanareeswaran <jarthana@in.ibm.com>
The file was modifiedorg.eclipse.jdt.apt.pluggable.core/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.jdt.apt.pluggable.core/pom.xml
The file was modifiedorg.eclipse.jdt.apt.core/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.jdt.core.tests.compiler/pom.xml
The file was modifiedorg.eclipse.jdt.core.tests.model/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.jdt.core.tests.compiler/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.jdt.core.tests.model/pom.xml
The file was modifiedorg.eclipse.jdt.apt.core/pom.xml
Commit 0853e4491995675cf2ef936b5f57f1c77b00d837 by loskutov
Bug 547417 - trying to fix 180 test fails, take 3
- increased timeout again from 20 to 30 seconds
- increased attempts count from 10 to 30
- redirect all output to System.out, because this seem the only stream
we get logged in tests
Change-Id: I76f9293d2a5b786e669cc9e1e1b23938d9a1ca20 Signed-off-by:
Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/eval/DebugEvaluationSetup.java
Commit 135b4845f62f2545b0f8f1d92be3529266be2e6b by loskutov
Add toString() to OpenableElementInfo
Change-Id: I09d03b57348fa5d6cea5b07d3233f0da1c56f26a Signed-off-by:
Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/OpenableElementInfo.java
Commit ce38a825e5163c3b9eafad08b20d1266948e370e by loskutov
Bug 544921 - [performance] Poor performance with large source files
This patch uses sorted arrays in the CompilationUnitScope to improve the
runtime behavior with large source files where a large number of
dependent types exist and need to be recorded in the
qualifiedReferences, simpleNameReferences and rootReferences.
Lookup of memberTypes by name from a ReferenceBinding does use binary
search logic, too (similar approach as with fields).
Sorting of char[][] is extracted to SortedCharArrays.
CompoundNameVector is removed and replaced by SortedCompoundNameVector.
SimpleNameVector is removed and replaced by SortedSimpleNameVector.
Change-Id: Ib66c7f0399cdea0c5558a15bf835406ceb828988 Signed-off-by:
Sebastian Zarnekow <sebastian.zarnekow@gmail.com> Also-By: Simeon
Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey
Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/CompilationUnitScope.java
The file was addedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/SortedCharArrays.java
The file was addedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SortedCompoundNameVector.java
The file was addedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ReferenceBindingSetWrapper.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ReferenceBinding.java
The file was addedorg.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/Bug544921Test.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
The file was removedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/CompoundNameVector.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/BinaryTypeBinding.java
The file was addedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SortedSimpleNameVector.java
The file was removedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/SimpleNameVector.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ParameterizedTypeBinding.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/ReferenceCollection.java
The file was modifiedorg.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/BuilderTests.java