FailedChanges

Summary

  1. Bug 562436 - ASTParser.createBindings fails if Editor opens concurrently (details)
  2. Bug 560473 - Add interface for getting type, field or method from import (details)
  3. Version bump for 4.17 (details)
  4. Bug 535062 - Annotation with @target MODULE are not processed (details)
  5. Bug 560472 - MethodScope.createMethod does not populate method.binding.parameterNames from Argument[] (details)
  6. Bug 477291 - Ensure the module field is being set (details)
Commit 4660e32eca67ecb827126d309213e16a72cf15c4 by Andrey Loskutov
Bug 562436 - ASTParser.createBindings fails if Editor opens concurrently

CompilationUnit.getContents() and CompilationUnit.discardWorkingCopy()
can be called concurrently, causing the getContents() method to throw an
exception. This in turn can cause ASTParser.createBindings() to fail.

In particular, its possible for CompilationUnit.getContents() to
retrieve an open buffer via BufferManager.getBuffer(). This buffer can
then be closed, before CompilationUnit.getContents() calls
IBuffer.getCharacters(). As a result, getCharacters() returns null and
CompilationUnit.getContents() throws an exception.

With this change CompilationUnit.getContents() resorts to reading the
compilation unit file directly, in case the compilation unit buffer was
closed after obtaining it, but before the buffers characters were
retrieved.

Change-Id: I01772e638bf4160defc63196629a710f214181c5
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/CompilationUnit.java
Commit e199098ffba9b8263ba214975f103238cb9d3e99 by Manoj Palat
Bug 560473 - Add interface for getting type, field or method from import

Change-Id: I1d465166d972a78f72cef9c6b062d8d0cdf51769
Signed-off-by: Eric Milles <eric.milles@thomsonreuters.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/CompilationUnitScope.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ImportBinding.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/ImportReference.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
Commit ac8d818958a2bb1980a69b06e376cc79478cb444 by Alexander Kurtakov
Version bump for 4.17

Change-Id: Iee10450878e791f3a30f07b5fdd59585ada2b1dd
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
The file was modifiedorg.eclipse.jdt.core/pom.xml
The file was modifiedorg.eclipse.jdt.core/META-INF/MANIFEST.MF
Commit 7acea359fe605084db24f8e2d48cbed265feed98 by Jay Arthanareeswaran
Bug 535062 - Annotation with @target MODULE are not processed

Change-Id: Ib9a8974ec13644444b10fb0bf2c119da6d453410
Signed-off-by: Jeremy Kuhn <jeremy.kuhn1@gmail.com>
The file was modifiedorg.eclipse.jdt.compiler.apt.tests/META-INF/MANIFEST.MF
The file was addedorg.eclipse.jdt.compiler.apt.tests/resources/mod_locations/modules/mod.c/def/A.java
The file was addedorg.eclipse.jdt.compiler.apt.tests/resources/mod_locations/modules/mod.c/def/Module.java
The file was modifiedorg.eclipse.jdt.compiler.apt.tests/processors8/META-INF/services/javax.annotation.processing.Processor
The file was removedorg.eclipse.jdt.compiler.apt.tests/processors8/org/eclipse/jdt/compiler/apt/tests/annotations/FooBarAnnotation.java
The file was modifiedorg.eclipse.jdt.compiler.apt.tests/src/org/eclipse/jdt/compiler/apt/tests/Java9ElementsTests.java
The file was modifiedorg.eclipse.jdt.compiler.apt.tests/lib/apttestprocessors8.jar
The file was modifiedorg.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/model/ModuleElementImpl.java
The file was modifiedorg.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/AnnotationDiscoveryVisitor.java
The file was modifiedorg.eclipse.jdt.compiler.apt/META-INF/MANIFEST.MF
The file was addedorg.eclipse.jdt.compiler.apt.tests/resources/mod_locations/modules/mod.c/module-info.java
The file was modifiedorg.eclipse.jdt.compiler.apt.tests/pom.xml
The file was modifiedorg.eclipse.jdt.compiler.apt.tests/processors8/org/eclipse/jdt/compiler/apt/tests/processors/elements/Java9ElementProcessor.java
The file was modifiedorg.eclipse.jdt.compiler.apt/pom.xml
The file was addedorg.eclipse.jdt.compiler.apt.tests/processors8/org/eclipse/jdt/compiler/apt/tests/processors/elements/Java9ModuleProcessor.java
The file was modifiedorg.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BaseMessagerImpl.java
Commit 507b2ed26269623efabbe7b5116c033807bcad9c by Manoj Palat
Bug 560472 - MethodScope.createMethod does not populate method.binding.parameterNames from Argument[]

Change-Id: I8e173d29bf6142bab3487051229bb5f544a40983
Signed-off-by: Eric Milles <eric.milles@thomsonreuters.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodScope.java
Commit d190758dff5828ee7573c258060fb0afa733c921 by Jay Arthanareeswaran
Bug 477291 - Ensure the module field is being set

Change-Id: Ibbfb775dc082a91e7d7189f2159b3b39a4e4a0e6
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
The file was modifiedorg.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/util/JrtFileSystem.java