FailedChanges

Summary

  1. Bug 562460 - [14] Text block omits first character if followed by an (details)
  2. Bug 562502 - [14][compiler][internal] Merge RecordComponent with (details)
  3. Bug 562473 - ECJ help reports supported source level up to 1.9 only (details)
  4. Bug 562473 - Testcase (details)
  5. Bug 559348 - Investigate API tooling warnings in jdt.core (details)
  6. Bug 546852 - Cache JRT classfiles for faster class reading (details)
  7. Bug 562559 - avoid declaring ClassFormatException if not needed (details)
  8. Bug 562559 - simplified getJrtSystem() implementation / synchronization (details)
  9. Bug 562559 - code cleanup (details)
  10. Use PlatformUI.getWorkbench() to avoid deprecated warning (details)
  11. Bug 548416 - [13] [test][dom ast rewrite] Fix test failures in Java 13 (details)
  12. Bug 561268 - Search for all methods returning type misses generics (details)
  13. Bug 459092 - Intermittent failures in CopyMoveElementsTests (details)
Commit a3855b0571f0ba0e7dcf84d5a93153b2081ba412 by Jay Arthanareeswaran
Bug 562460 - [14] Text block omits first character if followed by an
escape sequence

Change-Id: I103bcc52e1fd40fa4fc43e86f80b0148ed9a0ca0
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Scanner.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/TextBlockTest.java
Commit 7703952e861a2c9c717f3e24646d99644137d398 by Manoj Palat
Bug 562502 - [14][compiler][internal] Merge RecordComponent with
TypeDeclaration

Change-Id: I21ef8b59ba58b92fa513760ce94f6cd92e6bbc92
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/TypeParameter.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/Javadoc.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/compiler/parser/SourceTypeConverter.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTConverter.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/TypeReference.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/MethodDeclaration.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionOnJavadocTag.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/FieldDeclaration.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/CompactConstructorDeclaration.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ClassScope.java
The file was removedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/RecordDeclaration.java
Commit 1b037f16837438caec60154444a8fd4eb665b250 by Jay Arthanareeswaran
Bug 562473 - ECJ help reports supported source level up to 1.9 only

Change-Id: I90ea19b46519eddfa1a936f8481fba7da999a41d
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/messages.properties
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/Main.java
Commit f1f6763f5069b7e6c2e75d4a849238713ebcb99c by Jay Arthanareeswaran
Bug 562473 - Testcase

Change-Id: I3937cbe001806fed7e48a8aa56e2311d17049f42
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest2.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/TestAll.java
Commit e4072da524adc7f2cdd4f60e326b870e61ee6a04 by Vikas Chandra
Bug 559348 - Investigate API tooling warnings in jdt.core 

Change-Id: Iabeedfe1bc099319f5b55e38c07e1e6641ce13a7
Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core/.settings/.api_filters
Commit 07b721bc3b658abcda3447c183f4433b52376df5 by Andrey Loskutov
Bug 546852 - Cache JRT classfiles for faster class reading

Enable stupid simple JRT file cache for files retrieved from JRT file
system. The cache is enabled by default and can be disabled by
setting system property -Dorg.eclipse.jdt.disable_JRT_cache=true.

Note: we also cache "null" cache lookup results to speedup false
searches.

Change-Id: I5233354a2e5e80058fb01fb6d796434ec3eb6389
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Also-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
Also-by: Markus Duft <markus.duft@ssi-schaefer.com>
Also-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/JRTUtil.java
Commit 6f048d1aab26bf3060aa31484e70a37fde4c5db6 by Andrey Loskutov
Bug 562559 - avoid declaring ClassFormatException if not needed

JrtUtilorg.getClassfileContent(File, String, String) declares that it
can throw ClassFormatException but it is actually doesn't and so many
clients have catch blocks it without ever need them.

Change-Id: I7fa4bed3dd145b16e0d2ea0adffb2dc5870992f0
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/AbstractClassFile.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/ClasspathJrt.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/AddJrtToIndex.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/ClasspathJrt.java
The file was modifiedorg.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/util/JrtFileSystem.java
The file was modifiedorg.eclipse.jdt.compiler.tool/src/org/eclipse/jdt/internal/compiler/tool/JrtFileSystem.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/JRTUtil.java
Commit 46b389e11fedf87b85b092ced8a823572e4ffadd by Andrey Loskutov
Bug 562559 - simplified getJrtSystem() implementation / synchronization

Replaces static HashMap with static ConcurrentHashMap and removed
unneded synchronization around it.

Change-Id: Ic9da6354ff236d851312b6d225ccd21c6b0df12f
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/JRTUtil.java
Commit 954ea79a9532e06a3b2216eb824f6e9c52403095 by Andrey Loskutov
Bug 562559 - code cleanup

Made code more readable and fixed some smaller issues.

Change-Id: I03444258e6eb1153463592b6b67eaebc51bf677d
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/JRTUtil.java
Commit 1f93561bae63c9cb26248cb8b8f2581c869490e1 by Jay Arthanareeswaran
Use PlatformUI.getWorkbench() to avoid deprecated warning

Change-Id: I18a6ded6add759c7cbe3f01698ceeb30ce26947f
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
The file was modifiedorg.eclipse.jdt.apt.ui/src/org/eclipse/jdt/apt/ui/internal/AptUIPlugin.java
Commit 5f2272e458f30f9f8dc791cca6e4e0d92346b1fc by Sarika Sinha
Bug 548416 - [13] [test][dom ast rewrite] Fix test failures in Java 13
Moved break to yield statements

Change-Id: I5c46c3dd36d8c61401eb91122b32a3ea07033d6e
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingSwitchExpressionsTest.java
Commit 57460b9c53188deef848183c3e504880d733b757 by Jeff Johnston
Bug 561268 - Search for all methods returning type misses generics

- add new override method consumeMethodHeaderNameWithTypeParameters()
  to MatchLocatorParser that will look for a finegrain of
  IJavaSearchConstants.RETURN_TYPE_REFERENCE and attempt to find
  a match for a return type similar to consumeMethodHeaderName()

Change-Id: I77c239ab69eb2ef50520b50e7cd84d34e29df250
The file was addedorg.eclipse.jdt.core.tests.model/workspace/JavaSearch15/src/g7/a/def/ISearchTest.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/matching/MatchLocatorParser.java
The file was addedorg.eclipse.jdt.core.tests.model/workspace/JavaSearch15/src/g7/a/def/SearchTestImpl.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/JavaSearchFineGrainTests.java
The file was addedorg.eclipse.jdt.core.tests.model/workspace/JavaSearch15/src/g7/a/ref/TestSearch.java
Commit 0da13740bd5530ee1f5475770b634e150c63d195 by Stephan Herrmann
Bug 459092 - Intermittent failures in CopyMoveElementsTests

- split asserts, log stacktraces on failure

Change-Id: I38219e7833b48511cc397db4e97a8c932770a6f1
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CopyMoveTests.java