Changes

Summary

  1. Bug 574845 -small meta index cleanup and more debug logging (details)
  2. Bug 574903 - Simplify code around awaitingJobs in (details)
  3. Bug 574903 - fixed index saving / waiting for first job (details)
  4. Bug 574845 - filter incoming meta index updates (details)
  5. Bug 574892: Pattern variable not found in conditionals under AND AND (details)
  6. Bug 553097 - [13][content assist] No code completion after text block (details)
  7. Bug 574906: In-scope pattern variables do not flow into instanceof-expressions (details)
  8. Bug 574912 - [content assist] Content assist in lambda hangs worker (details)
  9. Bug 574944 - CompletionTests fail sporadically since I20210718-1800 (details)
  10. Bug 574929 - ITypeBinding.getTypeBounds() returns an empty array for an (details)
  11. Bug 574870 - [16] Declaration of pattern variable in instanceof (details)
  12. Bug 574823 - fix chained completions on method invocations inside if (details)
  13. Bug 574912 - [content assist] Content assist in lambda hangs worker (details)
Commit a1c581265060c7899d5d753204d7e711ec536998 by Gayan Perera
Bug 574845 -small meta index cleanup and more debug logging

- call updateMetaIndex(index) on index save only if index.hasChanged()
- guard from retrieving getMetaIndexQualifications() if meta-index is
disabled
- more debug logging


Change-Id: I49e44955caf86ae5edafc9cfd242a216ec442e14
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183140
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Gayan Perera <gayanper@gmail.com>
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/IndexManager.java
Commit 36c12e4c31a23f7233f2d03ca0262b9b1894f39a by Andrey Loskutov
Bug 574903 - Simplify code around awaitingJobs in
search.processing.JobManager

Use LinkedList instead of manually maintained array based queue.

Change-Id: I88e72428a6730333807ca04c3cd115241af676d9
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183141
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/IndexManager.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/processing/JobManager.java
Commit 00d18b799e3c424eef7921d5fcec03715be68fc7 by Andrey Loskutov
Bug 574903 - fixed index saving / waiting for first job

Change-Id: I461c84d4a24eeff3041f1e9b30b5b6a9e8abe94e
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183143
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/processing/JobManager.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/IndexManager.java
Commit 12056e3a5fac3bd25cc592b6e17c65714395ba1b by Andrey Loskutov
Bug 574845 - filter incoming meta index updates

Put meta index updates in the queue only if no similar updates are
already scheduled.

Change-Id: I529d30dcd8c2ce821e0f5381b46939973c541f0e
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183142
Reviewed-by: Gayan Perera <gayanper@gmail.com>
Tested-by: Gayan Perera <gayanper@gmail.com>
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/RemoveFromIndex.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/IndexManager.java
Commit fcdfe4588e65836d20e45ed9edadd2c544b04324 by Jay Arthanareeswaran
Bug 574892: Pattern variable not found in conditionals under AND AND

Change-Id: I8155f8c9da9348b54953cc310ce2f2655b783e45
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183144
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/ConditionalExpression.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/PatternMatching16Test.java
Commit e727d58219cd1f68e119c0fc71593fb196ba0bd8 by Jay Arthanareeswaran
Bug 553097 - [13][content assist] No code completion after text block

Change-Id: Ia03fc638d0bfd081b6eb0b561955a3bc694c7c97
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183121
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Scanner.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/TextBlockTest.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests14.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionContextTests.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/TestAll.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionScanner.java
Commit 7ceff60eadcc538b3468b758f95b2ace2fc41bbc by Jay Arthanareeswaran
Bug 574906: In-scope pattern variables do not flow into instanceof-expressions

Also cleanup redundant addPatternVariablesWhenTrue which is implemented generally in Expression

Change-Id: I67355daa48d3e67ceb317d3968b8474fd3175d9d
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183152
Reviewed-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/InstanceOfExpression.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/PatternMatching16Test.java
Commit 36819e7425b2ecbadfde1f9d2ff8831a40f87d74 by Stephan Herrmann
Bug 574912 - [content assist] Content assist in lambda hangs worker
threads or runs into error dialog

Change-Id: If4485c499f57e87de2378083ce7dfe216972e9d2
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183196
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionParser.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
Commit 2cbac7b33882c89e42c6026030785a6baae5c88b by Andrey Loskutov
Bug 574944 - CompletionTests fail sporadically since I20210718-1800

Let enable indexer and see if that helps to avoid sporadic fails.

Change-Id: Ie8d27e75b57aa2e0b787d85bc855f58141f658e8
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183231
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests_1_5.java
Commit 988d081198f40365cb4e90928cae635fffc40f5f by Jay Arthanareeswaran
Bug 574929 - ITypeBinding.getTypeBounds() returns an empty array for an
intersection type

Change-Id: Ifbfc51c7e14d7be4db2955eab1b1492a89ef42f4
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183211
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/TypeBinding.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverter_16Test.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/RunConverterTests.java
Commit 860b60992e8980c438870a6fe57daecabe8036f5 by Vikas Chandra
Bug 574870 - [16] Declaration of pattern variable in instanceof
expression is not found

The pattern variable declaration (introduced in J16) in instanceof
expression was never searched for. With this change, the JDT search
looks for declaration in the pattern variable declaration.

Change-Id: I87b73b82da7dc17e87de3fb18ae592f8f4c9053b
Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183101
Reviewed-by: Manoj Palat <manpalat@in.ibm.com>
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/JavaSearchBugs16Tests.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/matching/MatchLocatorParser.java
Commit 08fc1337f1f9aaff0490648702821e7090ae70cb by Stephan Herrmann
Bug 574823 - fix chained completions on method invocations inside if

Revert complexity from bug 573632 superseded by bug 574215

Change-Id: I3c034d7cd370913b9abb95e109f8fe71cee05851
Also-by: Gayan Perera <gayanper@gmail.com>
Signed-off-by: Stephan Herrmann <stephan.herrmann@berlin.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183239
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionParser.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
Commit d5a7441da373df8e89653767579b519cc98c9a72 by Stephan Herrmann
Bug 574912 - [content assist] Content assist in lambda hangs worker
threads or runs into error dialog

reopened at comment 6:
  - emergency halt if resume makes no progress

Change-Id: I178239caf56cdef8549908fb13176bd9ef38dc41
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/183310
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/impl/AssistParser.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java