FailedChanges

Summary

  1. Bug 539617 - Content assist not working for constructors in lamda (details)
  2. Bug 573158 - [16] BatchCompilerTest_16 is not part of any suite yet (details)
  3. Bug 572966 - Add ASTRewritingInstanceOfPatternExpressionTest to a suite (details)
  4. Bug 563004 - [parser][14] Parse compact record (details)
  5. Bug 572994 - Compiler does not report an error on instantiating (details)
  6. Bug 473654 - Content assist hangs (details)
  7. Bug 546097 - [content assist] Content Assist takes very long/aborts (details)
  8. Bug 573195 - [16][record] protected modifier missing in canonical (details)
  9. Bug 573158 - [16] BatchCompilerTest_16 is not part of any suite yet - (details)
  10. Bug 572382: Switch expression void returns from MethodHandle.invoke() (details)
  11. Bug 572380 - [16][pattern instanceof] pattern variable not found in && (details)
  12. Bug 573250 - [test] fixed NPE in ASTConverter14Test (details)
  13. Bug 388314 - @javax.annotation.Nonnull triggers bug in javac (details)
  14. Bug 572277 - [performance] improve Util.getResourceContentsAsCharArray (details)
  15. Bug 457813 - [type hierarchy] Stack overflow (details)
  16. Revert "Bug 572277 - [performance] improve Util.getResourceContentsAsCharArray" (details)
Commit f19d20e6a917016c9405829df3732ebb1d810478 by Stephan Herrmann
Bug 539617 - Content assist not working for constructors in lamda
expressions

Change-Id: Ib34293ac03315f47788b3a3ff50be0376d562913
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/130512
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionOnQualifiedAllocationExpression.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionParser.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionOnMessageSend.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/CompletionParserTest.java
Commit d2c5473e050dbc8239109bec60e42bcce593c7c3 by Manoj Palat
Bug 573158 - [16] BatchCompilerTest_16 is not part of any suite yet

Change-Id: If251c66df651b65fb99b9b3e7233aa0a24146831
Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179814
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/AbstractBatchCompilerTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest_15.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest_16.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/TestAll.java
Commit b80d29885c0e02c3a524d5cff05288c6e174879c by Jay Arthanareeswaran
Bug 572966 - Add ASTRewritingInstanceOfPatternExpressionTest to a suite

Change-Id: Ia9e1dbd8f017fc568bb43bdd4961af5c3ecc5a5e
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179539
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingTest.java
Commit ea65681e2c5e1f609892c6ae4cd2b46da5c0122d by Sarika Sinha
Bug 563004 - [parser][14] Parse compact record
constructor with kind
K_CLASS_BODY_DECLARATIONS

Change-Id: I2a488f0a3501ac1cf4af625ae2f09cbc0a61ea9e
Also-by: Sarika Sinha <sarika.sinha@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179512
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Sarika Sinha <sarika.sinha@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser20.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser9.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser16.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser19.rsc
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTConverter.java
The file was modifiedorg.eclipse.jdt.core/grammar/java.g
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser12.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser5.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser18.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser22.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser21.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser6.rsc
The file was modifiedorg.eclipse.jdt.core/formatter/org/eclipse/jdt/core/formatter/CodeFormatter.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser7.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser24.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser15.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/ParserBasicInformation.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser1.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser14.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/TerminalTokens.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser17.rsc
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/util/CodeSnippetParsingUtil.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser13.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser2.rsc
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/formatter/FormatterBugsTests.java
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTParser.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser8.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser3.rsc
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/parser4.rsc
The file was modifiedorg.eclipse.jdt.core/.settings/.api_filters
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java
Commit d21d83fa5b10b0212b45e0894a4a64a2dd28e947 by Manoj Palat
Bug 572994 - Compiler does not report an error on instantiating
nonstatic inner class from static context which breaks JVM

Change-Id: I61f4f4e3700eaaeb39782cededb03533678d258c
Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179871
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/LocalStaticsTest.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/BlockScope.java
Commit 2191b84a942a57a5c36bf91d049e314bfb94ae2d by Stephan Herrmann
Bug 473654 - Content assist hangs

test for comment 33

Change-Id: Ia7deba26f6407307497f78025e3fca8525b6c3f9
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
Commit bc061ab235fc554c2c5ab1a0746361f46ed36ffa by Stephan Herrmann
Bug 546097 - [content assist] Content Assist takes very long/aborts

Change-Id: I98a95ace353826459ce8c4901fbf6afc779efa6e
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
Commit 0d7e21a3d5f8d2967cb621146a8a5a3e010c9ab1 by Manoj Palat
Bug 573195 - [16][record] protected modifier missing in canonical
constructor

Change-Id: If99d44b6c8095ae4e448c0e9ee247edc47b3fa51
Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179885
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SyntheticMethodBinding.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/RecordsRestrictedClassTest.java
Commit 5140b6d22c40d82b7abebad04ed25f46c5bd7240 by Manoj Palat
Bug 573158 - [16] BatchCompilerTest_16 is not part of any suite yet -
followup commmit for removing preview and correcting the cond

Change-Id: I2bebf1a165040275a05ea4cdf227185c91466e0a
Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179916
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest_16.java
Commit 9f4685b2c86042fb6e5d6c73005604fe6443e0da by Manoj Palat
Bug 572382: Switch expression void returns from MethodHandle.invoke()

Change-Id: Ib8947f9f36a47de88bc7ca3435869853b43b2672
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178542
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Manoj Palat <manpalat@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/SwitchExpressionsYieldTest.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java
Commit 01b98e66066476e5b62cd990931342d1cc4619d3 by Jesper Moller
Bug 572380 - [16][pattern instanceof] pattern variable not found in &&

Signed-off-by: Jesper Steen Møller <jesper@selskabet.org>
Also-By: Jay Arthanareeswaran <jarthana@in.ibm.com>
Change-Id: I98cf907640520194d647817a58feec9b520c853e
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179964
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/PatternMatching16Test.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/AND_AND_Expression.java
Commit d12467ae6f3a4881163eb2f3cfbb1122b799adcc by Andrey Loskutov
Bug 573250 - [test] fixed NPE in ASTConverter14Test

Change-Id: I6a1e27e761524851f4b6601ba8054d7b2f25f0ca
Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179992
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverter14Test.java
Commit ad636457e7dd73872645cfb6765c9e9119a9ba54 by Stephan Herrmann
Bug 388314 - @javax.annotation.Nonnull triggers bug in javac

This doesn't change compiler behavior but attempts to fix the
inconsistency between compiler and disassembler.

Change-Id: I316fda159968f2c4964c7abaaeaf7b7ade910b4c
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179999
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/util/Disassembler.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/EnumTest.java
Commit 141932dc82a2da30d55c83ad27de394755693779 by Fabrice Tiercelin
Bug 572277 - [performance] improve Util.getResourceContentsAsCharArray

Length is ignored anyway because the size in bytes is meaningless when
reading variable sized char encodings (Bug 149028)

Change-Id: Ib5c230bf6852db706b4c2a6be961e5115a3f06fc
Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178352
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Fabrice Tiercelin <fabrice.tiercelin@yahoo.fr>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/util/Util.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/nd/indexer/Indexer.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/ManifestAnalyzer.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/ClasspathSourceJar.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/APIDocumentationTests.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/Util.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/EncodingTests.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/formatter/FormatterRegressionTests.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ClasspathEntry.java
Commit ef189e229c5c78d589b7544bfbf1894d96f173af by Manoj Palat
Bug 457813 - [type hierarchy] Stack overflow

Change-Id: If81063fd778cc4788558175c6267a552cfcfee43
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179967
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Manoj Palat <manpalat@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/TypeHierarchyTests.java
The file was addedorg.eclipse.jdt.core.tests.model/workspace/TypeHierarchy/test457813.jar
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java
Commit 2685ba0b578528628dc5926cdffb1c0ebcdf7335 by Manoj Palat
Revert "Bug 572277 - [performance] improve Util.getResourceContentsAsCharArray"

This reverts commit 141932dc82a2da30d55c83ad27de394755693779.

Change-Id: Ib7005e634583e3b8cb2b9f96d2c6c0a0523c2263
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/180025
Tested-by: Manoj Palat <manpalat@in.ibm.com>
Reviewed-by: Manoj Palat <manpalat@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/Util.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ClasspathEntry.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/APIDocumentationTests.java
The file was modifiedorg.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/nd/indexer/Indexer.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/formatter/FormatterRegressionTests.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/util/Util.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/ManifestAnalyzer.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/ClasspathSourceJar.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/EncodingTests.java